build: task build does not retrigger on a ui/dist-only change #1359

Closed
opened 2026-10-27 13:40:04 +00:00 by sam · 0 comments
Owner

Found by the Wave 0R claims audit (c10).

Taskfile.yml:325 sources are **/*.go, go.mod and go.sum, while the dashboard is embedded via ui/embed.go:18 //go:embed all:dist. task ui rewrites ui/dist in place (Taskfile.yml:172-176), so task ui && task build prints 'task: Task "build" is up to date' and leaves the previously embedded dashboard in bin/archied. Generated assets are LAW in this repository, so a ui/dist-only change must retrigger the build.

Same class: the ldflags version stamps at Taskfile.yml:321-324 come from git describe, which a file-only checksum cannot invalidate, so a new tag or HEAD movement with unchanged Go content leaves the old -X ...version values in the binaries.

Fix direction: add ui/dist/** to the build task sources, and make the version stamp an input to the checksum.

Until this lands, the Wave 4 merge train runs task build --force before task check (recorded in prompts/wave4-merge-train.md).

Notes

DUPLICATE RISK: the pre-existing branch fix/dashboard-vocabulary-single-source contains 5f06f489 'fix(build): verify ui/dist is fresh instead of never looking at it' and b747af06 'fix(ui): make the served vocabulary reach an already-painted page' (2026-09-20). The first appears to cover this bead's task-build-sources gap; check it before working this bead, including whether it also handles the ldflags/version-stamp input noted here.

Close reason

Closed on GitHub with verification evidence; confirmed against the tree.


Imported from beads archie-core-hhgw · GitHub #1151 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-05

Found by the Wave 0R claims audit (c10). Taskfile.yml:325 sources are **/*.go, go.mod and go.sum, while the dashboard is embedded via ui/embed.go:18 //go:embed all:dist. task ui rewrites ui/dist in place (Taskfile.yml:172-176), so `task ui && task build` prints 'task: Task "build" is up to date' and leaves the previously embedded dashboard in bin/archied. Generated assets are LAW in this repository, so a ui/dist-only change must retrigger the build. Same class: the ldflags version stamps at Taskfile.yml:321-324 come from git describe, which a file-only checksum cannot invalidate, so a new tag or HEAD movement with unchanged Go content leaves the old -X ...version values in the binaries. Fix direction: add ui/dist/** to the build task sources, and make the version stamp an input to the checksum. Until this lands, the Wave 4 merge train runs `task build --force` before `task check` (recorded in prompts/wave4-merge-train.md). ### Notes DUPLICATE RISK: the pre-existing branch fix/dashboard-vocabulary-single-source contains 5f06f489 'fix(build): verify ui/dist is fresh instead of never looking at it' and b747af06 'fix(ui): make the served vocabulary reach an already-painted page' (2026-09-20). The first appears to cover this bead's task-build-sources gap; check it before working this bead, including whether it also handles the ldflags/version-stamp input noted here. ### Close reason Closed on GitHub with verification evidence; confirmed against the tree. --- _Imported from beads `archie-core-hhgw` · GitHub #1151 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-05_
sam added the mediumbug labels 2026-10-27 13:40:04 +00:00
sam self-assigned this 2026-10-27 13:40:04 +00:00
sam closed this issue 2026-10-27 13:40:04 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1359