Test-quality debt: brittle fixtures, duplicated literals and unverified helper claims #1343

Closed
opened 2026-10-27 13:40:00 +00:00 by sam · 0 comments
Owner

Scoped audit (2026-09-26, 3 read-only investigator agents) into the test-quality bar CLAUDE.md's Development Protocol states but does not enforce: tests pinned to a literal instead of a named constant, tests asserting an exact enumerated set that any legitimate addition breaks, and a corrected false claim about test helpers shipping in production binaries (verified via 'go list -deps' against all four binaries -- they do not; internal/infrastructure/postgres/pgtest, pgstore and internal/taskstate/taskstatetest are only ever imported from _test.go files, so go build never links them). Each child names one concrete site with file:line evidence. This is documentation of candidates, not a fix mandate -- triage on the epic's own terms.

Close reason

Closed on GitHub; syncing bead state


Imported from beads archie-core-gnzh · GitHub #1222 · type epic · priority P2 · created 2026-09-26 · closed 2026-09-26

Scoped audit (2026-09-26, 3 read-only investigator agents) into the test-quality bar CLAUDE.md's Development Protocol states but does not enforce: tests pinned to a literal instead of a named constant, tests asserting an exact enumerated set that any legitimate addition breaks, and a corrected false claim about test helpers shipping in production binaries (verified via 'go list -deps' against all four binaries -- they do not; internal/infrastructure/postgres/pgtest, pgstore and internal/taskstate/taskstatetest are only ever imported from _test.go files, so go build never links them). Each child names one concrete site with file:line evidence. This is documentation of candidates, not a fix mandate -- triage on the epic's own terms. ### Close reason Closed on GitHub; syncing bead state --- _Imported from beads `archie-core-gnzh` · GitHub #1222 · type epic · priority P2 · created 2026-09-26 · closed 2026-09-26_
sam added the mediumepic labels 2026-10-27 13:40:00 +00:00
sam self-assigned this 2026-10-27 13:40:00 +00:00
sam closed this issue 2026-10-27 13:40:01 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1343