feat(workflow): no runtime step-type provider set, so PRD:95 plugin step types are unreachable in a deployment #1334

Closed
opened 2026-10-27 13:39:58 +00:00 by sam · 0 comments
Owner

docs/prds/runtime-control-plane.md:95 says "Plugins can add step types." archie-core-fwmp delivered the mechanism - an injected workflow.Manager owned by internal/domain/workflow, a single provider set in internal/infrastructure/workflowsteps, registration at each composition root, and a cross-side agreement test - but the provider set is a compiled-in constant whose only member is the shipped stages:

func Providers() []workflow.StepTypeProvider { return []workflow.StepTypeProvider{shippedStages{}} }

So a step type can only be added by editing that file and rebuilding every binary that links it; no operator-installed plugin can contribute one. The shape lane and all six of its reviewers recorded this explicitly rather than implying plugin reach, and it matches the memory house instance (also one compiled-in provider), so it was not treated as a defect in that lane.

It is nonetheless the PRD claim left unmet. The plugin engine rule (ARCHITECTURE.md#plugin-engine-rule-strict invariant 4) means a provider receives the typed family registrar and only the host services its capability needs; and this repo's only plugin mechanism is Yaegi interpreted plugins loaded by the daemon (plugin.LoadDir), reachable through pluginextract.Symbols, which cannot hand the host a compiled-in workflow.StepFactory. internal/secret/secretextract is the existing precedent for bridging interpreted func values into a typed engine family (WResolve, loaded via registry.LoadDir), so "no workflow bridge has been built" is the accurate statement rather than "cannot".

Work needed: decide whether a plugin-contributed step type arrives as a build-time provider in a shared package both roots import, or through a Yaegi bridge like secret engines; then wire it and pin that a provider registered through it reaches BOTH the validating side and the executing side (the agreement test in internal/app/controlplane/step_vocabulary_agreement_test.go is the place).

Close reason

Invalidated by re-verification at 13b03dad, not delivered as filed.

The bead's stated cause -- "no runtime step-type provider set, so PRD:95 plugin step types are unreachable" -- is contradicted by the tree:

  • The provider set exists: internal/infrastructure/workflowsteps.Providers() = {shippedStages, repoHooks, eventSteps}. NewManager registers them; three archied roots call stepVocabulary() (RunStateStore at state_store.go, openDaemonWorkflowDefinitions) and agentworker.worker.go builds the same set. The live vocabulary resolves 54 step types: every shipped stage (incl. retired remediate.resume, implement.repo-stages, tdd.repo-stages), gate.diff-rules, agent.run, workflow.call.
  • The design question the bead opened was settled after it was filed: docs/prds/workflow-step-vocabulary.md (2026-09-29) decides a compiled-in, closed vocabulary; a Yaegi -> StepFactory bridge is explicitly rejected (plugin engine rule invariant 6); adding a step type means adding a provider to the shared set. archie-core-m7oc and archie-core-ze7y closed on that.
  • Cross-side agreement is already pinned by internal/app/controlplane/step_vocabulary_agreement_test.go (a probe provider reaches the State Store server, the definitions client read/write paths and agentworker.CompilePinnedWorkflow) and by TestNoProductionSiteReachesForTheBuiltinStepRegistry.

Residue that is real and was split out: the settled PRD named the registered step type as workflow.diff-rules while the runtime word is gate.diff-rules, and docs/prds/runtime-control-plane.md still claimed "Plugins can add step types" against the closed-set decision. That is a docs defect with a guard test, filed separately (P3 docs) and implemented under it.

No Yaegi bridge and no second registry were built; both are rejected by the settled design.


Imported from beads archie-core-gcoj · GitHub #1140 · type feature · priority P2 · created 2026-09-21 · closed 2026-10-02

docs/prds/runtime-control-plane.md:95 says "Plugins can add step types." archie-core-fwmp delivered the mechanism - an injected workflow.Manager owned by internal/domain/workflow, a single provider set in internal/infrastructure/workflowsteps, registration at each composition root, and a cross-side agreement test - but the provider set is a compiled-in constant whose only member is the shipped stages: func Providers() []workflow.StepTypeProvider { return []workflow.StepTypeProvider{shippedStages{}} } So a step type can only be added by editing that file and rebuilding every binary that links it; no operator-installed plugin can contribute one. The shape lane and all six of its reviewers recorded this explicitly rather than implying plugin reach, and it matches the memory house instance (also one compiled-in provider), so it was not treated as a defect in that lane. It is nonetheless the PRD claim left unmet. The plugin engine rule (ARCHITECTURE.md#plugin-engine-rule-strict invariant 4) means a provider receives the typed family registrar and only the host services its capability needs; and this repo's only plugin mechanism is Yaegi interpreted plugins loaded by the daemon (plugin.LoadDir), reachable through pluginextract.Symbols, which cannot hand the host a compiled-in workflow.StepFactory. internal/secret/secretextract is the existing precedent for bridging interpreted func values into a typed engine family (WResolve, loaded via registry.LoadDir), so "no workflow bridge has been built" is the accurate statement rather than "cannot". Work needed: decide whether a plugin-contributed step type arrives as a build-time provider in a shared package both roots import, or through a Yaegi bridge like secret engines; then wire it and pin that a provider registered through it reaches BOTH the validating side and the executing side (the agreement test in internal/app/controlplane/step_vocabulary_agreement_test.go is the place). ### Close reason Invalidated by re-verification at 13b03dad, not delivered as filed. The bead's stated cause -- "no runtime step-type provider set, so PRD:95 plugin step types are unreachable" -- is contradicted by the tree: * The provider set exists: internal/infrastructure/workflowsteps.Providers() = {shippedStages, repoHooks, eventSteps}. NewManager registers them; three archied roots call stepVocabulary() (RunStateStore at state_store.go, openDaemonWorkflowDefinitions) and agentworker.worker.go builds the same set. The live vocabulary resolves 54 step types: every shipped stage (incl. retired remediate.resume, implement.repo-stages, tdd.repo-stages), gate.diff-rules, agent.run, workflow.call. * The design question the bead opened was settled after it was filed: docs/prds/workflow-step-vocabulary.md (2026-09-29) decides a compiled-in, closed vocabulary; a Yaegi -> StepFactory bridge is explicitly rejected (plugin engine rule invariant 6); adding a step type means adding a provider to the shared set. archie-core-m7oc and archie-core-ze7y closed on that. * Cross-side agreement is already pinned by internal/app/controlplane/step_vocabulary_agreement_test.go (a probe provider reaches the State Store server, the definitions client read/write paths and agentworker.CompilePinnedWorkflow) and by TestNoProductionSiteReachesForTheBuiltinStepRegistry. Residue that is real and was split out: the settled PRD named the registered step type as workflow.diff-rules while the runtime word is gate.diff-rules, and docs/prds/runtime-control-plane.md still claimed "Plugins can add step types" against the closed-set decision. That is a docs defect with a guard test, filed separately (P3 docs) and implemented under it. No Yaegi bridge and no second registry were built; both are rejected by the settled design. --- _Imported from beads `archie-core-gcoj` · GitHub #1140 · type feature · priority P2 · created 2026-09-21 · closed 2026-10-02_
sam added the mediumfeature labels 2026-10-27 13:39:58 +00:00
sam self-assigned this 2026-10-27 13:39:58 +00:00
sam closed this issue 2026-10-27 13:39:58 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1334