feat(workflow): let plugins register workflow step types #1323

Closed
opened 2026-10-27 13:39:56 +00:00 by sam · 0 comments
Owner

docs/prds/runtime-control-plane.md ("Workflows") says plugins can add step types. Every
call site hardcodes workflow.BuiltinStepRegistry(): internal/app/agentworker/task_execution.go:319
and :335, internal/app/controlplane/workflow_definitions.go:26 and :33, and
internal/app/controlplane/client.go:41. There is no extension point, so the step vocabulary
is closed to the six shipped workflows.

Note the validating side (the State Store) and the executing side (archie-agent) must agree
on the registry, or a definition that validates will fail to compile at run time.

Scope: a registry assembled from the plugin set, resolved identically on both sides.

Notes

BLOCKED: two review passes (9 angles each) found the seam inert in production and the mechanism creating the very divergence hazard the bead exists to remove; -count=2 fails on the process-global registrar. See the decide(workflow) bead filed for the design question. cp/shape parked unmerged. Do not patch a third time.
REQUEUED 2026-09-21 against settled design, not a new decision. Mechanism is already decided by ARCHITECTURE.md#plugin-engine-rule-strict invariant 2 (the capability package owns a Registry/Manager that controls provider registration and discovery; providers do not register arbitrary callbacks directly on the daemon) plus docs/architecture/plugins-and-extensions.md ('Workflow plugins belong to the Workflow capability family... owns their typed registration'). House instance: internal/domain/memory.Registry + boot.setupMemoryEngine (bootstrap.go:878) registered at the composition root, pinned by composition_order_test.go. The superseded attempt used a package-global register-from-init: no production caller, non-idempotent under -count=2. Also note internal/plugin/architecture_test.go enforces that a new engine interface has domain behavior plus an owning registry or manager.

Close reason

Closed


Imported from beads archie-core-fwmp · GitHub #975 · type feature · priority P2 · created 2026-09-20 · closed 2026-09-21

docs/prds/runtime-control-plane.md ("Workflows") says plugins can add step types. Every call site hardcodes workflow.BuiltinStepRegistry(): internal/app/agentworker/task_execution.go:319 and :335, internal/app/controlplane/workflow_definitions.go:26 and :33, and internal/app/controlplane/client.go:41. There is no extension point, so the step vocabulary is closed to the six shipped workflows. Note the validating side (the State Store) and the executing side (archie-agent) must agree on the registry, or a definition that validates will fail to compile at run time. Scope: a registry assembled from the plugin set, resolved identically on both sides. ### Notes BLOCKED: two review passes (9 angles each) found the seam inert in production and the mechanism creating the very divergence hazard the bead exists to remove; -count=2 fails on the process-global registrar. See the decide(workflow) bead filed for the design question. cp/shape parked unmerged. Do not patch a third time. REQUEUED 2026-09-21 against settled design, not a new decision. Mechanism is already decided by ARCHITECTURE.md#plugin-engine-rule-strict invariant 2 (the capability package owns a Registry/Manager that controls provider registration and discovery; providers do not register arbitrary callbacks directly on the daemon) plus docs/architecture/plugins-and-extensions.md ('Workflow plugins belong to the Workflow capability family... owns their typed registration'). House instance: internal/domain/memory.Registry + boot.setupMemoryEngine (bootstrap.go:878) registered at the composition root, pinned by composition_order_test.go. The superseded attempt used a package-global register-from-init: no production caller, non-idempotent under -count=2. Also note internal/plugin/architecture_test.go enforces that a new engine interface has domain behavior plus an owning registry or manager. ### Close reason Closed --- _Imported from beads `archie-core-fwmp` · GitHub #975 · type feature · priority P2 · created 2026-09-20 · closed 2026-09-21_
sam added the mediumfeature labels 2026-10-27 13:39:56 +00:00
sam self-assigned this 2026-10-27 13:39:56 +00:00
sam closed this issue 2026-10-27 13:39:56 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1323