An existing tool-settings resource can never gain a newly added MCPServer field #1318

Closed
opened 2026-10-27 13:39:54 +00:00 by sam · 0 comments
Owner

Found in archie-core-...#177 (commit a2a26c8d, which carried parallel_tool_calls through the tool-settings projection).

ImportConfig never re-seeds a kind that already exists, so a State Store seeded BEFORE that commit holds a tool-settings value with no parallel_tool_calls key. The resource then replaces cfg.Tools wholesale, so the operator's file-level parallel_tool_calls = true stays inert until the resource itself is rewritten. Absence currently means 'the zero value', not 'inherit the file'.

Fix direction: make absence mean inherit-from-file for newly added optional fields - the shape already used by schedulingPolicy.Label (*string). That is a semantic change across the whole tool-settings projection, so it needs a decision rather than a drive-by edit.

Related UI gap, same cause: ui/src/settings/StructuredValueEditor.vue:103-117 renders only keys already present in the stored value and offers add only for _map/labels/providers/roles, so the dashboard cannot express the new key for such a store (needs an API/resource write). And the new-row sample at :66-70 omits parallel_tool_calls, so a server added in the UI gets no checkbox. Both need a ui/dist rebuild.

Close reason

Already fixed in b7a64016: an absent parallel_tool_calls inherits the file value (*bool). The generic editor the UI half described was removed, and no dedicated control for the key is wanted.


Imported from beads archie-core-fkpe · GitHub #1131 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-10

Found in archie-core-...#177 (commit a2a26c8d, which carried parallel_tool_calls through the tool-settings projection). ImportConfig never re-seeds a kind that already exists, so a State Store seeded BEFORE that commit holds a tool-settings value with no parallel_tool_calls key. The resource then replaces cfg.Tools wholesale, so the operator's file-level parallel_tool_calls = true stays inert until the resource itself is rewritten. Absence currently means 'the zero value', not 'inherit the file'. Fix direction: make absence mean inherit-from-file for newly added optional fields - the shape already used by schedulingPolicy.Label (*string). That is a semantic change across the whole tool-settings projection, so it needs a decision rather than a drive-by edit. Related UI gap, same cause: ui/src/settings/StructuredValueEditor.vue:103-117 renders only keys already present in the stored value and offers add only for _map/labels/providers/roles, so the dashboard cannot express the new key for such a store (needs an API/resource write). And the new-row sample at :66-70 omits parallel_tool_calls, so a server added in the UI gets no checkbox. Both need a ui/dist rebuild. ### Close reason Already fixed in b7a64016: an absent parallel_tool_calls inherits the file value (*bool). The generic editor the UI half described was removed, and no dedicated control for the key is wanted. --- _Imported from beads `archie-core-fkpe` · GitHub #1131 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-10_
sam added the mediumbug labels 2026-10-27 13:39:54 +00:00
sam self-assigned this 2026-10-27 13:39:54 +00:00
sam closed this issue 2026-10-27 13:39:54 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1318