Use generic workflow inputs for chat task spawning #126

Closed
opened 2026-10-27 13:35:03 +00:00 by sam · 0 comments
Owner

Finish the approved operator-trigger correction from afbk.14: task_spawn carries declared workflow inputs, the daemon validates them against the pinned interface, and the bespoke review_pr tool is removed. Preserve identity-scoped repository checks and existing inputs persistence.

Close reason

Shipped in bae53bcb (ancestor of main): the bespoke review_pr/ReviewTools chat tool is deleted (internal/gateway/review_tools.go removed, turn.go no longer appends it); task_spawn declares an inputs object (task_tools.go:250-278) forwarded via SpawnRequest.Inputs through postgres/proto/staterpc; the daemon validates them against the pinned interface in pinTaskProfile -> ParseWorkflowInterface -> iface.CheckInputs (daemon.go:1919-1930), parking ParkNeedsHuman on mismatch. Tests TestTaskSpawn, TestPinTaskProfileRefusesInputsTheWorkflowDoesNotAccept, TestCheckInputs.


Imported from beads archie-core-afbk.15 · GitHub #1426 · type task · priority P1 · created 2026-09-28 · closed 2026-10-02

Finish the approved operator-trigger correction from afbk.14: task_spawn carries declared workflow inputs, the daemon validates them against the pinned interface, and the bespoke review_pr tool is removed. Preserve identity-scoped repository checks and existing inputs persistence. ### Close reason Shipped in bae53bcb (ancestor of main): the bespoke review_pr/ReviewTools chat tool is deleted (internal/gateway/review_tools.go removed, turn.go no longer appends it); task_spawn declares an inputs object (task_tools.go:250-278) forwarded via SpawnRequest.Inputs through postgres/proto/staterpc; the daemon validates them against the pinned interface in pinTaskProfile -> ParseWorkflowInterface -> iface.CheckInputs (daemon.go:1919-1930), parking ParkNeedsHuman on mismatch. Tests TestTaskSpawn, TestPinTaskProfileRefusesInputsTheWorkflowDoesNotAccept, TestCheckInputs. --- _Imported from beads `archie-core-afbk.15` · GitHub #1426 · type task · priority P1 · created 2026-09-28 · closed 2026-10-02_
sam added the hightask labels 2026-10-27 13:35:03 +00:00
sam self-assigned this 2026-10-27 13:35:03 +00:00
sam closed this issue 2026-10-27 13:35:03 +00:00
sam added a new dependency 2026-11-14 14:45:16 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Blocks
Reference: sam/archie#126