telegram: mark a failed turn instead of leaving an indistinguishable partial #1256

Closed
opened 2026-10-27 13:39:39 +00:00 by sam · 0 comments
Owner

Both /stop and a genuine provider error funnel into live.abandon() (telegram.go:573), which trims the buffer, drops the cursor, and leaves the partial text as a permanent message with no failure marker — indistinguishable from a finished reply. /stop at least acks via stopReport; the provider-error branch sends nothing to the user, so a failed turn reads as complete and the user may act on incomplete information. The codebase's own error pattern (the ❌ session-resolution failure message) is unused here.

Failure: the model stream errors (provider 5xx, timeout) after three paragraphs; the bot's last message is the truncated text with no cursor and no error note; the user treats it as the final answer.

Design

On provider error (not /stop), append or prepend an error marker to the abandoned message (e.g. a ❌ … failed line), or send a follow-up error message, so a truncated turn is visibly not the answer.

Acceptance criteria

A provider-error turn leaves a message that visibly signals failure; /stop still leaves a clean partial without a spurious error.

Close reason

Fixed in internal/channels/telegram/live.go: framedText keeps tool lines whole ahead of the clamped answer tail (fixes wpq6); finalText appends a '(no response)' marker when tools ran but the reply is empty (fixes hlxd); abandonFailed marks a provider-error partial distinctly from a clean /stop abandon (fixes c3w2). Regression tests verified red-then-green; adversarial review found no blocking issues (added one more test for the degenerate oversized-tool-block case it flagged). task check clean, committed as 587b9b9.


Imported from beads archie-core-c3w2 · GitHub #492 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14

Both /stop and a genuine provider error funnel into live.abandon() (telegram.go:573), which trims the buffer, drops the cursor, and leaves the partial text as a permanent message with no failure marker — indistinguishable from a finished reply. /stop at least acks via stopReport; the provider-error branch sends nothing to the user, so a failed turn reads as complete and the user may act on incomplete information. The codebase's own error pattern (the ❌ session-resolution failure message) is unused here. Failure: the model stream errors (provider 5xx, timeout) after three paragraphs; the bot's last message is the truncated text with no cursor and no error note; the user treats it as the final answer. ### Design On provider error (not /stop), append or prepend an error marker to the abandoned message (e.g. a ❌ … failed line), or send a follow-up error message, so a truncated turn is visibly not the answer. ### Acceptance criteria A provider-error turn leaves a message that visibly signals failure; /stop still leaves a clean partial without a spurious error. ### Close reason Fixed in internal/channels/telegram/live.go: framedText keeps tool lines whole ahead of the clamped answer tail (fixes wpq6); finalText appends a '(no response)' marker when tools ran but the reply is empty (fixes hlxd); abandonFailed marks a provider-error partial distinctly from a clean /stop abandon (fixes c3w2). Regression tests verified red-then-green; adversarial review found no blocking issues (added one more test for the degenerate oversized-tool-block case it flagged). task check clean, committed as 587b9b9. --- _Imported from beads `archie-core-c3w2` · GitHub #492 · type bug · priority P2 · created 2026-08-14 · closed 2026-08-14_
sam added the mediumbug labels 2026-10-27 13:39:39 +00:00
sam self-assigned this 2026-10-27 13:39:39 +00:00
sam closed this issue 2026-10-27 13:39:39 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1256