Does StageDiffCap count baseline-fix edits toward ChangedLines? #1244

Closed
opened 2026-10-27 13:39:36 +00:00 by sam · 0 comments
Owner

Task 11 parked at 789 changed lines, but its baseline was red first: golangci-lint panicked with 'package requires newer Go version go1.27 (application built with go1.26)', a baseline-fix stage ran, reported changes: 2, and passed. StageDiffCap measures with Trees.ChangedLines(dir, base) after that.

If baseline repairs are inside the measurement, part of a diff-cap park is pre-existing repo breakage rather than the agent's own change, which inverts the remedy: fix the toolchain, do not raise the cap. If they are not, the 789 is genuinely the change and nothing needs doing.

Establish which, and if repairs do count, decide whether the cap should measure only the feature diff (e.g. measure from the post-baseline-fix commit rather than the base branch).

Close reason

Closed


Imported from beads archie-core-bh05 · GitHub #921 · type task · priority P2 · created 2026-09-19 · closed 2026-10-03

Task 11 parked at 789 changed lines, but its baseline was red first: golangci-lint panicked with 'package requires newer Go version go1.27 (application built with go1.26)', a baseline-fix stage ran, reported changes: 2, and passed. StageDiffCap measures with Trees.ChangedLines(dir, base) after that. If baseline repairs are inside the measurement, part of a diff-cap park is pre-existing repo breakage rather than the agent's own change, which inverts the remedy: fix the toolchain, do not raise the cap. If they are not, the 789 is genuinely the change and nothing needs doing. Establish which, and if repairs do count, decide whether the cap should measure only the feature diff (e.g. measure from the post-baseline-fix commit rather than the base branch). ### Close reason Closed --- _Imported from beads `archie-core-bh05` · GitHub #921 · type task · priority P2 · created 2026-09-19 · closed 2026-10-03_
sam added the mediumtask labels 2026-10-27 13:39:36 +00:00
sam self-assigned this 2026-10-27 13:39:36 +00:00
sam closed this issue 2026-10-27 13:39:36 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1244