[EPIC] Backend-owned configuration schema for the webui Configuration page #1233

Closed
opened 2026-10-27 13:39:33 +00:00 by sam · 0 comments
Owner

The Configuration page's field definitions (label, section, type, editability, restart-required, options) are hand-maintained in ui/src/settings/settings.js and config-row.js, disjoint from the backend's own ConfigView allowlist in internal/webui/api_config.go. Adding or changing a runtime-tunable setting today means editing Go and JS in two unrelated places by hand, and nothing catches drift between them. Repo.ReviewEnabled is missing from the API entirely; AllowConcurrent and MaxRetries reach the API but the repositories card never renders them, which is what blocked Sam from discovering the allow_concurrent fix without an agent tracing the Go source directly.

Design: docs/prds/config-schema.md. The backend keeps its existing hand-picked, secret-free allowlist (ConfigView in api_config.go) -- config.Config is scheduled for dissolution per its own package doc, so this is deliberately NOT a reflection-based schema over config.Config. Instead each already-allowlisted field gains a hand-authored descriptor (label, section, type, editable, restart_required, options) alongside its existing value, and the frontend renders scalar/bool/int/enum/duration fields generically from that descriptor instead of hardcoding rows. Structured fields (repositories, maps) get dedicated typed editors rather than staying silently read-only.

Close reason

All six child issues shipped: hand-authored field descriptor catalog (.1), schema attached to GET /api/config (.2), generic scalar renderer replacing hardcoded settings.js rows (.3), repository field visibility incl. the previously-API-absent ReviewEnabled (.4), schema contract tests pinning restart-required deliberateness and generic-render proof (.5), and inline editing for the three per-repo fields via a dedicated PATCH /api/config/repos/{owner}/{name} seam (.6). The concrete complaint that started this (allow_concurrent invisible on the dashboard) is fully resolved: visible, editable, and backed by a schema the frontend no longer hardcodes.


Imported from beads archie-core-b6ew · GitHub #696 · type epic · priority P2 · created 2026-09-02 · closed 2026-09-02

The Configuration page's field definitions (label, section, type, editability, restart-required, options) are hand-maintained in ui/src/settings/settings.js and config-row.js, disjoint from the backend's own ConfigView allowlist in internal/webui/api_config.go. Adding or changing a runtime-tunable setting today means editing Go and JS in two unrelated places by hand, and nothing catches drift between them. Repo.ReviewEnabled is missing from the API entirely; AllowConcurrent and MaxRetries reach the API but the repositories card never renders them, which is what blocked Sam from discovering the allow_concurrent fix without an agent tracing the Go source directly. Design: docs/prds/config-schema.md. The backend keeps its existing hand-picked, secret-free allowlist (ConfigView in api_config.go) -- config.Config is scheduled for dissolution per its own package doc, so this is deliberately NOT a reflection-based schema over config.Config. Instead each already-allowlisted field gains a hand-authored descriptor (label, section, type, editable, restart_required, options) alongside its existing value, and the frontend renders scalar/bool/int/enum/duration fields generically from that descriptor instead of hardcoding rows. Structured fields (repositories, maps) get dedicated typed editors rather than staying silently read-only. ### Close reason All six child issues shipped: hand-authored field descriptor catalog (.1), schema attached to GET /api/config (.2), generic scalar renderer replacing hardcoded settings.js rows (.3), repository field visibility incl. the previously-API-absent ReviewEnabled (.4), schema contract tests pinning restart-required deliberateness and generic-render proof (.5), and inline editing for the three per-repo fields via a dedicated PATCH /api/config/repos/{owner}/{name} seam (.6). The concrete complaint that started this (allow_concurrent invisible on the dashboard) is fully resolved: visible, editable, and backed by a schema the frontend no longer hardcodes. --- _Imported from beads `archie-core-b6ew` · GitHub #696 · type epic · priority P2 · created 2026-09-02 · closed 2026-09-02_
sam added the mediumepic labels 2026-10-27 13:39:33 +00:00
sam self-assigned this 2026-10-27 13:39:33 +00:00
sam closed this issue 2026-10-27 13:39:33 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1233