liveReply fallback lines appended after finalize are never rendered #1226

Closed
opened 2026-10-27 13:39:32 +00:00 by sam · 0 comments
Owner

A media delivery that fails AFTER doFinalize has run appends its fallback line to l.toolLines and calls requestRender(), but stopRendering() has already closed renderDone and the renderer goroutine has exited. requestRender is a non-blocking send into a cap-1 channel with no consumer, so the line is dropped and the finalized Telegram message stands unchanged.

Media is fire-and-forget with a 30s budget while the turn's text finishes far earlier, so this is the NORMAL case for a large upload: a 40MB document that 400s or times out reports 'could not send x' into a slice nothing reads. Pre-dates the local-file work (URL fallbacks have the same hole) but archie-core-absb's guarantee that non-delivery is always visible depends on it.

Found by adversarial review of 9a45fbb. internal/channels/telegram/live.go:419-437 with :498-532.

Acceptance Criteria

A media failure occurring after the live reply has finalized still reaches the user -- e.g. as its own follow-up message rather than an edit to a message nothing re-renders. Covered by a test that finalizes first and fails the send second.

Close reason

Fixed: stopRendering now marks the reply finalized, and appendFallbackLine sends a standalone follow-up message instead of writing into a dead render buffer. Covered by TestLiveReplyMediaFallbackAfterFinalizeSendsFollowUp.


Imported from beads archie-core-atv2 · GitHub #646 · type bug · priority P2 · created 2026-08-24 · closed 2026-09-01

A media delivery that fails AFTER doFinalize has run appends its fallback line to l.toolLines and calls requestRender(), but stopRendering() has already closed renderDone and the renderer goroutine has exited. requestRender is a non-blocking send into a cap-1 channel with no consumer, so the line is dropped and the finalized Telegram message stands unchanged. Media is fire-and-forget with a 30s budget while the turn's text finishes far earlier, so this is the NORMAL case for a large upload: a 40MB document that 400s or times out reports 'could not send x' into a slice nothing reads. Pre-dates the local-file work (URL fallbacks have the same hole) but archie-core-absb's guarantee that non-delivery is always visible depends on it. Found by adversarial review of 9a45fbb. internal/channels/telegram/live.go:419-437 with :498-532. ## Acceptance Criteria A media failure occurring after the live reply has finalized still reaches the user -- e.g. as its own follow-up message rather than an edit to a message nothing re-renders. Covered by a test that finalizes first and fails the send second. ### Close reason Fixed: stopRendering now marks the reply finalized, and appendFallbackLine sends a standalone follow-up message instead of writing into a dead render buffer. Covered by TestLiveReplyMediaFallbackAfterFinalizeSendsFollowUp. --- _Imported from beads `archie-core-atv2` · GitHub #646 · type bug · priority P2 · created 2026-08-24 · closed 2026-09-01_
sam added the mediumbug labels 2026-10-27 13:39:32 +00:00
sam self-assigned this 2026-10-27 13:39:32 +00:00
sam closed this issue 2026-10-27 13:39:32 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1226