Kit launch skips published descriptor validation #1213

Closed
opened 2026-10-27 13:39:28 +00:00 by sam · 0 comments
Owner

kit.DecodePublished (strict decode, ValidatePublished, no unexpanded build args) has no caller. The kit launcher resolves through fetch and kit.FromResolved, so a descriptor that the published form rejects is admitted. Plan: call the published check on the launch path (inside FromResolved, or at the resolve call site), with a table test covering a valid descriptor and one with an unexpanded build arg. Done when the test fails before the change and task deadcode stops listing DecodePublished.

Close reason

Stale. kit.DecodePublished was deleted in 02691af0. The resolver (sandbox-kit-spec v3.0.0-m.8, go.mod) runs spec.ValidatePublished on every fetched Kit: fetch/registry.go:80 and fetch/fetch.go:486, reached via Launcher.Fetch.Resolve (kitrun/launcher.go:411). Nothing bypasses it; no change needed.


Imported from beads archie-core-a1dmd · GitHub #1722 · type bug · priority P2 · created 2026-10-14 · closed 2026-10-27

kit.DecodePublished (strict decode, ValidatePublished, no unexpanded build args) has no caller. The kit launcher resolves through fetch and kit.FromResolved, so a descriptor that the published form rejects is admitted. Plan: call the published check on the launch path (inside FromResolved, or at the resolve call site), with a table test covering a valid descriptor and one with an unexpanded build arg. Done when the test fails before the change and task deadcode stops listing DecodePublished. ### Close reason Stale. kit.DecodePublished was deleted in 02691af0. The resolver (sandbox-kit-spec v3.0.0-m.8, go.mod) runs spec.ValidatePublished on every fetched Kit: fetch/registry.go:80 and fetch/fetch.go:486, reached via Launcher.Fetch.Resolve (kitrun/launcher.go:411). Nothing bypasses it; no change needed. --- _Imported from beads `archie-core-a1dmd` · GitHub #1722 · type bug · priority P2 · created 2026-10-14 · closed 2026-10-27_
sam added the mediumbug labels 2026-10-27 13:39:28 +00:00
sam self-assigned this 2026-10-27 13:39:28 +00:00
sam closed this issue 2026-10-27 13:39:28 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1213