chore(config): follow-ups from the control-plane validation split #1200

Closed
opened 2026-10-27 13:39:25 +00:00 by sam · 0 comments
Owner

Recorded by the cp/config lane as debt it deliberately did not widen, after the split that moved database-owned checks off the file load path (52065154) and the two follow-up fixes (bffd489a, 56b1c0fd). None are regressions from that branch except where noted; each needs its own look.

  1. Identity-repos classification: which repository checks belong to identity versus repository policy is still unresolved after the split.
  2. cfg.Label: unjudged by either layer (carried from the first review pass).
  3. Test-only ApplyOverlay with a stale doc claim on internal/infrastructure/configuration/apply.go.
  4. TestValidate_RejectsTheSameProblemsAsLoaderLoad: its name and its body disagree.
  5. Consumers that lost load-time rejections when the checks moved to the resource validator - confirm each has an equivalent failure at the point of use rather than failing later.
  6. A structural drift test tying each control-plane definition's seeded fields to its validator, so a new seeded field cannot be added without a check (the class that produced the duplicate-repo divergence).
  7. conf.d/*.yaml extras in an overlay directory are still stored whole via decodeExtra (decode.go:128-136) with no layer and no fold; harmless while nothing reads cfg.Extra (no production reader today), latent the moment something does. apply.go's doc was corrected to say so.

Close reason

Integrated on main (d0jp, units/readiness); 8weq items already resolved


Imported from beads archie-core-8weq · GitHub #1142 · type chore · priority P2 · created 2026-09-21 · closed 2026-10-17

Recorded by the cp/config lane as debt it deliberately did not widen, after the split that moved database-owned checks off the file load path (52065154) and the two follow-up fixes (bffd489a, 56b1c0fd). None are regressions from that branch except where noted; each needs its own look. 1. Identity-repos classification: which repository checks belong to identity versus repository policy is still unresolved after the split. 2. cfg.Label: unjudged by either layer (carried from the first review pass). 3. Test-only ApplyOverlay with a stale doc claim on internal/infrastructure/configuration/apply.go. 4. TestValidate_RejectsTheSameProblemsAsLoaderLoad: its name and its body disagree. 5. Consumers that lost load-time rejections when the checks moved to the resource validator - confirm each has an equivalent failure at the point of use rather than failing later. 6. A structural drift test tying each control-plane definition's seeded fields to its validator, so a new seeded field cannot be added without a check (the class that produced the duplicate-repo divergence). 7. conf.d/*.yaml extras in an overlay directory are still stored whole via decodeExtra (decode.go:128-136) with no layer and no fold; harmless while nothing reads cfg.Extra (no production reader today), latent the moment something does. apply.go's doc was corrected to say so. ### Close reason Integrated on main (d0jp, units/readiness); 8weq items already resolved --- _Imported from beads `archie-core-8weq` · GitHub #1142 · type chore · priority P2 · created 2026-09-21 · closed 2026-10-17_
sam added the mediumchore labels 2026-10-27 13:39:25 +00:00
sam self-assigned this 2026-10-27 13:39:25 +00:00
sam closed this issue 2026-10-27 13:39:25 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1200