Harness setup terminal: no resize path, the PTY is fixed at 24x80 for the session #1198
Notifications
Due Date
No due date set.
Depends on
Reference: sam/archie#1198
Reference in new issue
Block a user
What is wrong
A setup session's PTY is created at a fixed 24 rows x 80 columns and can never change.
container.ExecPTY(..., []string{"sh", "-l"}, 24, 80) with literals.
ExecCreate, but exposes no resize method and never calls ExecResize.
targetandstdin.There is no size frame, although the service comment says later frames
"carry terminal input and sizing".
resize the remote session, so the browser's real size never leaves the client.
Impact
The only delivered UX is a terminal that believes it is 80x24. Long lines wrap
early, and any full-screen programme the login flow starts (a provider's TUI
login, an editor, less/man) renders into the wrong geometry for the whole
session. A wide desktop gives no more width than a phone.
Done when
A resize frame reaches the daemon and is applied with ExecResize, and the
initial size is the client's rather than a literal.
Acceptance criteria
a terminal resize reaches the container (ExecResize, or a size field on the session contract) so a wide or tall terminal is usable.
Notes
Step 1 landed in
b395c170: proto OpenRequest now carries ConsoleSize with the target frame, the route reads cols/rows from the WebSocket URL (falling back to 24x80 when absent or out of range), and harnesssession creates the PTY at that geometry. SetupTerminal.vue sends the size it measured before connecting. The acceptance's "or a size field on the session contract" is met and the initial size is the client's, not a literal. Remaining for the done-when's ExecResize half: PTY.Resize -> ExecResize, psender, and a WebSocket control channel (text frames = control, binary = data), because bridgeTerminal is today a raw io.Copy on both sides.Close reason
Verified: fixed in code or doc/file no longer exists (see burndown 2026-10-13)
Imported from beads
archie-core-8v9b· GitHub #1550 · type bug · priority P2 · created 2026-10-08 · closed 2026-10-12