ReviewCommentEnvelope with a kinded idempotency key #1172

Closed
opened 2026-10-27 13:39:18 +00:00 by sam · 0 comments
Owner

workintake.ReviewCommentEnvelope{Owner, Repo, PRNumber, Kind, CommentID,
ReviewID, Author, State, Body, Path, Line} with a source-independent
idempotency key, so a webhook delivery and a poll of the same comment collapse
via PublishUnique.

Step 3 of docs/prds/pr-review-remediation.md.

Key is owner/repo/pr-number/kind/id. Kind (review | comment) is load-bearing:
a review ID and a review-comment ID come from independent forge sequences, so
keying on the bare id lets a review and an inline comment on one PR collide
and silently drop one.

PR #859 has a usable envelope shape to start from, minus the key. It is closed
unmerged; take the shape, not the wiring.

Acceptance: table-driven round trip; a review and a comment on one PR with
numerically equal ids produce different keys.

Close reason

Closed


Imported from beads archie-core-8li9.3 · GitHub #912 · type feature · priority P1 · created 2026-09-18 · closed 2026-09-18

workintake.ReviewCommentEnvelope{Owner, Repo, PRNumber, Kind, CommentID, ReviewID, Author, State, Body, Path, Line} with a source-independent idempotency key, so a webhook delivery and a poll of the same comment collapse via PublishUnique. Step 3 of docs/prds/pr-review-remediation.md. Key is owner/repo/pr-number/kind/id. Kind (review | comment) is load-bearing: a review ID and a review-comment ID come from independent forge sequences, so keying on the bare id lets a review and an inline comment on one PR collide and silently drop one. PR #859 has a usable envelope shape to start from, minus the key. It is closed unmerged; take the shape, not the wiring. Acceptance: table-driven round trip; a review and a comment on one PR with numerically equal ids produce different keys. ### Close reason Closed --- _Imported from beads `archie-core-8li9.3` · GitHub #912 · type feature · priority P1 · created 2026-09-18 · closed 2026-09-18_
sam added the highfeature labels 2026-10-27 13:39:18 +00:00
sam self-assigned this 2026-10-27 13:39:18 +00:00
sam closed this issue 2026-10-27 13:39:18 +00:00
sam added a new dependency 2026-10-27 13:42:19 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1172