Add Messaging Service architecture deletion gate and end-to-end smoke verification #1160

Closed
opened 2026-10-27 13:39:16 +00:00 by sam · 0 comments
Owner

Enforce architecture deletion gate (cmd/archie-messaging/architecture_test.go) asserting zero banned runtime packages linked into archie-messaging, and add end-to-end integration tests.

Close reason

Both halves are done.

The architecture deletion gate landed in a7d6cc8c: cmd/archie-messaging/architecture_test.go measures go list -deps ./cmd/archie-messaging against the PRD's banned list, with internal/domain/workflow/task excepted in both directions (verified contract-only: its own dependency set holds none of the banned runtimes, and the UI gate carries the same entry).

The end-to-end smoke verification landed in fa1840e6: internal/app/archiemessaging/smoke_test.go drives the deployed path -- real composition, real webhook adapter, real listener, real signed HTTP request -- and asserts on the envelope that crossed the chat contract (templated text, user role, route as the conversation, platform "webhook", empty SenderID, route as the budget key) as well as on the reply that came back through DeliverTo=origin.

Webhook is the equivalent of the PRD's "live Telegram round trip": Telegram needs a bot token and the Telegram API, email needs SMTP, so no test can own either, and every step between the POST and the contract is the deployed code path. The gRPC hop beyond the contract is covered by internal/infrastructure/gatewayrpc's conformance tests, which run the same client and server in both local and remote mode.

Red-proofed in both directions, so no part of this is decorative: banning internal/channels fails the gate; removing the workflow/task exception fails the gate; signing the smoke request with the wrong secret fails the smoke test with "status = 401, want 200".

Verified: task check exit 0 on fa1840e6.


Imported from beads archie-core-8cda.6.5 · GitHub #949 · type task · priority P3 · created 2026-09-19 · closed 2026-09-21

Enforce architecture deletion gate (cmd/archie-messaging/architecture_test.go) asserting zero banned runtime packages linked into archie-messaging, and add end-to-end integration tests. ### Close reason Both halves are done. The architecture deletion gate landed in a7d6cc8c: cmd/archie-messaging/architecture_test.go measures go list -deps ./cmd/archie-messaging against the PRD's banned list, with internal/domain/workflow/task excepted in both directions (verified contract-only: its own dependency set holds none of the banned runtimes, and the UI gate carries the same entry). The end-to-end smoke verification landed in fa1840e6: internal/app/archiemessaging/smoke_test.go drives the deployed path -- real composition, real webhook adapter, real listener, real signed HTTP request -- and asserts on the envelope that crossed the chat contract (templated text, user role, route as the conversation, platform "webhook", empty SenderID, route as the budget key) as well as on the reply that came back through DeliverTo=origin. Webhook is the equivalent of the PRD's "live Telegram round trip": Telegram needs a bot token and the Telegram API, email needs SMTP, so no test can own either, and every step between the POST and the contract is the deployed code path. The gRPC hop beyond the contract is covered by internal/infrastructure/gatewayrpc's conformance tests, which run the same client and server in both local and remote mode. Red-proofed in both directions, so no part of this is decorative: banning internal/channels fails the gate; removing the workflow/task exception fails the gate; signing the smoke request with the wrong secret fails the smoke test with "status = 401, want 200". Verified: task check exit 0 on fa1840e6. --- _Imported from beads `archie-core-8cda.6.5` · GitHub #949 · type task · priority P3 · created 2026-09-19 · closed 2026-09-21_
sam added the lowtask labels 2026-10-27 13:39:16 +00:00
sam self-assigned this 2026-10-27 13:39:16 +00:00
sam closed this issue 2026-10-27 13:39:16 +00:00
sam added a new dependency 2026-10-27 13:42:18 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Reference: sam/archie#1160