fix(archied): the live settings apply publishes without republishing the config snapshot #1117

Closed
opened 2026-10-27 13:39:05 +00:00 by sam · 0 comments
Owner

Found by the archie-core-nwa0 review (P2, consumers/invariant angle).

internal/app/archied/control_plane.go publishes a live workflow-execution-settings update with b.cfgHolder.Set directly, while bootstrap.go's publishConfig documents the invariant it breaks: "Every path that changes configuration goes through here, so the running config and the published page can never diverge." publishConfig sets the Holder AND republishes the dashboard projection (publishConfigSnapshot); only control_plane.go (reload) and main.go call it.

Consequence: after a live budget change, the dashboard's configuration page keeps rendering the pre-update budgets (webui/api_config.go renders the Budgets view from the published snapshot) until a SIGHUP reload or restart, while the daemon is already running the new limits.

Fix direction: promote the live candidate through publishConfig (with the bounded detached context publishConfigSnapshot already uses), so the one writer stays the one writer. Keep it out of the build-and-probe step itself if that reads better.

Not in scope: the build-and-probe step (landed in nwa0) and the watch-reconnect defect (archie-core-yrmr).

Close reason

Fixed in 8d6c3e3c


Imported from beads archie-core-75cc · GitHub #1148 · type bug · priority P2 · created 2026-09-21 · closed 2026-09-26

Found by the archie-core-nwa0 review (P2, consumers/invariant angle). internal/app/archied/control_plane.go publishes a live workflow-execution-settings update with b.cfgHolder.Set directly, while bootstrap.go's publishConfig documents the invariant it breaks: "Every path that changes configuration goes through here, so the running config and the published page can never diverge." publishConfig sets the Holder AND republishes the dashboard projection (publishConfigSnapshot); only control_plane.go (reload) and main.go call it. Consequence: after a live budget change, the dashboard's configuration page keeps rendering the pre-update budgets (webui/api_config.go renders the Budgets view from the published snapshot) until a SIGHUP reload or restart, while the daemon is already running the new limits. Fix direction: promote the live candidate through publishConfig (with the bounded detached context publishConfigSnapshot already uses), so the one writer stays the one writer. Keep it out of the build-and-probe step itself if that reads better. Not in scope: the build-and-probe step (landed in nwa0) and the watch-reconnect defect (archie-core-yrmr). ### Close reason Fixed in 8d6c3e3c --- _Imported from beads `archie-core-75cc` · GitHub #1148 · type bug · priority P2 · created 2026-09-21 · closed 2026-09-26_
sam added the mediumbug labels 2026-10-27 13:39:05 +00:00
sam self-assigned this 2026-10-27 13:39:05 +00:00
sam closed this issue 2026-10-27 13:39:05 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1117