Audit UI Service migration criteria and deletion gates #1107

Closed
opened 2026-10-27 13:39:02 +00:00 by sam · 2 comments
Owner

Compare service-decomposition.md, migration-decisions.md, current UI implementation/tests, and the State Store ratification pattern; write a complete current-to-target checklist with compatibility, cutover, rollback evidence, unresolved questions, and exact documentation changes in .crew/reports/migration-criteria.md. Read-only code audit except for the requested report.

Close reason

Superseded. The requested audit report was delivered (.crew/reports/migration-criteria.md, 2026-09-07) and every finding in it has since been answered or overtaken: docs/prds/ui-service-boundary.md ratified the boundary (2026-09-07), the update-watchdog blocking comment is fixed at telegram_setup.go:241 (cfg.Health.URL(), the daemon's own endpoint), the deletion gate is enforced in cmd/archie-ui/architecture_test.go on every task check, and Phase 3 (archie-core-8cda.5) closed 2026-09-11. Doc reconciliation applied in a5da51a. Residual daemon-side webui.Server Cfg residue stays open and correctly prioritised as archie-core-ml30 (P2). Dropped from P1: no outstanding P1 action remained.


Imported from beads archie-core-6pg1 · GitHub #778 · type task · priority P1 · created 2026-09-07 · closed 2026-09-11

Compare service-decomposition.md, migration-decisions.md, current UI implementation/tests, and the State Store ratification pattern; write a complete current-to-target checklist with compatibility, cutover, rollback evidence, unresolved questions, and exact documentation changes in .crew/reports/migration-criteria.md. Read-only code audit except for the requested report. ### Close reason Superseded. The requested audit report was delivered (.crew/reports/migration-criteria.md, 2026-09-07) and every finding in it has since been answered or overtaken: docs/prds/ui-service-boundary.md ratified the boundary (2026-09-07), the update-watchdog blocking comment is fixed at telegram_setup.go:241 (cfg.Health.URL(), the daemon's own endpoint), the deletion gate is enforced in cmd/archie-ui/architecture_test.go on every task check, and Phase 3 (archie-core-8cda.5) closed 2026-09-11. Doc reconciliation applied in a5da51a. Residual daemon-side webui.Server Cfg residue stays open and correctly prioritised as archie-core-ml30 (P2). Dropped from P1: no outstanding P1 action remained. --- _Imported from beads `archie-core-6pg1` · GitHub #778 · type task · priority P1 · created 2026-09-07 · closed 2026-09-11_
sam added the hightask labels 2026-10-27 13:39:02 +00:00
sam self-assigned this 2026-10-27 13:39:03 +00:00
sam closed this issue 2026-10-27 13:39:03 +00:00
Author
Owner

sam wrote (originally 2026-09-09):

Phase 3 constraint from archie-core-1r4g: the update watchdog probes webui.HealthURL([web].listen) to decide whether archied's restart succeeded. Once the dashboard moves to archie-ui, that address stops belonging to archied, and the probe would report health for a process it never restarted -- a rolled-back-or-not decision made on the wrong evidence. Whatever serves the daemon's own /healthz after the split has to be what internal/app/archied/telegram_setup.go derives the installer's HealthURL from.

_sam wrote (originally 2026-09-09):_ Phase 3 constraint from archie-core-1r4g: the update watchdog probes webui.HealthURL([web].listen) to decide whether archied's restart succeeded. Once the dashboard moves to archie-ui, that address stops belonging to archied, and the probe would report health for a process it never restarted -- a rolled-back-or-not decision made on the wrong evidence. Whatever serves the daemon's own /healthz after the split has to be what internal/app/archied/telegram_setup.go derives the installer's HealthURL from.
Author
Owner

sam wrote (originally 2026-09-11):

SUPERSEDED (2026-09-11), closing.

Requested deliverable was produced: .crew/reports/migration-criteria.md (2026-09-07, audit at d687f05). Its executive finding -- 'UI Service extraction is not yet ratifiable' -- and all ten unresolved questions have since been answered:

  • Q1 contract boundary / Q2 retained routes / Q7 process-local handles -> docs/prds/ui-service-boundary.md (ratified 2026-09-07), which is the authority this audit asked to be written (item 1; it landed under that filename rather than ui-service-contract.md).
  • Q3 configuration writes -> read-only in the UI process for Phase 3; writes answer 503 (archie-core-ymut).
  • Q4 live events and logs -> State Store EventsSince cursor polling (migration-decisions.md 'Dashboard live event delivery', archie-core-za9f).
  • Q5 authorization -> UI Service deployment/auth/operations profiles landed (docs/architecture, deployments/README.md, INSTRUCTIONS.md, systemd-user-service.md).
  • Q6 compatibility/listener strategy -> no dual authority; the cutover removed the in-process listener in the same change.
  • Q8 session continuity -> Gateway session storage stays authoritative.
  • Q9 discovery -> explicit configured targets.
  • Q10 stale docs -> internal/config/services.go corrected (7a6f4e4).

Requested doc changes: items 2/3/5 landed; item 1 landed as ui-service-boundary.md; item 4's substance is covered by migration-decisions.md's RATIFIED UI Service entry, which the Architecture Decision Index already lists (01-project-management.md indexes docs/architecture/*, not PRDs); item 6 was conditioned on the contract landing and is optional by its own wording.

Blocking comment (the update watchdog probing [web].listen): fixed. telegram_setup.go:241 now derives HealthURL from cfg.Health.URL(), the daemon's own health endpoint, not the dashboard address.

The two things that outlived the phase are tracked separately: the daemon-side webui.Server Cfg residue (archie-core-ml30, P2, daemon-internal) and the phase itself (archie-core-8cda.5, closed 2026-09-11 with the deletion gate enforced on every task check).

Reconciliation applied in a5da51a: docs/prds/service-decomposition.md no longer reads as though UI extraction were pending (progress line, closed coupling record, resolved-questions heading, corrected State Store local-default claim), and the audit report carries a superseded banner.

_sam wrote (originally 2026-09-11):_ SUPERSEDED (2026-09-11), closing. Requested deliverable was produced: .crew/reports/migration-criteria.md (2026-09-07, audit at d687f05). Its executive finding -- 'UI Service extraction is not yet ratifiable' -- and all ten unresolved questions have since been answered: - Q1 contract boundary / Q2 retained routes / Q7 process-local handles -> docs/prds/ui-service-boundary.md (ratified 2026-09-07), which is the authority this audit asked to be written (item 1; it landed under that filename rather than ui-service-contract.md). - Q3 configuration writes -> read-only in the UI process for Phase 3; writes answer 503 (archie-core-ymut). - Q4 live events and logs -> State Store EventsSince cursor polling (migration-decisions.md 'Dashboard live event delivery', archie-core-za9f). - Q5 authorization -> UI Service deployment/auth/operations profiles landed (docs/architecture, deployments/README.md, INSTRUCTIONS.md, systemd-user-service.md). - Q6 compatibility/listener strategy -> no dual authority; the cutover removed the in-process listener in the same change. - Q8 session continuity -> Gateway session storage stays authoritative. - Q9 discovery -> explicit configured targets. - Q10 stale docs -> internal/config/services.go corrected (7a6f4e4). Requested doc changes: items 2/3/5 landed; item 1 landed as ui-service-boundary.md; item 4's substance is covered by migration-decisions.md's RATIFIED UI Service entry, which the Architecture Decision Index already lists (01-project-management.md indexes docs/architecture/*, not PRDs); item 6 was conditioned on the contract landing and is optional by its own wording. Blocking comment (the update watchdog probing [web].listen): fixed. telegram_setup.go:241 now derives HealthURL from cfg.Health.URL(), the daemon's own health endpoint, not the dashboard address. The two things that outlived the phase are tracked separately: the daemon-side webui.Server Cfg residue (archie-core-ml30, P2, daemon-internal) and the phase itself (archie-core-8cda.5, closed 2026-09-11 with the deletion gate enforced on every task check). Reconciliation applied in a5da51a: docs/prds/service-decomposition.md no longer reads as though UI extraction were pending (progress line, closed coupling record, resolved-questions heading, corrected State Store local-default claim), and the audit report carries a superseded banner.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1107