Found while fixing archie-core-wwho (commit 0398ca60, which made task fmt run go fix to a fixpoint).
Taskfile.yml's fmt task now loops go fix until go fix -diff proves a plateau, because a single pass emits what copyloopvar rejects (stditerators inserts the redundant loop-variable copy and forvar removes it on the NEXT pass). .github/workflows/deploy.yml:84-90 holds a second, inline copy of the gate that still runs a SINGLE go fix ./... and then git diff --exit-code, so the identical hazard survives in CI - surfaced there as a spurious git-diff failure rather than a copyloopvar error, because CI checks the tree is clean instead of running the linter after it.
Fix direction: have the workflow call task fmt (or task check) rather than inlining its own formatter sequence, so there is one owner of the formatter invocation - which is also what deployment_contract_test.go's 'one configured writer' invariant is about. Risk-routed: CI/release surface.
Close reason
Fixed in ba37e37e. The deploy workflow's inline 'go fix ./... && golangci-lint fmt' sequence (which ran a single pass and then asserted git diff --exit-code, so the hazard surfaced as a spurious clean-tree failure rather than a lint error) is replaced by task fmt, the one owner of the formatter sequence; the job now installs the pinned Task (v3.48.0, matching quality.yml) to do it. TestDeployWorkflowUsesConfiguredFormatters was updated to require task fmt and to reject an inline go fix or golangci-lint fmt command, so the split cannot return. Mutation-checked: restoring the inline sequence fails the guard naming both lines.
Imported from beads archie-core-6kda · GitHub #1133 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02
Found while fixing archie-core-wwho (commit 0398ca60, which made task fmt run go fix to a fixpoint).
Taskfile.yml's fmt task now loops go fix until go fix -diff proves a plateau, because a single pass emits what copyloopvar rejects (stditerators inserts the redundant loop-variable copy and forvar removes it on the NEXT pass). .github/workflows/deploy.yml:84-90 holds a second, inline copy of the gate that still runs a SINGLE go fix ./... and then git diff --exit-code, so the identical hazard survives in CI - surfaced there as a spurious git-diff failure rather than a copyloopvar error, because CI checks the tree is clean instead of running the linter after it.
Fix direction: have the workflow call task fmt (or task check) rather than inlining its own formatter sequence, so there is one owner of the formatter invocation - which is also what deployment_contract_test.go's 'one configured writer' invariant is about. Risk-routed: CI/release surface.
### Close reason
Fixed in ba37e37e. The deploy workflow's inline 'go fix ./... && golangci-lint fmt' sequence (which ran a single pass and then asserted git diff --exit-code, so the hazard surfaced as a spurious clean-tree failure rather than a lint error) is replaced by task fmt, the one owner of the formatter sequence; the job now installs the pinned Task (v3.48.0, matching quality.yml) to do it. TestDeployWorkflowUsesConfiguredFormatters was updated to require task fmt and to reject an inline go fix or golangci-lint fmt command, so the split cannot return. Mutation-checked: restoring the inline sequence fails the guard naming both lines.
---
_Imported from beads `archie-core-6kda` · GitHub #1133 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02_
sam
added the mediumbug labels 2026-10-27 13:39:02 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found while fixing archie-core-wwho (commit 0398ca60, which made task fmt run go fix to a fixpoint).
Taskfile.yml's fmt task now loops go fix until go fix -diff proves a plateau, because a single pass emits what copyloopvar rejects (stditerators inserts the redundant loop-variable copy and forvar removes it on the NEXT pass). .github/workflows/deploy.yml:84-90 holds a second, inline copy of the gate that still runs a SINGLE go fix ./... and then git diff --exit-code, so the identical hazard survives in CI - surfaced there as a spurious git-diff failure rather than a copyloopvar error, because CI checks the tree is clean instead of running the linter after it.
Fix direction: have the workflow call task fmt (or task check) rather than inlining its own formatter sequence, so there is one owner of the formatter invocation - which is also what deployment_contract_test.go's 'one configured writer' invariant is about. Risk-routed: CI/release surface.
Close reason
Fixed in
ba37e37e. The deploy workflow's inline 'go fix ./... && golangci-lint fmt' sequence (which ran a single pass and then asserted git diff --exit-code, so the hazard surfaced as a spurious clean-tree failure rather than a lint error) is replaced by task fmt, the one owner of the formatter sequence; the job now installs the pinned Task (v3.48.0, matching quality.yml) to do it. TestDeployWorkflowUsesConfiguredFormatters was updated to require task fmt and to reject an inline go fix or golangci-lint fmt command, so the split cannot return. Mutation-checked: restoring the inline sequence fails the guard naming both lines.Imported from beads
archie-core-6kda· GitHub #1133 · type bug · priority P2 · created 2026-09-21 · closed 2026-10-02