Make the registered step vocabulary discoverable: name gate.diff-rules where an operator hits it #1057
Notifications
Due Date
No due date set.
Blocks
Reference: sam/archie#1057
Reference in new issue
Block a user
internal/domain/workflow/diff_rules.go documents gate.diff-rules as "the supported
migration target for the deleted .archie/gate.go hook", and nothing an operator can
reach says so:
"migrate its behavior to a registered YAML workflow step" and names no step type.
route, no CLI command (manager.StepTypes() is read by tests only), and the dashboard
editor seeds the YAML with just
- type:(ui/src/workflows/WorkflowDefinitionsCard.vue:43).requirement this change exists to satisfy (docs/prds/runtime-control-plane.md,
"Workflows", which still states "Their useful behavior must first be available as
normal workflow steps" without naming one).
{"type":"object"} (internal/app/controlplane/definitions.go), so the dashboard cannot
suggest the settings shape either. gate.diff-rules is also the first settings-bearing
step type in the vocabulary -- every shipped stage refuses settings outright.
Fix: name the step type in the guard's message (steps.go:227), document the step type
and its settings schema under docs/, and consider exposing the registered vocabulary
through the catalog so the dashboard can list and validate step types instead of
accepting free-text YAML.
Also consider (raised in review, kept as-is for now): the step type is the only word in
the vocabulary that is not ..
gate.diff-rulesis a familyname, not a shipped workflow's stage, and a workflow id
gatelanding later is refusedloudly at Manager.Register rather than shadowing; renaming it to fit the shipped-stage
convention would falsely claim it belongs to a shipped workflow.
Notes
Widened 2026-10-04 after an operator saved 'type: pooface' and the editor showed a green Valid tick until the server refused it.
Root cause: a step type is only Name + Factory(yaml.Node). It carries no description and no settings schema, and the vocabulary is never served, so the dashboard can only check YAML shape, and calls that Valid.
Plan:
Done when typing an unregistered type is flagged before save and every step on the page shows what it does.
Also in scope: the workflow interface fields (inputs, outputs, repository mode, identity, agent profile) exist only as raw YAML. The editor should show them as fields too.
Close reason
Step vocabulary (names + needs-repository) is served as x-step-types in the workflow-definitions catalog schema; the dashboard editor rejects unknown types and repo-needing steps in repo-less workflows, and lists the step types. steps.go guard was removed with Yaegi; docs/prds was deleted, so no in-tree docs. Settings schemas: archie-core-bn0v.
Imported from beads
archie-core-4kbg· GitHub #1146 · type task · priority P1 · created 2026-09-21 · closed 2026-10-04