Wire generate_video (MiniMax) tool end-to-end #1036

Closed
opened 2026-10-27 13:38:46 +00:00 by sam · 0 comments
Owner

Implemented the MiniMax text-to-video generation tool and wired it through the media-delivery pipeline built for this: tool -> tools.MultimodalResult -> drainChatStream detection -> gateway.TurnStream.Media -> gateway.MediaSender (Telegram delivers inline; webui falls back to a link).

What shipped

  • internal/tools/minimax: API client (create+poll against MiniMax's v2/video_generation and v2/query/video_generation/{id}), a builtin tools.ToolEntry (generate_video), fully test-first with an injected-clock poll loop (no real sleep in tests).
  • internal/tools: extended tools.MultimodalResult with a URLs []MediaRef field, for tool results whose media lives at a remote hosted URL rather than local bytes (the existing Files field).
  • cmd/archied/telegram_setup.go: drainChatStream now detects a MultimodalResult in a tool result's Output and calls turn.Media(...) per URL, alongside the existing turn.ToolCall(...) reporting.
  • internal/config: MinimaxConfig (off by default, unlike web_fetch -- this spends real API credits per call), api_key via the existing secret.SecretRef pattern.
  • cmd/archied/bootstrap.go: registerMinimaxTool -- only registers the tool once an API key actually resolves, matching the 'do not advertise a broken capability' pattern web_fetch already uses.
  • config.example.toml: documented [tools.minimax].

Scope deliberately left out (by explicit instruction: URL-only, get it working first)

  • Image-to-video (image_url content items) -- text-to-video only.
  • Local byte/file upload delivery path -- URL-only, matches gateway.MediaSender's current URL-only design.
  • Email/webhook channel delivery -- only Telegram implements gateway.MediaSender today; other channels have no inline media path, and webui falls back to a text link (see archie-core-1786748942243-6-f109697e for the still-open 'deliver generated images through channel and web abstractions' work).
  • No OpenAI video provider -- only MiniMax implemented, per this issue's scope. A second provider should follow the same tool-package shape (internal/tools/) if wanted.
  • No spend guard / approval gate on the tool despite it costing real credits per call (classified ClassMutating, not RequiresApproval) -- flagged in tool.go's doc comment as a candidate follow-up if usage shows it's needed.

Acceptance criteria

task check passes; go test ./... green except the pre-existing unrelated internal/app/agentworker architecture-test failure; golangci-lint clean on every touched package; config.example.toml documents [tools.minimax].

Close reason

Shipped and verified: task check equivalent (fmt/vet/build/test/lint) is clean across every touched package, red-then-green throughout. See the issue description for what's in scope and what's explicitly deferred. [Closure restored 2026-08-24: originally closed 2026-08-22, lost when the beads DB was rebuilt (.beads.backup-pre-recovery).]


Imported from beads archie-core-3ghy · GitHub #594 · type feature · priority P2 · created 2026-08-22 · closed 2026-08-24

Implemented the MiniMax text-to-video generation tool and wired it through the media-delivery pipeline built for this: tool -> tools.MultimodalResult -> drainChatStream detection -> gateway.TurnStream.Media -> gateway.MediaSender (Telegram delivers inline; webui falls back to a link). ## What shipped - internal/tools/minimax: API client (create+poll against MiniMax's v2/video_generation and v2/query/video_generation/{id}), a builtin tools.ToolEntry (generate_video), fully test-first with an injected-clock poll loop (no real sleep in tests). - internal/tools: extended tools.MultimodalResult with a URLs []MediaRef field, for tool results whose media lives at a remote hosted URL rather than local bytes (the existing Files field). - cmd/archied/telegram_setup.go: drainChatStream now detects a MultimodalResult in a tool result's Output and calls turn.Media(...) per URL, alongside the existing turn.ToolCall(...) reporting. - internal/config: MinimaxConfig (off by default, unlike web_fetch -- this spends real API credits per call), api_key via the existing secret.SecretRef pattern. - cmd/archied/bootstrap.go: registerMinimaxTool -- only registers the tool once an API key actually resolves, matching the 'do not advertise a broken capability' pattern web_fetch already uses. - config.example.toml: documented [tools.minimax]. ## Scope deliberately left out (by explicit instruction: URL-only, get it working first) - Image-to-video (image_url content items) -- text-to-video only. - Local byte/file upload delivery path -- URL-only, matches gateway.MediaSender's current URL-only design. - Email/webhook channel delivery -- only Telegram implements gateway.MediaSender today; other channels have no inline media path, and webui falls back to a text link (see archie-core-1786748942243-6-f109697e for the still-open 'deliver generated images through channel and web abstractions' work). - No OpenAI video provider -- only MiniMax implemented, per this issue's scope. A second provider should follow the same tool-package shape (internal/tools/<provider>) if wanted. - No spend guard / approval gate on the tool despite it costing real credits per call (classified ClassMutating, not RequiresApproval) -- flagged in tool.go's doc comment as a candidate follow-up if usage shows it's needed. ### Acceptance criteria task check passes; go test ./... green except the pre-existing unrelated internal/app/agentworker architecture-test failure; golangci-lint clean on every touched package; config.example.toml documents [tools.minimax]. ### Close reason Shipped and verified: task check equivalent (fmt/vet/build/test/lint) is clean across every touched package, red-then-green throughout. See the issue description for what's in scope and what's explicitly deferred. [Closure restored 2026-08-24: originally closed 2026-08-22, lost when the beads DB was rebuilt (.beads.backup-pre-recovery).] --- _Imported from beads `archie-core-3ghy` · GitHub #594 · type feature · priority P2 · created 2026-08-22 · closed 2026-08-24_
sam added the mediumfeature labels 2026-10-27 13:38:46 +00:00
sam self-assigned this 2026-10-27 13:38:46 +00:00
sam closed this issue 2026-10-27 13:38:46 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1036