Audit go-git beta HTTP credentials and removed dumb transport #1024

Open
opened 2026-10-27 13:38:43 +00:00 by sam · 0 comments
Owner

go-git/v6 alpha.5 to beta.1 changes HTTP credential scoping and redirects, introduces CredentialsDroppedError, and removes dumb HTTP transport support. Archie uses go-git for authenticated clone/fetch/push and installs transport handling in internal/worktree/worktree.go. Investigate those actual callers against beta.1; adapt only where the new API or behavior requires it. Keep git execution in the daemon and credentials out of agent containers.

Acceptance criteria

Supported authenticated clone/fetch/push work under beta.1; same-origin and cross-origin redirects obey credential boundaries; dropped credentials and unsupported dumb HTTP endpoints produce actionable redacted errors; no token leaks or compensating transport fallback; security regression tests where behavior changes and task check pass.

Notes

Audit completed in be31522e with no production migration required. Manager.auth already uses gitclient.WithHTTPAuth, whose beta.1 contract scopes credentials to the repository origin. Existing wrapped errors preserve CredentialsDroppedError and upstream actionable dumb-HTTP errors without exposing tokens. TestForgeHTTPAuthentication exercises the actual Manager against git http-backend: authenticated clone, commit, push, and resume/fetch; same-origin redirects work; cross-origin credentials are withheld and refusal is diagnostic; dumb HTTP is explicitly rejected. Final task check and race test passed.


Imported from beads archie-core-2rjq · GitHub #1545 · type task · priority P2 · created 2026-10-09

go-git/v6 alpha.5 to beta.1 changes HTTP credential scoping and redirects, introduces CredentialsDroppedError, and removes dumb HTTP transport support. Archie uses go-git for authenticated clone/fetch/push and installs transport handling in internal/worktree/worktree.go. Investigate those actual callers against beta.1; adapt only where the new API or behavior requires it. Keep git execution in the daemon and credentials out of agent containers. ### Acceptance criteria Supported authenticated clone/fetch/push work under beta.1; same-origin and cross-origin redirects obey credential boundaries; dropped credentials and unsupported dumb HTTP endpoints produce actionable redacted errors; no token leaks or compensating transport fallback; security regression tests where behavior changes and task check pass. ### Notes Audit completed in be31522e with no production migration required. Manager.auth already uses gitclient.WithHTTPAuth, whose beta.1 contract scopes credentials to the repository origin. Existing wrapped errors preserve CredentialsDroppedError and upstream actionable dumb-HTTP errors without exposing tokens. TestForgeHTTPAuthentication exercises the actual Manager against git http-backend: authenticated clone, commit, push, and resume/fetch; same-origin redirects work; cross-origin credentials are withheld and refusal is diagnostic; dumb HTTP is explicitly rejected. Final task check and race test passed. --- _Imported from beads `archie-core-2rjq` · GitHub #1545 · type task · priority P2 · created 2026-10-09_
sam added the mediumtask labels 2026-10-27 13:38:43 +00:00
sam self-assigned this 2026-10-27 13:38:43 +00:00
sam added the deferred label 2026-11-15 17:26:22 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1024