daemon: durable workflow-pin defects park as transient, so a retry pass would loop #1015

Closed
opened 2026-10-27 13:38:41 +00:00 by sam · 0 comments
Owner

pinTaskProfile parks every pinWorkflowDefinition failure as taskstate.ParkTransient. park_class:transient documents that nothing about the work is wrong and a requeue can succeed, but the dominant pin failures are durable: a stored definition whose YAML does not hash to the digest recorded beside it, a definition that does not parse, and a workflow/playbook binding resolving to a definition the collection does not offer. Those recur on every requeue until an operator resolves the row or the configuration, exactly the loop the classification exists to stop; the pinTaskProfile comment ('An unconfigured profile needs an operator: the fix is configuration, then a retry') already describes an operator-actionable park. Only a State Store read/persist failure is genuinely environmental. Fix at the producer: pinWorkflowDefinition tags each failure with the class the cause needs (durable cause -> operator-actionable, store read/persist failure -> transient) instead of the park site guessing one class for every cause. Acceptance: a red-first test showing a durable pin defect is not classified transient; per-cause classification at the producer; scoped test/vet/lint clean.

Acceptance criteria

Red-first test: a durable pin defect (tampered stored pin) parks with a non-transient class; the park class is decided by the failing cause in pinWorkflowDefinition, not chosen blanket at the park site

Close reason

Shipped in de24485e: pinTaskProfile parks by cause via pinParkClass(err), not a blanket ParkTransient; durable pin defects now ParkNeedsHuman. Test pin_park_class_test.go.


Imported from beads archie-core-21es · GitHub #1453 · type bug · priority P2 · created 2026-10-02 · closed 2026-10-02

pinTaskProfile parks every pinWorkflowDefinition failure as taskstate.ParkTransient. park_class:transient documents that nothing about the work is wrong and a requeue can succeed, but the dominant pin failures are durable: a stored definition whose YAML does not hash to the digest recorded beside it, a definition that does not parse, and a workflow/playbook binding resolving to a definition the collection does not offer. Those recur on every requeue until an operator resolves the row or the configuration, exactly the loop the classification exists to stop; the pinTaskProfile comment ('An unconfigured profile needs an operator: the fix is configuration, then a retry') already describes an operator-actionable park. Only a State Store read/persist failure is genuinely environmental. Fix at the producer: pinWorkflowDefinition tags each failure with the class the cause needs (durable cause -> operator-actionable, store read/persist failure -> transient) instead of the park site guessing one class for every cause. Acceptance: a red-first test showing a durable pin defect is not classified transient; per-cause classification at the producer; scoped test/vet/lint clean. ### Acceptance criteria Red-first test: a durable pin defect (tampered stored pin) parks with a non-transient class; the park class is decided by the failing cause in pinWorkflowDefinition, not chosen blanket at the park site ### Close reason Shipped in de24485e: pinTaskProfile parks by cause via pinParkClass(err), not a blanket ParkTransient; durable pin defects now ParkNeedsHuman. Test pin_park_class_test.go. --- _Imported from beads `archie-core-21es` · GitHub #1453 · type bug · priority P2 · created 2026-10-02 · closed 2026-10-02_
sam added the mediumbug labels 2026-10-27 13:38:41 +00:00
sam self-assigned this 2026-10-27 13:38:41 +00:00
sam closed this issue 2026-10-27 13:38:41 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1015