gate: verify ui/dist is fresh instead of silently repairing it #1010

Closed
opened 2026-10-27 13:38:39 +00:00 by sam · 0 comments
Owner

Fix landed on fix/gate-verify-ui-dist-freshness: task ui:check (tools/uidist.sh)
rebuilds the dashboard into a temporary directory and compares it with the
committed ui/dist, failing the gate when they differ.

CORRECTION to the original report: task check does NOT run task ui -- it never
builds the dashboard at all. The drift was invisible because nothing in the gate
read ui/dist, not because a build silently repaired it.

Evidence (on the branch):
fresh tree -> exit 0
hand-staled bundle -> exit 1, names the differing file
#889 drift replayed -> exit 1, names BOTH index.css and index.js
(pre-#889 dist, post-#889 src)
git status after a run -> unchanged; the check never writes ui/dist

Partial staleness is reported per file by diff -rq, as requested.

Known cost: ui:check declares ui:deps like ui and test:ui, so the gate runs
npm install once per dependent. Task's sources/generates up-to-date check does
not apply to a node_modules directory, so guarding that is separate work.

Notes

Branch correction: this landed inside PR #890 (branch fix/dashboard-vocabulary-single-source, commit 5f06f489), not on a dedicated branch as the description says. It is task ui:check + tools/uidist.sh, wired into task check after test:ui. Offered to split it into its own PR if the maintainer prefers.

Close reason

Closed


Imported from beads archie-core-1vhh · GitHub #926 · type bug · priority P2 · created 2026-09-19 · closed 2026-09-19

Fix landed on fix/gate-verify-ui-dist-freshness: task ui:check (tools/uidist.sh) rebuilds the dashboard into a temporary directory and compares it with the committed ui/dist, failing the gate when they differ. CORRECTION to the original report: task check does NOT run task ui -- it never builds the dashboard at all. The drift was invisible because nothing in the gate read ui/dist, not because a build silently repaired it. Evidence (on the branch): fresh tree -> exit 0 hand-staled bundle -> exit 1, names the differing file #889 drift replayed -> exit 1, names BOTH index.css and index.js (pre-#889 dist, post-#889 src) git status after a run -> unchanged; the check never writes ui/dist Partial staleness is reported per file by diff -rq, as requested. Known cost: ui:check declares ui:deps like ui and test:ui, so the gate runs npm install once per dependent. Task's sources/generates up-to-date check does not apply to a node_modules directory, so guarding that is separate work. ### Notes Branch correction: this landed inside PR #890 (branch fix/dashboard-vocabulary-single-source, commit 5f06f489), not on a dedicated branch as the description says. It is task ui:check + tools/uidist.sh, wired into task check after test:ui. Offered to split it into its own PR if the maintainer prefers. ### Close reason Closed --- _Imported from beads `archie-core-1vhh` · GitHub #926 · type bug · priority P2 · created 2026-09-19 · closed 2026-09-19_
sam added the mediumbug labels 2026-10-27 13:38:39 +00:00
sam self-assigned this 2026-10-27 13:38:39 +00:00
sam closed this issue 2026-10-27 13:38:40 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sam/archie#1010