Found while gating the text-batcher lane (commit a069c436): Router.RouteStream in internal/gateway/gateway.go has NO production caller.
The only path that used it -- the local chat adapter's run closure -- now calls streamTurn directly, after the adapter's prelude runs the gates and the batch collection on the caller's own goroutine. Every chat consumer reaches streaming through messaging's ChatContract to LocalChatAdapter.Stream, so nothing outside tests enters by RouteStream.
That leaves two "run the gates, then stream" entry points where one behaviour should have one authoritative path: prelude() owns the sequencing the adapter actually needs, and RouteStream duplicates it for nobody.
Work:
Delete RouteStream.
Re-anchor its tests to the adapter: TestRapidFireFragmentsTakeOneTurn calls RouteStream directly, so it must drive LocalChatAdapter.Stream instead. That makes the integration test exercise the production path rather than a dead one -- the whole point of re-anchoring rather than repointing.
Keep streamTurn (the gates-free half) as the only internal streaming dispatch, and keep its doc comment: the gate bypass and the first-fragment SourceID reasoning is load-bearing.
Verify no caller outside internal/gateway before deleting (a repo-wide grep, tests included).
Not part of the batcher fix; that commit was extraction-only by design.
Close reason
Verified: fixed in code or doc/file no longer exists (see burndown 2026-10-13)
Imported from beads archie-core-1vcq · GitHub #1384 · type task · priority P3 · created 2026-09-29 · closed 2026-10-12
Found while gating the text-batcher lane (commit a069c436): Router.RouteStream in internal/gateway/gateway.go has NO production caller.
The only path that used it -- the local chat adapter's run closure -- now calls streamTurn directly, after the adapter's prelude runs the gates and the batch collection on the caller's own goroutine. Every chat consumer reaches streaming through messaging's ChatContract to LocalChatAdapter.Stream, so nothing outside tests enters by RouteStream.
That leaves two "run the gates, then stream" entry points where one behaviour should have one authoritative path: prelude() owns the sequencing the adapter actually needs, and RouteStream duplicates it for nobody.
Work:
- Delete RouteStream.
- Re-anchor its tests to the adapter: TestRapidFireFragmentsTakeOneTurn calls RouteStream directly, so it must drive LocalChatAdapter.Stream instead. That makes the integration test exercise the production path rather than a dead one -- the whole point of re-anchoring rather than repointing.
- Keep streamTurn (the gates-free half) as the only internal streaming dispatch, and keep its doc comment: the gate bypass and the first-fragment SourceID reasoning is load-bearing.
- Verify no caller outside internal/gateway before deleting (a repo-wide grep, tests included).
Not part of the batcher fix; that commit was extraction-only by design.
### Close reason
Verified: fixed in code or doc/file no longer exists (see burndown 2026-10-13)
---
_Imported from beads `archie-core-1vcq` · GitHub #1384 · type task · priority P3 · created 2026-09-29 · closed 2026-10-12_
sam
added the lowtask labels 2026-10-27 13:38:39 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Found while gating the text-batcher lane (commit
a069c436): Router.RouteStream in internal/gateway/gateway.go has NO production caller.The only path that used it -- the local chat adapter's run closure -- now calls streamTurn directly, after the adapter's prelude runs the gates and the batch collection on the caller's own goroutine. Every chat consumer reaches streaming through messaging's ChatContract to LocalChatAdapter.Stream, so nothing outside tests enters by RouteStream.
That leaves two "run the gates, then stream" entry points where one behaviour should have one authoritative path: prelude() owns the sequencing the adapter actually needs, and RouteStream duplicates it for nobody.
Work:
Not part of the batcher fix; that commit was extraction-only by design.
Close reason
Verified: fixed in code or doc/file no longer exists (see burndown 2026-10-13)
Imported from beads
archie-core-1vcq· GitHub #1384 · type task · priority P3 · created 2026-09-29 · closed 2026-10-12