Commit Graph
1477 Commits
Author SHA1 Message Date
sam e23e9fc989 chore(release): archied v1.19.8 2026-09-02 01:19:31 +10:00
sam 7fcc13c870 chore(beads): close archie-core-atv2 2026-09-02 01:19:24 +10:00
sam b966f6bd03 fix(telegram): send undelivered-media fallback after finalize as its own message
Closes archie-core-atv2.

Media delivery is fire-and-forget with a 30s budget, far longer than
the turn's text usually finishes -- so a large upload failing (or
timing out) after doFinalize has already retired the renderer goroutine
is the normal case, not an edge one. appendFallbackLine was still
writing into toolLines and calling requestRender, a non-blocking send
into a channel nothing reads any more once stopRendering has returned:
the line was silently dropped and the finalized message stood
unchanged, with nothing telling the user or the agent the file never
arrived.

stopRendering is the single point every finalize/abandon path funnels
through to retire the renderer, so it's the right place to mark the
reply finalized. appendFallbackLine now checks that flag and, once
set, sends the fallback as its own follow-up message instead of
appending to a buffer nothing will render again.
2026-09-02 01:18:54 +10:00
sam f603305a6a fix(telegram): stop adjacent rich blocks from rendering glued together
Two bugs behind the "System statusEverything is operating normally."
render:

1. Consecutive plain lines with no blank line between them were joined
   into one paragraph's text with an embedded "\n". Telegram's
   rich-block paragraph does not render an interior "\n" as a break --
   it renders nothing, so the words ran together with zero separator.
   Join with a space instead: the correct rendering of a CommonMark
   soft line break anyway, and it survives regardless of how the
   client treats a literal "\n".

2. Telegram's renderer adds no vertical gap between adjacent blocks on
   its own -- only a heading carries its own margin -- so a label line
   immediately followed by a list (or any two non-heading blocks back
   to back) rendered touching, with the list's first item glued to the
   preceding text and no visible line break at all. appendBlock now
   inserts an empty spacer paragraph before any block that doesn't
   follow a heading, making the gap explicit instead of depending on
   client-side spacing that isn't there.

Reproduced directly against markdownToBlocks with the reported input
and confirmed the fix before writing this up.
2026-09-02 01:12:53 +10:00
sam 19a16e8c63 fix(update): drop dev-facing wording from the unconfirmed-update message
"Treat this as UNCONFIRMED, not complete" is developer-speak in a
message an operator with no codebase context has to act on. Reword to
plain instruction: say what's known, then what to do about it.
2026-09-02 00:35:13 +10:00
sam f68f60e713 ci(deploy): key concurrency group on commit SHA, not ref
git push --follow-tags pushes main plus both archied/v* and archie/v*
tags in one operation, all pointing at the same commit. on.push
matches branches and tags, so every release push fired three identical
deploy runs -- observed just now: archied/v1.19.7, archie/v1.19.7, and
main all running in parallel from the same commit. The ref-keyed
concurrency group added earlier couldn't see these as the same work
since github.ref differs per trigger. Key on github.sha instead so all
three collapse into one.
2026-09-02 00:14:57 +10:00
sam 404e7c1560 chore(release): archied v1.19.7 archie v1.19.7 2026-09-02 00:13:39 +10:00
sam 66df4f6337 ci(deploy): cache image layers and cancel superseded deploy runs
Both images built via plain docker build/push with no cache, so every
push to main rebuilt archie-agent's full toolchain (apt packages,
golangci-lint, gofumpt, buf, uv+python, npm globals) from scratch --
several minutes, even when none of those inputs changed. Switch to
docker/build-push-action with GHA-backed layer caching per image.

Also add a concurrency group so a burst of pushes (e.g. a fix commit
immediately followed by its release commit) cancels the superseded
deploy rather than running three in parallel for capacity none of them
can use -- only the last one's :latest push matters anyway.
2026-09-02 00:06:52 +10:00
sam 01a1d1ba21 fix(logging): make Tail/Page allocation bound explicit for CodeQL
CodeQL's Go analyzer (go/uncontrolled-allocation-size, alert #6) can't
trace min(limit, MaxTailLines) as a bound on the request-derived limit
before make([]Entry, 0, limit). The clamp was already correct and has
been in place since 48133e6 -- confirmed by rescanning at current HEAD,
the alert still fires -- so this is an analyzer gap, not a live bug.
Same clamp, written as an explicit if so static analysis (and readers)
can verify the bound directly.
2026-09-02 00:04:06 +10:00
sam fe6a0efc35 chore(release): archied v1.19.6 2026-09-02 00:01:00 +10:00
sam 1425050506 fix(build): stamp gatewayVersion/runtimeVersion in the right package
-X main.gatewayVersion/main.runtimeVersion targeted package main, but
those vars live in internal/app/archied (cmd/archied is a thin
wrapper). An -X target that doesn't exist is silently ignored by the
linker, so every archied binary this shipped -- task build, install.sh,
Dockerfile.archied, and the carina self-update script -- reported
"dev" instead of its real version. Point every one of those ldflags at
the actual package.

Also, while chasing the carina incident this surfaced:

- restart.go: /restart didn't check for an in-flight /update install.
  The install runs as archied's own child process, so a restart killed
  it mid-build (observed: "signal: terminated") instead of letting it
  finish or fail cleanly. Refuse the restart while updateInProgress.
- update.go / update_report.go: the "no version could be confirmed
  running" branch still opened with "Update complete", contradicting
  its own next clause. Reworded so an unverified outcome isn't
  reported as completion.
2026-09-02 00:00:32 +10:00
sam bd5d4b9b13 chore(release): archied v1.19.5 archie v1.19.5 2026-09-01 23:42:01 +10:00
sam 95342037b0 test: replace brittle assertions with behavior checks
- mcp client_test: assert both initialize handshake calls happened and
  notifications/initialized has an empty ID, not their exact order
- telegram model_test: assert the resolved model has an openrouter/
  prefix instead of scanning button text for the string; replace the
  single-hardcoded-count pagination test with cases covering 0/1/8/9/100
  models so pageBounds and nav-row logic are actually exercised
- webui api_chat_test: assert the actionable file path is present in the
  streamed error instead of matching generic wording
2026-09-01 23:39:23 +10:00
sam 86ccff8787 chore: nolint for containedctx 2026-08-31 23:02:14 +10:00
sam ae33e366b2 chore: errorlint cleanup 2026-08-31 22:58:37 +10:00
sam 1adb018d3f chore: noctx cleanup 2026-08-31 22:56:38 +10:00
sam bd0867bd05 chore: remove unusued list 2026-08-31 22:54:11 +10:00
sam 7ff008e89d test(telegram): tidy install-context detachment regression test 2026-08-31 22:53:53 +10:00
sam 344c2d3491 test(webui): replace brittle origin response assertions 2026-08-31 22:53:16 +10:00
sam 9335b950da chore: beads interactions 2026-08-31 22:52:35 +10:00
sam 14d3a9461f feat(workflow): adversarial self-review stage before PR open
Implements archie-core-h019.3 (reviewer isolation) and h019.4 (wiring),
per docs/prds/adversarial-self-review.md.

- internal/domain/workflow: new Reviewer interface and StageReview,
  inserted between StageDiffCap and StageOpenPR in the implement
  workflow. Fail-closed: a review that didn't run, or a confirmed
  error-level finding, parks the task (store.StatusParked) with
  findings in Detail; warn/plausible findings never block. Inert
  unless Repo.ReviewEnabled.
- internal/worktree: Manager.Snapshot exports HEAD's tracked files into
  a fresh directory with no .git, for the reviewer's isolated
  workspace. Trees interface gains Snapshot; hybridTrees delegates to
  it.
- internal/app/agentworker: subagentReviewer implements Reviewer using
  ai-sdk's agent.Subagent (nested, in-process, non-streaming
  generation) -- conversation isolation is structural (Subagent.Run
  never carries message history), workspace isolation is the snapshot
  above. The reviewer's toolset is read-only (read/grep/find) rooted
  at the snapshot, never the worker's own toolset, so it cannot reach
  the worktreerpc publication grant. Findings are captured via a typed
  record_finding tool appending to a slice the stage owns, read even
  when Subagent.Run errors (a truncated run's captured findings
  survive).
- internal/config: Repo.ReviewEnabled (default false) and
  Models["reviewer"] (falls back to Models["builder"], no schema
  change).

Judgment calls: Reviewer.Review never returns a Go error -- every
failure folds into ReviewReport per the PRD's fail-closed contract,
which the stage can act on uniformly. A Subagent.Run error with zero
captured findings resolves to ReviewStatusNotRun (park); a
Subagent.Run error with >=1 captured findings resolves to
ReviewStatusCompleted with those findings, since the PRD's own example
("three defects survive a step-limit truncation") requires them to
still be evaluated for blocking rather than discarded.
2026-08-31 21:51:33 +10:00
sam 6121ce3e1a fix(lint): noctx fixes and dead-code cleanup
- install_script_test.go: exec.Command -> exec.CommandContext (noctx)
- architecture_test.go, store_test.go: go fix removed now-unused
  inspectEngineFamilies/parsePackageFiles/stringPtr helpers.
2026-08-31 21:35:58 +10:00
sam acc69f3197 refactor(lint): extract Apply/findWalkVisitor helpers; go fix modernization
- tomlwrite.go: split Apply into collectPending + an applier struct
  (indexTables/resolveTable/matchActiveKeys/uncommentKeys/
  appendMissingKeys/render). gocognit 82 -> under threshold.
- find.go: split findWalkVisitor's closure into findSkipEntry/
  findMatchesFilters. gocognit 46 -> under threshold. This clears the
  last complexity finding from archie-core-agui's original 31.
- richblocks.go: go fix modernization (strings.SplitSeq).

Behavior-preserving.
2026-08-31 21:35:58 +10:00
sam ed6a214f55 refactor(lint): extract markdownBlockParser and list/quote helpers in richblocks.go
markdownToBlocks's nested closures over shared mutable state become
methods on a markdownBlockParser struct; blocksToPlainText's list/quote
cases become listBlockPlainText/quoteBlockPlainText. gocognit 37 -> under
threshold for both. Behavior-preserving.
2026-08-31 21:34:05 +10:00
sam f1b6a12322 refactor(lint): split TurnRunner.Run and dispatchLocal further
turn.go: extract checkConfigured, replayPriorReply, claimTurn,
recordInboundMessage, prepareTurn, generateAndComplete out of Run
(gocognit 53 -> under threshold, gocyclo brought under 20 then under
cyclop's 15 too).

gateway.go: split dispatchLocal's second half into dispatchLocalMisc
(cyclop 18 -> under 15, on top of the earlier gocyclo fix).

Behavior-preserving; internal/gateway lint clean.
2026-08-31 21:33:16 +10:00
sam 9da36cc185 refactor(lint): split AgentStage.Stage into resolveModel/buildRequest/handleResult
gocognit 70 -> under threshold. Behavior-preserving: same request
fields, same guardrail/validate/persist/deliver sequence, just named
steps instead of one closure.
2026-08-31 21:30:00 +10:00
sam 18e2bc9caf refactor(lint): extract more helpers to clear nestif/gocyclo findings
- toolset.go: extract requireApproval out of toolExecute (nestif)
- gateway.go: extract handleDeny/handleVersion/handleUpdateCheck/
  handleRestartAdapter out of dispatchLocal (gocyclo 26 -> under 20)
- cronstore/store.go: extract applyPatch/applyScheduleChange out of
  Update (nestif, gocognit)

Behavior-preserving.
2026-08-31 21:28:46 +10:00
sam dfd56ba138 chore: cleanup excessive system prompt 2026-08-31 21:27:26 +10:00
sam 9f2e332862 fix(app): repoint capability-host wiring contract test at internal/app/archied
Second architecture test (after contract_test.go) that still grepped
cmd/archied for wiring strings following the cmd/archied ->
internal/app/archied extraction. task check now passes clean.
2026-08-31 21:27:07 +10:00
sam fdb8d2269f refactor(lint): reduce cyclomatic/cognitive complexity in tools, workflow, webui
Extracts focused helpers out of applyEdits, grepFallback/grepDirFallback,
serveReadContent, handleChatStream, TDD, runFindGoFallback,
makeGrepExecutor and makeShellExecutor to bring them under the
project's cyclop/gocognit/funlen thresholds. Behavior-preserving.

Partial pass on archie-core-agui: richblocks.go (gocognit),
gateway.go dispatchLocal (gocyclo), and a couple of remaining
gocognit/nestif findings are left for a follow-up.
2026-08-31 21:26:22 +10:00
sam b236e8a256 docs(architecture): reconcile domain package map, add domain/messaging types
- migration-decisions.md: confirm curator/mapping/scheduling as
  legitimate domains that were never added to the confirmed list;
  document identity/agent/messaging/plugin as approved-but-unmaterialised
  targets rather than creating dead stub packages.
- Resolve the open Session/Messaging decision (section 2): keep
  internal/gateway as-is rather than risk a big-bang rewrite of live
  session/compression/approval/branch logic; materialise
  internal/domain/messaging with the already-settled canonical
  Message/Conversation/ToolCall/ToolResult types. Actual gateway
  migration onto these types is tracked as sequenced follow-up bd
  issues (label messaging-migration).
- ARCHITECTURE.md: add internal/gateway, internal/tools, internal/memory,
  internal/secret, internal/plugin, internal/skill to the Package Map.
2026-08-31 21:26:06 +10:00
sam 806cd75e28 fix(config): standardize Provenance to pointer receivers (recvcheck)
Paths and String were value receivers alongside the mutating record()
pointer method. All Provenance uses are through addressable struct
fields, so this is behavior-preserving.
2026-08-31 21:26:01 +10:00
sam 4351d77166 refactor(agentexec): use ai-sdk NewTypedTool for pluginToolSet and scriptToolSet
Replaces hand-written JSON Schema + manual unmarshal with
core.NewTypedTool[In], now available at the pinned ai-sdk v0.1.30. This
removes the class of bug where a hand-rolled schema drifts from the
struct a manual decode unmarshals into.
2026-08-31 21:25:58 +10:00
sam f66824ae08 chore(ci): pin Go version from go.mod and add a govulncheck step
CI's go-version was a floating "1.26" independent of go.mod, so it
could silently drift from the toolchain the project actually builds
with. Switched to go-version-file: go.mod as the single source of
truth, and added `task vuln` (govulncheck) plus a CI scan step -- kept
out of `task check` since it needs network access to the vuln DB.
2026-08-31 21:25:54 +10:00
sam 7da5a64deb chore(build): bump Docker builder images from golang:1.26 to golang:1.27-trixie
go.mod is already on 1.27.0 (supersedes the 1.26.6 stdlib CVE fix set);
the Dockerfiles were still pinned to the older 1.26-trixie floating tag.
2026-08-31 21:25:50 +10:00
sam 483822c1e0 fix(app): repoint archied wiring contract test at internal/app/archied
Follow-up to the cmd/archied -> internal/app/archied wiring extraction:
the architecture test that greps main.go for required wiring strings
still pointed at the old cmd/archied path.
2026-08-31 21:25:45 +10:00
sam 5fa010c9c2 fix(plugin): add missing CLAUDE.md reference to plugin engine rule
Test TestPluginEngineRuleIsCanonicalAndSharedByAgentInstructions was
missing entirely, letting CLAUDE.md drift out of sync with
ARCHITECTURE.md#plugin-engine-rule-strict. Added the test and the
missing reference.
2026-08-31 21:25:20 +10:00
sam 88a995a736 test(coverage): add tests for workintake, secret, forge, natsrpc
Closes coverage gaps flagged in load-bearing packages:
- internal/domain/workintake: 14.3% -> 94.6%
- internal/secret/enginehost: 0% -> 100%
- internal/secret/secretextract: 10% -> 100%
- internal/forge: 36.1% -> 77.0%
- internal/natsrpc: 28.3% -> 91.3%
2026-08-31 21:24:25 +10:00
sam b2d4f93105 fix(gateway): fix broken system prompt template and scrub real telegram ID from tests
Funcs() was passed a *strings.Replacer value instead of its Replace
method, panicking gateway's init(). Fixing that surfaced a second bug:
the template still referenced .Operator, removed from promptData by
5a92fc1, which made every render fail and silently fall back to a
generic hardcoded prompt.

Also replaces a real Telegram chat ID hardcoded across several test
fixtures with a placeholder value.
2026-08-29 00:31:47 +10:00
sam 5a92fc17a5 refactor: remove unused Operator param. 2026-08-29 00:20:40 +10:00
sam b2da85ead1 refactor: go modernisation fixes 2026-08-29 00:20:05 +10:00
sam 8e4923991d chore: bump ai-sdk version. 2026-08-29 00:17:16 +10:00
sam 0af19ba983 refactor: remove unnecessary AI shit 2026-08-29 00:16:43 +10:00
sam 212f762021 fix: go.mod bumped to 1.27.0 and stupid tests removed 2026-08-28 23:44:41 +10:00
sam 7b0f745fb1 chore: fix CLAUDE.md to flow and remove contradictions. 2026-08-28 23:06:17 +10:00
sam 17ea3c4807 chore: beads interactions and issues 2026-08-28 22:28:49 +10:00
sam 37f7408474 feat(cronstore): durable job store with cross-process locking
Slice 1 of the cron/scheduling epic (archie-core-1786637496320-249-be6d9a20).
Implements the file-backed job store the scheduling ticker engine polls
through scheduling.JobSource. The engine applies no schedule arithmetic
of its own, so the store owns cron expressions, fixed intervals, and
catch-up windows — Slice 1 ships Interval fully, with Once accepted at
Create/fired at Due, and Cron reserved as a wire shape for Slice 2.

Files: per-profile JSON at <path>/jobs.json with a version-stamped
schema. CRUD by job id with merge-semantic Update (nil Patch fields are
preserved). Truncated/partial-write files return ErrCorruptFile; forward
schema versions return ErrUnsupportedSchema. DisallowUnknownFields means
additive shape changes must bump schemaVersion.

Concurrency: three locks stack in fixed order. (1) A package-level
mutex keyed by lock-file path serialises Stores within one process —
Linux flock is per file description, so two Store instances in the
same process have independent fds and would otherwise proceed in
parallel. (2) Cross-process flock serialises Stores across processes
(CLI vs daemon). (3) s.mu guards the in-memory mirror. Every
operation re-hydrates from disk before applying its change so a writer
that just acquired the locks sees every change the previous writer
committed. Atomic write via temp-file + rename + fsync for durability.

Validation: Create and Update validate Pool, Schedule, and required
fields up front so a hand-edited file cannot persist a job the engine
cannot reason about. MarkRun on a kind without next-run arithmetic
returns ErrScheduleUnsupported. Get/List return deep copies so caller
mutation cannot corrupt the in-memory mirror. Files are written 0o600
because payloads can carry operator-identifying data; SetEscapeHTML(false)
keeps operator-readable files human-friendly.
2026-08-28 22:28:49 +10:00
sam b5ca9c8867 chore: update issue tracker, remove ai-sdk ADR 2026-08-28 22:28:49 +10:00
sam 5a4c10fb07 fix(middleware): remove off-by-one tail call in retry streaming paths
ChatStream and StreamObject were issuing one extra unscheduled provider
call after MaxAttempts was exhausted, billing MaxAttempts+1 calls instead
of MaxAttempts on permanent-failure retries. Capture the last stream/err
across iterations and return them after the loop instead.

Adds middleware/retry_test.go with exact call-count assertions for all
four retry paths (Chat, ChatStream, GenerateObject, StreamObject),
MaxAttempts=1 short-circuit, non-retryable short-circuit, success-after-
retries, and ctx-cancellation paths.

Refs ai-sdk-5jb.1
2026-08-28 22:28:48 +10:00
sam 8120dc0760 feat(curator): track and expose recent activity per curator
Add a small bounded activity tracker (activityTracker, in
internal/domain/curator/activity.go) fed directly from the runtime's
existing emitRun point: last-run time, last-run action count, and up to
20 recent actions per curator, newest first. No persistence layer -- it
resets on restart, same as the rest of the runtime's in-memory state.
Registry.RecordActivity/Activity expose it.

Closes archie-core-1786637489932-6-1f803e02.
2026-08-28 22:28:48 +10:00