Commit Graph
3 Commits
Author SHA1 Message Date
sam 8139c0a3bf feat(configuration): report config keys no decode target consumed
decodeTOML discarded toml.DecodeFile's metadata, so a misspelled or
renamed key parsed, validated and silently did nothing. Document.UnknownKeys
now carries the dotted key paths a loaded file's decode targets left
undecoded.

One file feeds two decode targets (&doc.Config and &doc.Scheduling), so a
key legitimately owned by one shows up as undecoded in the other -- a key
is only reported when both leave it undecoded (unknownKeys intersects the
two sets), which is what keeps a valid [scheduling] block from being
misreported as unknown on every config that uses it.

YAML config sources are unchanged for now (no equivalent metadata hook in
the yaml decoder); this covers the TOML path, which is what
config.example.toml, every shipped deployments/*.toml profile, and
install.sh's generated config.toml all use.
2026-09-15 05:07:54 +10:00
sam dd3ae02472 fix(scheduling): respect configuration ownership 2026-09-14 23:25:09 +10:00
sam e9cc3076e4 feat(configuration): translate [scheduling] into scheduling.EngineConfig
The engine needs a fully-resolved configuration, not zero values it has to
second-guess. Add the translator the wiring slice then hands to
internal/app/archied:

  - TranslateScheduling resolves unset tunables from the domain's own
    Default* constants rather than a second copy here, so the two cannot
    drift.
  - A negative tunable is reported as a startup error wrapping
    ErrInvalidInput, matching validateCapture and validatePollInterval.
    Clamping was rejected: it runs something other than what the operator
    wrote, which is how a misconfiguration stays invisible.
  - Events and Clock stay nil. This package owns no bus and no clock --
    attaching them is composition -- and the engine documents a nil sink as
    a valid configuration: it still runs, it is just unobservable.

applySchedulingDefaults and validateScheduling keep defaulting and
validation separate, the split applyDefaults' own doc explains: the load
path applies both, Validate applies only the latter.

TDD: the translator tests were written first and failed on assertions
(Interval = 0s, want 1m0s; negative values accepted silently), not on
compilation.
2026-09-14 10:51:41 +00:00