- Reword docs and comments to drop vague "legacy" qualifiers where they no longer describe deprecation status
- Remove unused code: RecentEvents, MessageEvent.ToLegacy, index setState, stderr redaction tool, telegramOnlyCommands
- Delete or comment out tests covering removed or superseded behavior
Follow-up to c924281, which introduced two defects of its own.
1. indexing.Config was a private config island: index paths existed nowhere
in internal/config or config.example.toml, so they were undiscoverable
and unsettable by anyone reading the real configuration.
Now [indexing] in config.toml, defined in its own internal/config/
indexer.go rather than appended to the 21-struct config.go, and its
defaulting lives with it as IndexingConfig.withDefaults so finalize
delegates instead of growing. Paths default off work_dir, keeping the
two archied instances on one host from sharing an index. Documented in
config.example.toml.
internal/indexing keeps its own plain Config and does NOT import
internal/config, so it stays a straight diff against its tau original.
2. A failed index build was invisible. refreshAsync wrote the reason to a
database column with no reader and degraded to unindexed search in
silence — the failure mode that costs hours precisely because nothing
appears to be wrong. Every give-up path now logs, and a successful
build logs once.
The logger is resolved at the point of use, not in the constructor: a
Manager can be built as a struct literal (the ported tests do), and
constructor-only defaulting panicked on the build goroutine, where a panic
takes the daemon with it. Regression test covers the zero and nil Manager.
First slice of the tau cherry-pick strategy: copy-and-mutate rather than
extracting tau to pkg/. Exporting would force designing metrics, session
and logger seams upfront, before archie-core knows which of them it wants
differently — a cost paid for reuse not yet proven. ai-sdk earned library
status by stabilising across two consumers; nothing in tau/internal has.
indexing is the cheapest high-value lift: 512 LoC, one file, and its only
coupling to tau was three calls to process-global config path helpers.
Nothing else in tau imports it.
Mutations from upstream:
- path helpers become an explicit indexing.Config. Two archied instances
share a host (archie and winter), so they must not share one index.
- the child-process helper is archied's own workspace-codesearch
subcommand, dispatched before flag parsing so it touches no config,
store or NATS.
- deferred db.Close calls explicitly discarded; archie-core runs errcheck.
The child process is not incidental: google/codesearch calls fatal exits on
a corrupt index and leaks mmapped regions. Verified end to end against this
repo — 2.2MB indexed, correct hits for BuildSystemPrompt, [] for no match,
and a deliberately corrupted index returns "corrupt index" with exit 1
instead of taking the process down.
Every lifted file carries a provenance header naming its tau path and
commit (4893818d0c76), so refreshing from upstream is a diff rather than
archaeology.