Commit Graph
1404 Commits
Author SHA1 Message Date
sam 2aacac2495 refactor(webui): decode JSON request bodies with generic decodeBody 2026-10-10 11:05:58 +11:00
sam 3f76f15daa refactor(domain): share one generic lifecycle registry for curators and memory engines 2026-10-10 11:05:58 +11:00
sam 28032ddbd4 feat(workflow): switch step runs the case matching a reference 2026-10-10 10:52:52 +11:00
sam a6ea539282 fix(kit): migrate runtime to sandbox kit m8 2026-10-09 18:31:56 +11:00
sam a568e0093d feat(ui): edit workflow call interfaces on the canvas 2026-10-09 18:04:08 +11:00
sam 6b7718a264 fix(daemon): reconcile call waits from durable steps 2026-10-09 17:56:15 +11:00
sam 97afa76685 feat(harness): create the setup PTY at the browser's size
The setup terminal created its PTY at a fixed 24x80 while the browser
measured its own box and threw the measurement away, so a full-screen CLI
login drew into a corner of a much larger xterm.

OpenRequest now carries a ConsoleSize with the target frame; the route
reads cols/rows from the WebSocket URL, falling back to 24x80 when they
are absent or out of range, and the daemon creates the PTY at that
geometry. The component sends the size it measured before connecting.

Live resize is the follow-on: it needs a control channel on the WebSocket,
which today is a raw byte copy.
2026-10-09 13:07:29 +11:00
sam 6110693aa8 fix(harness): keep the setup container alive with archie's own binary
A setup session started its container with "sleep infinity" and opened the
PTY with "sh -l". Neither binary is guaranteed: the spec capability whose
floor is a shell and bash is com.docker.sandbox/sbx@1, and archie's
supported map does not list it, so a Kit image need not provide either. A
missing sleep killed the container at start and a missing sh failed the
exec, both as an opaque error.

The container now runs archie-agent hold as its entrypoint. The agent
binary is archie's own and already mounted into every Kit, so the
keepalive needs nothing the image may lack and the container env stays
empty. Before opening the PTY, harnesssession probes for bash then sh and
returns ErrNoShell naming the Kit reference when neither is present.

Test: TestPickShell covers bash-preferred, sh-only, neither, and a probe
that cannot run.
2026-10-09 13:05:05 +11:00
sam 70e076825d fix(channels): normalize stored settings and deduplicate save errors 2026-10-09 13:02:23 +11:00
sam 954413d426 fix(egress): use context-aware dial and request in the token-endpoint test
net.Dial and httptest.NewRequest fail the noctx linter, so the gate was red
on the commit that added the test.
2026-10-09 12:27:45 +11:00
sam fbf48b4b48 fix(egress): refuse a token endpoint the run is not granted
forward intercepted a declared OAuth credential's token endpoint only when
the run was granted the service. For an optional credential it fell
through to the reverse proxy, so the provider's real access and refresh
tokens reached the container un-sentinelized, contradicting the harness
contract's "the real credential never enters the container".

A matched token endpoint is now refused when the service is not granted
(403 for an optional credential; a required one keeps its existing 502).
The table test drives forward against a recording upstream and asserts
both the status and that the upstream was never contacted.
2026-10-09 11:42:39 +11:00
sam 29baa82e1a fix(config): normalize default org for harness credentials 2026-10-09 10:01:35 +11:00
sam 645ab0ae9f feat(settings): classify startup and live runtime settings 2026-10-09 09:57:57 +11:00
sam eac34272ae feat(logging): aggregate recent service logs in dashboard 2026-10-09 09:57:57 +11:00
sam 66948c2deb fix(gateway): attribute chat settings to signed-in users 2026-10-09 09:57:57 +11:00
sam f865eb18b7 fix(webui): explain personal token availability 2026-10-09 09:57:57 +11:00
sam a057531bad refactor(webui): remove unused configuration schema 2026-10-09 09:57:57 +11:00
sam 8f7c14e5c6 fix(gateway): read task logs through state store 2026-10-09 09:57:57 +11:00
sam 887ccd6943 fix(configuration): reject unknown conf.d files 2026-10-09 09:57:56 +11:00
sam 8c00d076f8 feat(curators): edit and apply definitions live 2026-10-09 09:57:56 +11:00
sam 9773b0a753 feat(settings): show resource consumers and apply status 2026-10-09 09:57:56 +11:00
sam 4fb021aa01 feat(presence): report workers and broker on status 2026-10-09 09:57:56 +11:00
sam 33a0928ac8 feat(presence): expose service dependency checks 2026-10-09 09:57:56 +11:00
sam 78d369435e fix(daemon): inherit live settings for identity tasks 2026-10-09 09:57:56 +11:00
sam f36510b791 test: verify enablement reports channel running 2026-10-09 02:24:47 +11:00
sam 41014335ff fix(workflow): enforce optional result booleans only when required 2026-10-09 02:22:19 +11:00
sam 1767672ce0 fix(messaging): refuse failed channels as enablement success 2026-10-09 02:22:19 +11:00
sam d4f98c5be0 fix(workflow): retry a transient read while awaiting a callee 2026-10-09 02:21:49 +11:00
sam b15e9cf5e7 fix(workflow): preserve a reference's type between steps 2026-10-09 02:10:43 +11:00
sam bba5c9d7de feat(harness): serve a daemon-side setup session to the dashboard
The dashboard's setup terminal was a 503: it had a WebSocket route, an
authorizer and an xterm.js surface, but nothing owned a container. The
daemon owns containers, so the session contract lands there and the
dashboard consumes it over a new gRPC contract.

One session concept, two targets. A setup session is addressed by Kit
profile and is ephemeral; a run session (archie-core-qi91) is addressed by
task and attempt and is bounded by the task. This slice serves setup and
answers Unimplemented for run.

The contract, the authorisation, the lifetime and the egress phase are
settled in docs/prds/external-agent-harness.md, "Session contract". The
short version: the daemon serves harness.v1.HarnessService; the dashboard
authorizes the operator as an update on the secret and then dials the
daemon with the harness service token, required even on loopback because a
session is a shell holding an org's credential; the setup container runs
no worker, mounts no worktree, holds a keepalive, and carries an empty
container environment. Install hooks run at the install phase and the
session enters runtime before the shell, so a runtime-phase credential's
token endpoint is the one the proxy intercepts.

Capture is gated by the egress proxy on a granted service, and a setup
session has no task, so the daemon registers a session grant: the
session's proxy token resolves to the org's bindings for the Kit's
declared services. The real token never enters the container: the token
endpoint response is sentinelized and stored as the org's harness secret.

Every teardown path releases the pool slot, revokes the egress session and
the grant, removes the sandbox network, and removes the session's volumes.
The listener requires HARNESS_TOKEN and stops with a 10s grace before
Stop, so an open session cannot hold shutdown to the watchdog leash.
2026-10-09 01:38:41 +11:00
sam 6ecdd67262 fix(container): reap orphaned processes in Kit containers 2026-10-09 01:37:57 +11:00
sam 01b691142c chore(lint): drop nolint directives that suppress nothing
29 of 59 directives did nothing. Removing each one individually and
re-running the gate revealed no issue from any of them: 20 named gosec,
which is not enabled in .golangci.yml and never has been, plus 4 nilerr
in functions that return no error, 2 dupl where dupl reports nothing
repo-wide, and one each of contextcheck, nestif and unused. The funlen
name on settings.go:147 is gone for the same reason; its gocyclo and
cyclop names are both live.

The unused directive in webui/authorize.go sat on `var _ = slog.Default`,
a statement that only existed to keep the log/slog import alive. Both go.

The 30 remaining directives all suppress a real issue.
2026-10-08 23:29:19 +11:00
sam 1a5556e1cf fix(modelcatalog): never serve a disabled provider from the ambient key
disableProvider already cleared a failed provider's credential, but that
made it indistinguishable from a provider nobody configured, so
usableProvider fell back to the catalog's ambient env var (e.g.
OPENAI_API_KEY) and sent turns with a key the operator did not choose.
Mark the provider Disabled when its key fails to resolve, refuse it in
usableProvider, and carry the flag through mergeProviders so a catalog
refresh cannot resurrect it.
2026-10-08 22:59:23 +11:00
sam e0b49855e7 fix(webui): keep the dashboard token out of the startup log
DashboardURL no longer takes a token, so the startup line cannot embed
?t=<token> in the printed URL. The log now names the token file instead.
2026-10-08 22:57:28 +11:00
sam f33a33d854 feat(scheduling): refuse a job payload that names a dangerous command
A scheduled job runs unattended, so a payload that restarts the daemon,
formats a disk or powers the machine down is refused when the job is
created rather than when it fires. scheduling.RefuseDangerousJob is the
one rule every creation path reaches: the dashboard, any control-plane
client and the config seed all replace the schedules document through the
same validator, so a new token is added in one place.
2026-10-08 22:45:28 +11:00
sam 1c47b86413 fix(archiemessaging): apply channel enablement live 2026-10-08 22:44:15 +11:00
sam 6f2a110a5d refactor(tools): back generate_video with ai-sdk's minimax video provider
Delete the hand-rolled MiniMax HTTP/poll client; ai-sdk v0.1.43 already
ships provider/minimax implementing video.Provider with the same endpoints,
defaults and poll semantics. The tool now takes a video.Provider and the
composition root builds it, matching the transcription and embedding
capabilities.
2026-10-08 22:42:49 +11:00
sam 12049c03f6 fix(archiemessaging): recover a channel that fails on its own 2026-10-08 22:36:09 +11:00
sam 34bc6865e5 fix(archied): wait for in-flight tasks on a single-cycle run
A drain pass no longer waits for the tasks it submitted, so -once (the
systemd timer and test invocation) returned while their containers were
still running and the process then tore them down. Wait for the pass's
tasks here, restoring what the flag means.
2026-10-08 22:31:07 +11:00
sam 708b1ea502 fix(daemon): let a run waiting on a callee release its capacity
A wait:true workflow.call run held its global slot and its repo's place for
the callee's whole life, and the drain pass waited for its own tasks, so a
callee queued by that pass was never claimed. With containers.max_concurrency
saturated, or a repo that does not allow concurrency, the wait could not end.

A drain pass now returns once the stream and the claim fallback are empty, and
shutdown waits for in-flight work once. Suspend/Resume give a run's slot and
repo place back while it waits on a callee, driven by the workflow call events
on the daemon's bus; a hold records one slot and one place, so a second
re-acquire gives back what it took.
2026-10-08 22:31:07 +11:00
sam f7c623983d refactor(workflow): keep the call key change inside the lint gate
golangci-lint failed on the change and had not before: gofumpt wants
StartCall's same-typed parameters grouped, and runWorkflowCall reached a
cyclomatic complexity of 16. The unwaited call's early close moves into
closeUnwaitedCall on *TaskContext -- it needs only the call step, the
callee and the settings -- which leaves runWorkflowCall below the limit
with its behaviour unchanged.

The walk's id-less call case is deleted: ParseDefinition now refuses that
definition before validateWorkflowCalls runs, so it passed for the wrong
reason. The refusal is pinned where it happens instead, by the compile
case in TestWorkflowCallKeyIsTheDeclaredPath, now asserting the whole
message so it still names the step it refused.
2026-10-08 22:31:07 +11:00
sam 703aea4568 fix(workflow): key a call on its callee, and free a terminal child's key
A call's key was the step's declared path alone, so one task running a
second definition at a colliding path -- workflow.handoff, human.approve
and a definition re-pin all change it -- was handed the first callee's
child, waited on the wrong workflow and published its outputs. The key
now carries the callee too, while the step row and the call's events stay
named and staged for the call site, so a rail pairing an event with its
step still attaches them.

A child that reached dead or closed_wont_do can never do the work and
holds no result the caller can use, so it leaves the call key's index and
frees the key for the caller's retry to start a fresh child. parked and
rejected keep theirs: a parked child is recoverable by retrying it, and a
rejected child ran.

The id a call step must declare is now refused where the definition is
compiled, which is also the path a pinned definition takes, so an id that
spells a step type is accepted again and no stage needs a heuristic.
2026-10-08 22:31:07 +11:00
sam 0101947131 fix(workflow): key a workflow.call on its declared step path
A call site had no durable identity, so any retry of it -- a lost
EnqueueCallTask reply, a failed call-step record, a requeued attempt that
re-runs the stage -- started a second child and its work happened twice.

The call step's declared path within the run is that identity: wrapStep
sets it (branch-qualified, restored on return), a workflow.call step must
declare an id so two call sites cannot share one, and the key crosses
EnqueueCallTaskRequest.call_key into tasks.call_key, which EnqueueCallTask
upserts on so the retry returns the child already started.
2026-10-08 22:31:07 +11:00
sam ec85790982 fix(agentexec): enforce capture tool result schemas 2026-10-08 22:30:12 +11:00
sam 10308d4170 fix(workflow): apply step retry and on_failure to command.run 2026-10-08 22:22:13 +11:00
sam f88a8064c0 fix(webhook): authorize delivery against the source's org 2026-10-08 21:43:28 +11:00
sam f80e4d7214 test(postgres): derive the org fixture source from its insert 2026-10-08 21:40:24 +11:00
sam 29f23d2a1a fix(captures): keep count-retention inside the inserted capture's org 2026-10-08 21:27:54 +11:00
sam bb338f0055 fix(captures): scope the capture list to the acting org 2026-10-08 21:26:07 +11:00
sam ff68a22260 fix(sources): store the acting org on source creation 2026-10-08 21:25:49 +11:00