08ebc19c8c7bb33765c4e5ffbccc8ac49130c60e
2
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
19b400bf07 |
chore(plugin): delete the unwired capability-host health surface (#882)
* chore(plugin): delete the unwired capability-host health surface
plugin.Host.Health, plugin.Host.Manifests, ModuleStatus and their private
safeHealth helper were implemented, exhaustively tested, and called from nowhere
but their own tests. AGENTS.md forbids speculative surfaces, and no settled
design places plugin module status anywhere that exists:
- docs/prds/status-health-surface.md Phase 2 is self-described as "a proposed
resolution, awaiting Sam's sign-off -- not yet implemented", and does not
mention plugin status even in that unapproved list.
- The readiness subsystem enumerates exactly five probes -- state_db, config,
disk, model, gateway (internal/app/archied/readiness.go) -- with no plugin
probe.
- docs/architecture/plugins-and-extensions.md names no operator-visible plugin
status surface.
- The only bead naming it is closed.
plugin.Host itself stays: it is the daemon's live capability host, constructed
and Start/Stop-ed from internal/app/archied. Only the unconsumed observability
methods go.
host_contract_test.go encoded the defect -- it asserted plugin.Host *defines*
"Health" and "Manifests" -- so those two names are removed from its list, which
is now exactly the shipped lifecycle: Register, Start, Stop. The three tests
covering the deleted surface are removed with it.
The Yaegi symbol table (internal/plugin/pluginextract) was regenerated rather
than hand-edited, so ModuleStatus leaves the reflected type set with it.
Reachability evidence: Host.Health and Host.Manifests appear only in their own
tests; plugin.Host is otherwise reached from bootstrap.go and gateway.go for
Register/Start/Stop. Note that "task reachability" does NOT flag these -- the
address-taken constructor is a known blind spot of the whole-program RTA.
* chore(plugin): delete the dead Module.Health chain wired to nothing
Extends the capability-host observability deletion: plugin.Module.Health
was a required interface method with real implementations in
tools/provider/mcp and tools/provider/builtin, aggregated by
tools/provider.Registry.Health via a provider-package-local safeHealth,
and backed by per-module LifecycleState bookkeeping in plugin.Host
(registeredModule.state, setModuleState). None of it had a caller before
this change -- Host.Health was the only thing that would ever have read
a registered module's Health(), and Host.Health was already deleted as
unreachable. registeredModule.state was write-only: nothing ever read it.
Deleted:
- plugin.Module.Health, plugin.Health/HealthStatus (+ consts),
plugin.LifecycleState (+ consts), legacyModule.Health,
registeredModule.state, Host.setModuleState and its call sites.
- tools/provider.Registry.Health, tools/provider.safeHealth.
- tools/provider/mcp.Provider.Health, tools/provider/builtin.Provider.Health.
- Tests exclusively covering the above, and fakes' now-unnecessary Health
methods (plugin/host_test.go, pluginextract/reachability_test.go,
tools/provider/{provider,optional}_test.go, tools/provider/mcp/provider_test.go,
app/agentworker/mcp_providers_test.go).
internal/plugin/pluginextract's generated file was regenerated via
`go generate ./internal/plugin/...` and the yaegi wrapper nil-guards
(dropped by fresh generation, as documented in reachability_test.go)
were reapplied by hand to WManifest/WStart/WStop/WName/WVersion,
following this repo's established post-regen pattern.
|
||
|
|
a2b2dc9ef2 |
fix(tools): let an optional provider fail without taking the daemon down
provider.Registry.Start was atomic for every provider: one failure unregistered every other provider including the builtins, returned an error up through the capability host, and exited archied. Under Restart=on-failure that is a crash loop. Observed on carina 2026-07-30 -- mcp.desktop-commander could not start because the runtime image was missing unzip, and the daemon restarted continuously, losing chat, the gateway and every builtin tool over one third-party npm package. Atomicity is right for a provider archied requires. It is wrong for an external MCP server pulled from a registry at runtime, which is exactly the category allowed to be absent -- the same reasoning already applied to the forge, and to containers. RegisterOptional marks a provider the daemon can run without. Its failure to start, discover or index stops only itself and excludes it; Register keeps today's rollback. Required/optional is a deployment fact rather than a property of the code, so the registrar states it instead of the engine declaring it in its own manifest -- which also keeps plugin.Manifest metadata-only, per the plugin engine rule. A skipped provider's dependents cannot run either: an optional dependent is skipped with the reason, a required one is a hard failure, since it declared it cannot work without something now absent. Degradation is reported, not silent -- Health goes degraded naming each provider and cause, Skipped() exposes the set, and the daemon logs one error line per exclusion. Silence is how this went unnoticed until the crash loop. A provider that half-started before failing is still stopped, so no child process is left behind. The regression test drives the real capability host, the path main.go calls: with desktop-commander registered as required it fails with the verbatim carina error, and as optional the daemon starts with its builtins intact. Closes archie-core-ky6 |