From c787db7e0777b72e66f19fd14e1cf80f699e6da2 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Sat, 24 Oct 2026 18:18:54 +1100 Subject: [PATCH] chore(workflow): log where a review's comments are placed before posting --- internal/domain/workflow/prreview_stages.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/internal/domain/workflow/prreview_stages.go b/internal/domain/workflow/prreview_stages.go index 540c3d861..a7acd8266 100644 --- a/internal/domain/workflow/prreview_stages.go +++ b/internal/domain/workflow/prreview_stages.go @@ -731,14 +731,15 @@ func postPRReview(ctx context.Context, tc *TaskContext) error { // again with none inline. func postReview(ctx context.Context, tc *TaskContext, owner, repo string, number int, headSHA string, findings []prreview.ScoredFinding) error { review := forgeReview(findings, tc.prReview.files) - err := tc.Forge.CreateReviewComments(ctx, owner, repo, number, headSHA, review) - if err == nil || len(review.Comments) == 0 { - return err - } places := make([]string, 0, len(review.Comments)) for _, c := range review.Comments { places = append(places, fmt.Sprintf("%s:%d", c.Path, c.Line)) } + tc.Log.Info("posting review", "inline", places, "body_bytes", len(review.Body), "diff_files", len(tc.prReview.files)) + err := tc.Forge.CreateReviewComments(ctx, owner, repo, number, headSHA, review) + if err == nil || len(review.Comments) == 0 { + return err + } tc.Log.Warn("forge refused inline review comments; posting them in the body", "err", err, "inline", places) if retry := tc.Forge.CreateReviewComments(ctx, owner, repo, number, headSHA, forgeReview(findings, nil)); retry != nil { return fmt.Errorf("%w (inline at %s); without inline comments: %w", err, strings.Join(places, ", "), retry)