From bec374aa92b27d71db5402a1599d6b16393ed6c2 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Fri, 6 Nov 2026 21:30:33 +1100 Subject: [PATCH] ci(quality): stop installing ripgrep and setting sysctl from the gate (#1710) The check job now runs on the archie-quality self-hosted runner under an unprivileged user, so the sudo apt-get install and sudo sysctl steps fail, exactly as the deploy gate did before 3b372b4a. Both are host provisioning: ripgrep is installed on the runner host and the userns restriction belongs in sysctl.d. The namespace check stays, without sudo. --- .github/workflows/quality.yml | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml index 13c825e1b..5ef8b339b 100644 --- a/.github/workflows/quality.yml +++ b/.github/workflows/quality.yml @@ -20,12 +20,11 @@ jobs: with: fetch-depth: 0 - - name: Verify extension namespace support - run: | - if [ -e /proc/sys/kernel/apparmor_restrict_unprivileged_userns ]; then - sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 - fi - unshare --user --map-root-user --net true + # ripgrep and the unprivileged-userns sysctl are provisioned on the host. + # A self-hosted runner should not need sudo, and installing a package on + # every run is not the gate's job. + - name: Verify unprivileged user namespaces + run: unshare --user --map-root-user --net true - uses: actions/setup-go@v5 with: @@ -46,9 +45,6 @@ jobs: go install mvdan.cc/gofumpt@v0.11.0 bash tools/proto.sh install - sudo apt-get update - sudo apt-get install -y --no-install-recommends ripgrep - - name: Ensure contract baseline ref run: | if ! git show-ref --verify --quiet refs/heads/main; then