From a73a33a9979a18bbd2e96902dd218bac9fa39235 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Tue, 22 Sep 2026 03:38:49 +1000 Subject: [PATCH] docs(prds): correct the PR review PRD's stale owner and file list Section 1 attributed the PullRequestReader type-assertion to the daemon while section 4 now correctly says the Gateway serves review_pr, and the Files list cited internal/app/archied/telegram_setup.go, which does not exist. Both found by the cp-gwreview lane and left by it as out-of-scope staleness. --- docs/prds/operator-pr-review.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/prds/operator-pr-review.md b/docs/prds/operator-pr-review.md index c83337468..b5d17e962 100644 --- a/docs/prds/operator-pr-review.md +++ b/docs/prds/operator-pr-review.md @@ -31,7 +31,7 @@ planner/builder. forge-neutral `PullRequest{Number, Title, Body, HeadRef, BaseRef, HeadSHA, BaseSHA, State}`. Declared as a narrow `PullRequestReader` interface, implemented by GitHub and Gitea; the noop forge does not implement it, so - the daemon type-asserts and refuses review with "forge does not support PR + the composition root type-asserts and refuses review with "forge does not support PR review". Adding to the fat `Forge` interface would churn every test fake for a capability the noop forge cannot honestly provide. @@ -74,7 +74,7 @@ planner/builder. - `internal/gateway/review_tools.go` — `ChatPRReviewer`, result shape, `review_pr`. - `internal/gateway/turn.go`, `gateway.go` — tool wiring into the turn. - `internal/app/archied/pr_review.go` — the `ChatPRReviewer` adapter. -- `internal/app/archied/{bootstrap.go,main.go,telegram_setup.go}` — composition. +- `internal/app/archied/{bootstrap.go,gateway.go,main.go}` — composition. ## Not in scope