fix(ui): empty states wait for the first read to settle (#1742)
Skills, curators, QuickTask's workflow list, the alerts bell and the extensions catalogue now show a loading state until the first read settles, then the data, the error, or the empty state. Draft-backed lists (agent profiles, playbooks, credential bindings) show their empty state only once the draft exists, not beside the load error.
This commit is contained in:
10 files changed
+28
-7
No files matched your search
@@ -13,7 +13,7 @@ import { Timestamp } from "@/components/ui/timestamp";
|
||||
import { groupBySeverity, type AlertSeverity, type OperatorAlert } from "./alerts";
|
||||
import { useAlerts } from "./use-alerts";
|
||||
|
||||
const { alerts, failed, dismissError, dismiss, dismissAll } = useAlerts();
|
||||
const { alerts, failed, loaded, dismissError, dismiss, dismissAll } = useAlerts();
|
||||
const open = ref(false);
|
||||
|
||||
const groups = computed(() => groupBySeverity(alerts.value));
|
||||
@@ -44,6 +44,7 @@ function failedDeliveries(alert: OperatorAlert): number {
|
||||
<PopoverContent align="end" :collision-padding="8" class="w-[calc(100vw-1rem)] max-w-none p-0 sm:w-96">
|
||||
<Alert v-if="failed" variant="destructive" class="px-3 py-6 text-center"><AlertDescription>Alerts could not be loaded.</AlertDescription></Alert>
|
||||
<Alert v-if="dismissError" variant="destructive" class="px-3 py-2"><AlertDescription>Dismiss failed: {{ dismissError }}</AlertDescription></Alert>
|
||||
<p v-else-if="!loaded" class="px-3 py-6 text-center text-label text-fg-muted" role="status">Loading alerts…</p>
|
||||
<Empty v-else-if="!groups.length" class="border-0"><EmptyHeader><EmptyTitle>No alerts</EmptyTitle></EmptyHeader></Empty>
|
||||
<div v-else class="relative max-h-[calc(100dvh-6rem)] overflow-y-auto">
|
||||
<Tooltip>
|
||||
|
||||
@@ -15,6 +15,7 @@ import type { OperatorAlert } from "./alerts";
|
||||
*/
|
||||
const alerts = ref<OperatorAlert[]>([]);
|
||||
const failed = ref(false);
|
||||
const loaded = ref(false);
|
||||
const dismissError = ref("");
|
||||
// Loads overlap when alert events arrive close together; only the newest
|
||||
// may land, or an older list overwrites a newer one.
|
||||
@@ -30,6 +31,8 @@ async function load() {
|
||||
failed.value = false;
|
||||
} catch {
|
||||
if (seq === latest) failed.value = true;
|
||||
} finally {
|
||||
if (seq === latest) loaded.value = true;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -67,5 +70,5 @@ export function useAlerts() {
|
||||
watch(connectionRevision, load);
|
||||
onMounted(load);
|
||||
}
|
||||
return { alerts, failed, dismissError, dismiss, dismissAll };
|
||||
return { alerts, failed, loaded, dismissError, dismiss, dismissAll };
|
||||
}
|
||||
@@ -67,6 +67,7 @@ const configuredProviderIds = computed(() =>
|
||||
const modelOptions = computed(() => aliasModelOptions(modelCatalog.value, configuredProviderIds.value));
|
||||
watch(() => store.applyStatusFor(KIND).map(row => row.version).join(","), () => void load());
|
||||
const curators = ref<Curator[]>([]);
|
||||
const curatorsLoaded = ref(false);
|
||||
const loadError = ref<string | null>(null);
|
||||
|
||||
let loadGeneration = 0;
|
||||
@@ -80,6 +81,8 @@ async function load() {
|
||||
} catch (err) {
|
||||
if (current !== loadGeneration) return;
|
||||
loadError.value = String((err as Error).message || err);
|
||||
} finally {
|
||||
if (current === loadGeneration) curatorsLoaded.value = true;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -217,7 +220,7 @@ onMounted(load);
|
||||
<EmptyDescription>{{ loadError }}</EmptyDescription>
|
||||
</EmptyHeader>
|
||||
</Empty>
|
||||
<Empty v-else-if="!curators.length">
|
||||
<Empty v-else-if="curatorsLoaded && !curators.length">
|
||||
<EmptyHeader>
|
||||
<EmptyTitle>No curators registered</EmptyTitle>
|
||||
</EmptyHeader>
|
||||
|
||||
@@ -23,6 +23,7 @@ const router = useRouter();
|
||||
const prompt = ref("");
|
||||
const workflow = ref("");
|
||||
const definitions = ref<WorkflowDefinition[]>([]);
|
||||
const loaded = ref(false);
|
||||
const loadError = ref("");
|
||||
const error = ref("");
|
||||
const submitting = ref(false);
|
||||
@@ -35,6 +36,8 @@ onMounted(async () => {
|
||||
workflow.value ||= definitions.value[0]?.id ?? "";
|
||||
} catch (err) {
|
||||
loadError.value = String((err as Error).message || err);
|
||||
} finally {
|
||||
loaded.value = true;
|
||||
}
|
||||
});
|
||||
|
||||
@@ -90,6 +93,7 @@ async function run() {
|
||||
<Button type="submit" :disabled="!prompt.trim() || !workflow || submitting"><Spinner v-if="submitting" data-icon="inline-start" />Run</Button>
|
||||
</div>
|
||||
<Alert v-if="loadError || error" variant="destructive"><AlertDescription>{{ loadError || error }}</AlertDescription></Alert>
|
||||
<p v-else-if="!loaded" class="text-caption text-fg-subtle" role="status">Loading workflows…</p>
|
||||
<p v-else-if="!definitions.length" class="text-caption text-fg-subtle">
|
||||
No enabled workflows. <RouterLink to="/workflows" class="underline">Enable one</RouterLink>
|
||||
</p>
|
||||
|
||||
@@ -51,7 +51,7 @@ function patch(key: string, changes: Partial<Profile>) {
|
||||
<Input v-model="name" aria-label="Profile name" placeholder="Profile name" class="max-w-xs" :disabled="unsaved" />
|
||||
<Button type="submit" :disabled="unsaved || !name.trim() || !!profiles?.[name.trim()]">Add profile</Button>
|
||||
</form>
|
||||
<Empty v-if="!Object.keys(profiles ?? {}).length"><EmptyHeader><EmptyTitle>No agent profiles</EmptyTitle></EmptyHeader></Empty>
|
||||
<Empty v-if="profiles && !Object.keys(profiles).length"><EmptyHeader><EmptyTitle>No agent profiles</EmptyTitle></EmptyHeader></Empty>
|
||||
<CardAccordion v-model:open="open" :items="entries" :title="([key]) => key" remove-label="Remove" mono @remove="removeProfile">
|
||||
<template #default="{ item: [key, profile] }">
|
||||
<FieldGroup class="@container/field-group">
|
||||
|
||||
@@ -51,7 +51,7 @@ function patch(index: number, changes: Partial<Binding>) {
|
||||
<PageHeader title="Credential bindings"><HistoryLink :kinds="[KIND]" /><Button :disabled="unsaved" @click="add">Add binding</Button></PageHeader>
|
||||
<ApplyStatusRows :kind="KIND" class="mb-4" />
|
||||
<Alert v-if="store.catalogError || store.pageErrorFor(KIND)" variant="destructive" class="mb-4"><AlertDescription>{{ store.catalogError || store.pageErrorFor(KIND) }}</AlertDescription></Alert>
|
||||
<Empty v-if="!bindings?.length"><EmptyHeader><EmptyTitle>No credential bindings</EmptyTitle></EmptyHeader></Empty>
|
||||
<Empty v-if="bindings && !bindings.length"><EmptyHeader><EmptyTitle>No credential bindings</EmptyTitle></EmptyHeader></Empty>
|
||||
<CardAccordion v-model:open="open" :items="bindings ?? []" :title="(b) => b.service || 'New binding'" remove-label="Remove" mono @remove="remove">
|
||||
<template #default="{ item: binding, index }">
|
||||
<FieldGroup class="@container/field-group">
|
||||
|
||||
@@ -96,7 +96,8 @@ const groups = computed(() => {
|
||||
</ul>
|
||||
</section>
|
||||
|
||||
<Empty v-if="!groups.length" class="py-6">
|
||||
<p v-if="!store.catalogueLoaded && !store.catalogueError" class="py-6 text-center text-label text-fg-muted" role="status">Loading catalogue…</p>
|
||||
<Empty v-else-if="!groups.length" class="py-6">
|
||||
<EmptyHeader>
|
||||
<EmptyTitle>{{ store.catalogue.length ? "No extensions match" : "The catalogue is empty" }}</EmptyTitle>
|
||||
</EmptyHeader>
|
||||
|
||||
@@ -41,7 +41,7 @@ function remove(index: number) {
|
||||
<ApplyStatusRows :kind="KIND" class="mb-4" />
|
||||
<Alert v-if="store.catalogError || store.pageErrorFor(KIND)" variant="destructive" class="mb-4"><AlertDescription>{{ store.catalogError || store.pageErrorFor(KIND) }}</AlertDescription></Alert>
|
||||
<form class="mb-4 flex flex-wrap gap-2" @submit.prevent="add"><Input v-model="id" aria-label="Playbook ID" placeholder="Playbook ID" class="max-w-xs" :disabled="unsaved" /><Button type="submit" :disabled="unsaved || !id.trim() || collection?.playbooks.some(entry => entry.id === id.trim())">Add playbook</Button></form>
|
||||
<Empty v-if="!collection?.playbooks.length"><EmptyHeader><EmptyTitle>No playbooks installed</EmptyTitle></EmptyHeader></Empty>
|
||||
<Empty v-if="collection && !collection.playbooks.length"><EmptyHeader><EmptyTitle>No playbooks installed</EmptyTitle></EmptyHeader></Empty>
|
||||
<CardAccordion v-model:open="open" :items="collection?.playbooks ?? []" :title="(entry) => entry.id" remove-label="Remove" mono @remove="remove">
|
||||
<template #default="{ item: entry, index }">
|
||||
<form.Field v-if="form" v-slot="{ field }" :name="`playbooks[${index}].yaml`">
|
||||
|
||||
@@ -5,6 +5,7 @@ import { computed, onMounted, ref } from "vue";
|
||||
|
||||
import PageHeader from "@/base/PageHeader.vue";
|
||||
import { Section } from "@/components/ui/section";
|
||||
import { Skeleton } from "@/components/ui/skeleton";
|
||||
import {
|
||||
Empty,
|
||||
EmptyDescription,
|
||||
@@ -17,6 +18,7 @@ import { useLiveResource } from "@/stores/session";
|
||||
import SkillCard, { type Skill } from "./SkillCard.vue";
|
||||
|
||||
const skills = ref<Skill[]>([]);
|
||||
const loaded = ref(false);
|
||||
const search = ref("");
|
||||
const loadError = ref<string | null>(null);
|
||||
|
||||
@@ -31,6 +33,8 @@ async function load() {
|
||||
} catch (err) {
|
||||
if (current !== loadGeneration) return;
|
||||
loadError.value = String((err as Error).message || err);
|
||||
} finally {
|
||||
if (current === loadGeneration) loaded.value = true;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -71,6 +75,7 @@ const filtered = computed(() => {
|
||||
<EmptyDescription>{{ loadError }}</EmptyDescription>
|
||||
</EmptyHeader>
|
||||
</Empty>
|
||||
<div v-else-if="!loaded" role="status" aria-label="Loading skills" class="space-y-2 py-4"><Skeleton class="h-16 w-full" /><Skeleton class="h-16 w-full" /></div>
|
||||
<Empty v-else-if="!skills.length">
|
||||
<EmptyHeader>
|
||||
<EmptyTitle>No skills discovered yet</EmptyTitle>
|
||||
|
||||
@@ -78,6 +78,7 @@ export const useExtensionsStore = defineStore("extensions", () => {
|
||||
const extensions = ref<Extension[]>([]);
|
||||
const catalogue = ref<CatalogueEntry[]>([]);
|
||||
const catalogueError = ref("");
|
||||
const catalogueLoaded = ref(false);
|
||||
const error = ref("");
|
||||
const busy = ref("");
|
||||
|
||||
@@ -97,6 +98,8 @@ export const useExtensionsStore = defineStore("extensions", () => {
|
||||
catalogueError.value = "";
|
||||
} catch (cause) {
|
||||
catalogueError.value = String((cause as Error).message || cause);
|
||||
} finally {
|
||||
catalogueLoaded.value = true;
|
||||
}
|
||||
}
|
||||
async function mutate(key: string, action: () => Promise<unknown>): Promise<boolean> {
|
||||
@@ -119,6 +122,7 @@ export const useExtensionsStore = defineStore("extensions", () => {
|
||||
}
|
||||
const path = (name: string) => `/api/extensions/${encodeURIComponent(name)}`;
|
||||
return {
|
||||
catalogueLoaded,
|
||||
forges,
|
||||
forgeName,
|
||||
extensions,
|
||||
|
||||
Reference in new issue
Block a user