fix(taskactions): abandon leaves the forge issue open

This commit is contained in:
sam committed 2026-09-25 08:59:54 +10:00
1 parent 07d5a7a3cc
commit 81862273c0
7 files changed
+41 -10

No files matched your search

+6 -4
View File
@@ -251,12 +251,14 @@ func (s Service) applyStop(ctx context.Context, task *Task, actor Actor, o outco
}
func (s Service) applyCancelOrAbandon(ctx context.Context, task *Task, action taskstate.Action, actor Actor, o outcome) (outcome, error) {
from, kind, verb := "queued", events.KindTaskCancelled, "cancelled"
if action == taskstate.ActionAbandon {
from, kind, verb = "parked", events.KindTaskAbandoned, "abandoned"
// Abandoning ends archie's run, not the issue: no verb, so the issue
// stays open for a human.
o.event.Kind, o.event.Detail = events.KindTaskAbandoned, actor.describe("abandoned")
return o, s.Store.Transition(ctx, task.ID, "parked", "closed_wont_do", o.event.Detail)
}
o.event.Kind, o.event.Detail, o.verb = kind, actor.describe(verb), verb
return o, s.Store.Transition(ctx, task.ID, from, "closed_wont_do", o.event.Detail)
o.event.Kind, o.event.Detail, o.verb = events.KindTaskCancelled, actor.describe("cancelled"), "cancelled"
return o, s.Store.Transition(ctx, task.ID, "queued", "closed_wont_do", o.event.Detail)
}
func (s Service) applyArchive(ctx context.Context, task *Task, actor Actor, o outcome) (outcome, error) {
@@ -209,3 +209,32 @@ func TestActorForCarriesTheKindAndLeavesTheActionUnattributedWithoutAPrincipal(t
t.Fatal("the zero Actor reported itself as a human")
}
}
// TestOnlyRejectAndCancelCloseTheIssue: abandoning is archie giving up on its
// own run, not a verdict on the issue, so the issue stays open for a human.
func TestOnlyRejectAndCancelCloseTheIssue(t *testing.T) {
for _, tc := range []struct {
action taskstate.Action
status string
closes bool
}{
{taskstate.ActionReject, "waiting_human", true},
{taskstate.ActionCancel, "queued", true},
{taskstate.ActionAbandon, "parked", false},
} {
t.Run(string(tc.action), func(t *testing.T) {
store := &fakeStore{task: &Task{ID: 7, Owner: "acme", Repo: "widgets", Status: tc.status, ForgeBacked: true}}
closed := false
service := Service{Store: store, CloseIssue: func(context.Context, string, string, int, string) error {
closed = true
return nil
}}
if err := service.Apply(context.Background(), nil, agentActor(), 7, tc.action); err != nil {
t.Fatalf("Apply(%s) error = %v", tc.action, err)
}
if closed != tc.closes {
t.Fatalf("Apply(%s) closed the issue = %v, want %v", tc.action, closed, tc.closes)
}
})
}
}
+1 -1
View File
@@ -193,7 +193,7 @@ func ActionCatalog() []ActionMeta {
{ID: string(ActionApprove), Label: "Approve", Kind: "primary"},
{ID: string(ActionReject), Label: "Reject", Kind: "quiet", Confirm: `Reject "{title}"? This closes the forge issue.`},
{ID: string(ActionRetry), Label: "Retry", Kind: "primary"},
{ID: string(ActionAbandon), Label: "Abandon", Kind: "quiet", Confirm: `Abandon "{title}"? This closes the forge issue.`},
{ID: string(ActionAbandon), Label: "Abandon", Kind: "quiet", Confirm: `Abandon "{title}"? Archie stops working on it; the forge issue stays open.`},
{ID: string(ActionArchive), Label: "Archive", Kind: "quiet", Confirm: `Archive the local record for "{title}"?`},
{ID: string(ActionOpenPR), Label: "Open PR", Kind: "link"},
{ID: string(ActionOpenIssue), Label: "Open issue", Kind: "link"},
+1 -1
View File
@@ -601,7 +601,7 @@ func TestLifecycleSpecificTaskActions(t *testing.T) {
{name: "cancel queued", from: workflow.StatusQueued, action: "cancel", want: workflow.StatusClosedWontDo, closesIssue: true},
{name: "stop running", from: workflow.StatusRunning, action: "stop", want: workflow.StatusParked, stopperResult: true},
{name: "park stale running row", from: workflow.StatusRunning, action: "stop", want: workflow.StatusParked},
{name: "abandon parked", from: workflow.StatusParked, action: "abandon", want: workflow.StatusClosedWontDo, closesIssue: true},
{name: "abandon parked", from: workflow.StatusParked, action: "abandon", want: workflow.StatusClosedWontDo, closesIssue: false},
// Reject is available from every non-terminal state and always lands in
// the terminal Declined state, closing the forge issue.
{name: "reject queued", from: workflow.StatusQueued, action: "reject", want: workflow.StatusClosedWontDo, closesIssue: true},
+2 -2
View File
@@ -16,5 +16,5 @@ Defaulting to \`null\`.`),null)}function jx(e){return kx(e)&&!Number.isNaN(e)&&e
`),r=[],i=null,a=null,o=()=>{r.length&&(t.push({kind:`p`,inline:pT(r.join(` `))}),r=[])},s=()=>{i&&=(t.push({kind:i.tag,items:i.items.map(e=>pT(e))}),null)};for(let e=0;e<n.length;e++){let c=n[e];if(c.startsWith("```")){o(),s(),a?(t.push({kind:`pre`,code:a.join(`
`)}),a=null):a=[];continue}if(a){a.push(c);continue}let l=hT(c),u=e+1<n.length?hT(n[e+1]):null;if(l&&u&&gT(u)&&l.length===u.length){o(),s();let r=[];for(e+=2;e<n.length;e++){let t=hT(n[e]);if(!t||t.length!==l.length){e--;break}r.push(t)}t.push({kind:`table`,head:l.map(e=>pT(e)),rows:r.map(e=>e.map(e=>pT(e)))});continue}if(!c.trim()){o(),s();continue}let d=c.match(/^(#{1,3})\s+(.+)$/);if(d){o(),s(),t.push({kind:`h${d[1].length}`,inline:pT(d[2])});continue}let f=c.match(/^\s*[-*]\s+(.+)$/),p=c.match(/^\s*\d+[.)]\s+(.+)$/);if(f||p){o();let e=p?`ol`:`ul`;(!i||i.tag!==e)&&(s(),i={tag:e,items:[]}),i.items.push((f||p)[1]);continue}if(c.startsWith(`>`)){o(),s(),t.push({kind:`blockquote`,inline:pT(c.replace(/^>\s?/,``))});continue}r.push(c)}return o(),s(),a&&t.push({kind:`pre`,code:a.join(`
`)}),t}function hT(e){let t=String(e||``).trim();if(!t.includes(`|`))return null;let n=t.replace(/^\|/,``).replace(/\|$/,``).split(`|`).map(e=>e.trim());return n.length>1&&n.every(e=>e!==``)?n:null}function gT(e){return e.every(e=>/^:?-{3,}:?$/.test(e))}var _T={class:`[overflow-wrap:anywhere]`},vT={key:0,class:`my-2 overflow-auto rounded-md border border-border bg-background/60 p-3`},yT={class:`font-mono text-[0.85em]`},bT={key:1,class:`my-3 w-full border-collapse text-[0.92em]`},xT={key:2,class:`my-2 border-l-[3px] border-primary pl-3 text-fg-muted`},ST={key:3,class:`mt-1 mb-2 text-xl leading-tight font-semibold tracking-[-0.02em]`},CT={key:4,class:`mt-1 mb-2 text-lg leading-tight font-semibold tracking-[-0.02em]`},wT={key:5,class:`mt-1 mb-2 text-base leading-tight font-semibold tracking-[-0.02em]`},TT={key:6,class:`my-2.5 flex list-disc flex-col gap-1 pl-5`},ET={key:7,class:`my-2.5 flex list-decimal flex-col gap-1 pl-5`},DT={key:8,class:`mb-2.5 last:mb-0`},OT=j({__name:`ChatMarkdown`,props:{text:{}},setup(e){let t=e,n=U(()=>mT(t.text));return(e,t)=>(F(),I(`div`,_T,[(F(!0),I(P,null,M(n.value,(e,t)=>(F(),I(P,{key:t},[e.kind===`pre`?(F(),I(`pre`,vT,[R(`code`,yT,E(e.code),1)])):e.kind===`table`?(F(),I(`table`,bT,[R(`thead`,null,[R(`tr`,null,[(F(!0),I(P,null,M(e.head,(e,t)=>(F(),I(`th`,{key:t,class:`border border-border bg-muted px-2 py-1.5 text-left font-semibold`},[z(dT,{inline:e},null,8,[`inline`])]))),128))])]),R(`tbody`,null,[(F(!0),I(P,null,M(e.rows,(e,t)=>(F(),I(`tr`,{key:t},[(F(!0),I(P,null,M(e,(e,t)=>(F(),I(`td`,{key:t,class:`border border-border px-2 py-1.5 text-left`},[z(dT,{inline:e},null,8,[`inline`])]))),128))]))),128))])])):e.kind===`blockquote`?(F(),I(`blockquote`,xT,[z(dT,{inline:e.inline},null,8,[`inline`])])):e.kind===`h1`?(F(),I(`h1`,ST,[z(dT,{inline:e.inline},null,8,[`inline`])])):e.kind===`h2`?(F(),I(`h2`,CT,[z(dT,{inline:e.inline},null,8,[`inline`])])):e.kind===`h3`?(F(),I(`h3`,wT,[z(dT,{inline:e.inline},null,8,[`inline`])])):e.kind===`ul`?(F(),I(`ul`,TT,[(F(!0),I(P,null,M(e.items,(e,t)=>(F(),I(`li`,{key:t},[z(dT,{inline:e},null,8,[`inline`])]))),128))])):e.kind===`ol`?(F(),I(`ol`,ET,[(F(!0),I(P,null,M(e.items,(e,t)=>(F(),I(`li`,{key:t},[z(dT,{inline:e},null,8,[`inline`])]))),128))])):e.kind===`p`?(F(),I(`p`,DT,[z(dT,{inline:e.inline},null,8,[`inline`])])):V(``,!0)],64))),128))]))}}),kT={class:`truncate`},AT=j({__name:`ChatNavChip`,props:{path:{},label:{}},setup(e){return(t,n)=>{let r=ha(`RouterLink`);return F(),L(r,{to:e.path,title:`Go to ${e.label||e.path}`,class:`inline-flex max-w-full items-center gap-1.5 rounded-full border border-primary/45 bg-primary-soft px-2.5 py-1 text-xs font-semibold text-link transition-colors hover:border-primary hover:bg-primary/15 focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-primary`},{default:k(()=>[z(O(bd),{"aria-hidden":`true`,class:`size-3.5 shrink-0`}),R(`span`,kT,E(e.label||e.path),1)]),_:1},8,[`to`,`title`])}}}),jT={key:1,class:`flex items-baseline gap-1.5 [overflow-wrap:anywhere]`},MT={class:`font-semibold text-foreground`},NT={key:0,class:`font-mono text-[0.95em] text-fg-subtle`},PT=j({__name:`ChatToolCall`,props:{tool:{},streaming:{type:Boolean}},setup(e){let t=e,n=U(()=>t.tool.name||t.tool.Name||t.tool.tool||`tool`),r=U(()=>t.tool.parameters||t.tool.Parameters||``),i=U(()=>!!(t.tool.err||t.tool.Err||t.tool.failed)),a=U(()=>t.tool.summary||t.tool.Summary||t.tool.text||t.tool.err||t.tool.Err||(t.streaming?i.value?`failed`:`running…`:`done`));return(t,o)=>e.tool.path?(F(),L(AT,{key:0,path:e.tool.path,label:e.tool.label},null,8,[`path`,`label`])):(F(),I(`div`,jT,[z(O($d),{"aria-hidden":`true`,class:`size-3.5 shrink-0 self-center text-fg-subtle`}),R(`span`,MT,E(n.value),1),r.value?(F(),I(`code`,NT,E(r.value),1)):V(``,!0),R(`span`,{class:T(O(K)(`text-fg-muted`,i.value&&`text-danger`))},E(a.value),3)]))}}),FT={key:0,class:`mb-2 grid gap-0.5 text-xs`},IT={key:2,class:`whitespace-pre-wrap`},LT=j({__name:`ChatBubble`,props:{text:{},tools:{default:()=>[]},assistant:{type:Boolean,default:!1},streaming:{type:Boolean,default:!1}},setup(e){return(t,n)=>(F(),I(`div`,{class:T([`flex`,e.assistant?`justify-start`:`justify-end`])},[R(`div`,{class:T(O(K)(`max-w-[min(78ch,86%)] rounded-[0.85rem] px-4 py-3 leading-normal [overflow-wrap:anywhere]`,e.assistant?`bg-muted`:`bg-primary/15`))},[e.assistant&&e.tools.length?(F(),I(`div`,FT,[(F(!0),I(P,null,M(e.tools,(t,n)=>(F(),L(PT,{key:n,tool:t,streaming:e.streaming},null,8,[`tool`,`streaming`]))),128))])):V(``,!0),e.assistant?(F(),L(OT,{key:1,text:e.text},null,8,[`text`])):(F(),I(`div`,IT,E(e.text),1)),N(t.$slots,`default`)],2)],2))}}),RT={class:`w-full self-center justify-self-center py-6 text-center`},zT={class:`grid gap-2`},BT=[`onClick`],VT=j({__name:`ChatEmptyState`,emits:[`prompt`],setup(e,{emit:t}){let n=t,r=[`Summarise active tasks`,`Show running agents`,`Check system status`];return(e,t)=>(F(),I(`div`,RT,[t[0]||=R(`span`,{"aria-hidden":`true`,class:`mx-auto mb-3 grid size-9 placLine truncated
`).map(e=>e.trim()).find(Boolean)||``,r=n.length>uA?`${n.slice(0,uA).trimEnd()}…`:n;return{text:r,full:t,truncated:r!==t}}var fA=[`title`],pA=j({__name:`ActivityRow`,props:{event:{}},emits:[`open`],setup(e,{emit:t}){let n=e,r=t,i=U(()=>Rk(n.event)),a=U(()=>dA(n.event));function o(){i.value>0&&r(`open`,i.value)}let s=U(()=>n.event.at?kO(n.event.at):`—`);return(e,t)=>(F(),L(O(cA),{class:T(i.value>0?`cursor-pointer`:``),role:i.value>0?`link`:void 0,tabindex:i.value>0?0:void 0,title:i.value>0?`Open task details`:void 0,onClick:o,onKeydown:[fu(uu(o,[`prevent`]),[`enter`]),fu(uu(o,[`prevent`]),[`space`])]},{default:k(()=>[z(O(Q),{class:`font-medium`},{default:k(()=>[B(E(n.event.kind||n.event.type||`event`),1)]),_:1}),z(O(Q),{class:`font-mono`},{default:k(()=>[B(E(i.value>0?`#${i.value}`:`—`),1)]),_:1}),z(O(Q),{class:`w-[55%] max-w-0`},{default:k(()=>[R(`span`,{class:`block truncate`,title:a.value.truncated?a.value.full:void 0},E(a.value.text),9,fA)]),_:1}),z(O(Q),null,{default:k(()=>[B(E(s.value),1)]),_:1})]),_:1},8,[`class`,`role`,`tabindex`,`title`,`onKeydown`]))}});function mA(e,t){return`${e}:${t??0}`}function hA(e){let t=[];for(let n of e){let e=n.kind||n.type||`event`,r=Number(n.task_id)||0,i=mA(dA(n).text,r),a=t[t.length-1];if(a&&a.key===i){a.count+=1,a.events.push(n);continue}t.push({key:i,label:e,taskID:r,count:1,representative:n,events:[n]})}return t}var gA={role:`region`,"aria-label":`Live activity`,"aria-live":`polite`},_A={class:`max-h-[28rem] overflow-y-auto`},vA=[`aria-expanded`,`aria-label`,`onClick`],yA=[`title`],bA=j({__name:`LiveActivityCard`,setup(e){let t=uE(),{activity:n,streamKind:r,streamState:i}=od(dk()),a=rn(new Set),o=U(()=>hA(n.value));function s(e){a.has(e)?a.delete(e):a.add(e)}function c(e){return a.has(e.key)}function l(e){return dA(e.representative)}function u(e){return e.representative.at?kO(e.representative.at):`—`}function d(e){t.push(`/tasks?task=${encodeURIComponent(e)}`)}return(e,t)=>(F(),L(O(xO),null,{default:k(()=>[z(O(EO),null,{default:k(()=>[z(O(DO),null,{default:k(()=>[...t[0]||=[B(`Live activity`,-1)]]),_:1}),z(O(SO),null,{default:k(()=>[z(O(sO),{variant:O(r)},{default:k(()=>[B(E(O(i)),1)]),_:1},8,[`variant`])]),_:1})]),_:1}),z(O(CO),null,{default:k(()=>[R(`div`,gA,[R(`div`,_A,[z(O(oA),null,{default:k(()=>[z(O(lA),{class:`sticky top-0 z-10 bg-card`},{default:k(()=>[z(O(cA),null,{default:k(()=>[z(O($),null,{default:k(()=>[...t[1]||=[B(`Event`,-1)]]),_:1}),z(O($),null,{default:k(()=>[...t[2]||=[B(`Task`,-1)]]),_:1}),z(O($),null,{default:k(()=>[...t[3]||=[B(`Detail`,-1)]]),_:1}),z(O($),null,{default:k(()=>[...t[4]||=[B(`When`,-1)]]),_:1})]),_:1})]),_:1}),z(O(sA),null,{default:k(()=>[O(n).length?V(``,!0):(F(),L(O(cA),{key:0},{default:k(()=>[z(O(Q),{colspan:`4`},{default:k(()=>[z(O($D),null,{default:k(()=>[z(O(nO),null,{default:k(()=>[z(O(aO),null,{default:k(()=>[...t[5]||=[B(`Waiting for activity`,-1)]]),_:1})]),_:1})]),_:1})]),_:1})]),_:1})),O(n).length?(F(!0),I(P,{key:1},M(o.value,e=>(F(),I(P,{key:e.key},[e.count===1?(F(),L(pA,{key:0,event:e.representative,onOpen:d},null,8,[`event`])):(F(),I(P,{key:1},[z(O(cA),{class:T(e.taskID>0?`cursor-pointer`:``),role:e.taskID>0?`link`:void 0,tabindex:e.taskID>0?0:void 0,title:e.taskID>0?`Open task details`:void 0,onClick:t=>e.taskID>0&&d(e.taskID),onKeydown:[fu(uu(t=>e.taskID>0&&d(e.taskID),[`prevent`]),[`enter`]),fu(uu(t=>e.taskID>0&&d(e.taskID),[`prevent`]),[`space`])]},{default:k(()=>[z(O(Q),{class:`font-medium`},{default:k(()=>[R(`button`,{type:`button`,class:`inline-flex items-center gap-1 rounded hover:opacity-80`,"aria-expanded":c(e),"aria-label":`${c(e)?`Hide`:`Show`} ${e.count} ${e.label} events`,onClick:uu(t=>s(e.key),[`stop`])},[c(e)?(F(),L(O(Sd),{key:0,class:`size-3.5 shrink-0 text-fg-subtle`})):(F(),L(O(wd),{key:1,class:`size-3.5 shrink-0 text-fg-subtle`})),B(` `+E(e.label)+` `,1),z(O(sO),{variant:`idle`},{default:k(()=>[B(`×`+E(e.count),1)]),_:2},1024)],8,vA)]),_:2},1024),z(O(Q),{class:`font-mono`},{default:k(()=>[B(E(e.taskID>0?`#${e.taskID}`:`—`),1)]),_:2},1024),z(O(Q),{class:`w-[55%] max-w-0`},{default:k(()=>[R(`span`,{class:`block truncate`,title:l(e).truncated?l(e).full:void 0},E(l(e).text),9,yA)]),_:2},1024),z(O(Q),null,{default:k(()=>[B(E(u(e)),1)]),_:2},1024)]),_:2},1032,[`class`,`role`,`tabindex`,`title`,`onClick`,`onKeydown`]),c(e)?(F(!0),I(P,{key:0},M(e.events,(t,n)=>(F(),L(pA,{key:`${e.key}:${n}`,event:t,onOpen:d},null,8,[`event`]))),128)):V(``,!0)],64))],64))),128)):V(``,!0)]),_:1})]),_:1})])])]),_:1})]),_:1}))}}),xA=j({__name:`Progress`,props:{modelValue:{default:0},max:{},getValueLabel:{},getValueText:{},asChild:{type:Boolean},as:{},class:{type:[Boolean,null,String,Object,Array]}},setup(e){let t=e,n=oC(t,`class`);return(e,r)=>(F(),L(O(Mx),H({"data-slot":`progress`},O(n),{class:O(K)(`bg-muted h-1 rounded-full relative flex w-full items-center overflow-x-hidden`,t.class)}),{default:k(()=>[z(O(Nx),{"data-slot":`progress-indicator`,class:`bg-primary size-full flex-1 transition-all`,style:ye(`transLine truncated
`)){let e=n.indexOf(`:`);if(e<=0)continue;let r=n.slice(0,e).trim();r&&(t[r]=n.slice(e+1).trim())}return t}function Zj(e,t){if(!e.event_type)return{label:`Unidentified`,identified:!1};let n=t.find(t=>t.id===e.event_type);return{label:n?n.name:`Deleted type`,identified:!0}}function Qj(e,t){if(!e)return`No event type`;let n=t.find(t=>t.id===e);return n?`${n.source} / ${n.name}`:`Deleted type`}function $j(e){let t=[...(e.headers||[]).map(e=>`${e.name} = ${e.value}`),...(e.payload||[]).map(e=>e.op===`present`?`${e.path} present`:`${e.path} = ${e.value??``}`)];return t.length?t.join(` · `):`any event`}function eM(e){return{headers:(e.headers||[]).filter(e=>e.name.trim()!==``).map(e=>({name:e.name.trim(),value:e.value})),payload:(e.payload||[]).filter(e=>e.path.trim()!==``).map(e=>e.op===`present`?{path:e.path.trim(),op:e.op}:{path:e.path.trim(),op:e.op,value:e.value??``})}}function tM(e,t){return t?e.filter(e=>e.event_type_id===t):[]}function nM(e){return(e?.repository??`required`)!==`none`}function rM(e,t){return e.filter(e=>t===`any`||e.type===`any`||e.type===t)}function iM(e,t){switch(t){case`string`:return e;case`number`:return e.trim()!==``&&!Number.isNaN(Number(e))?Number(e):e;case`bool`:return e===`true`||e!==`false`&&e;default:try{return JSON.parse(e)}catch{return e}}}var aM={pending_approval:`pending approval`,armed:`armed`},oM={pending_approval:`warn`,armed:`ok`};function sM(e){return e?aM[e]??e:`unknown`}function cM(e){return oM[e??``]??`idle`}function lM(){return{id:null,name:``,eventTypeId:``,mappingId:``,filter:``,workflow:``,owner:``,repo:``,repoParam:``,inputs:{}}}function uM(e,t){let n=t.find(t=>t.id===e.mapping_id);return{id:e.id,name:e.name,eventTypeId:n?.event_type_id||``,mappingId:e.mapping_id||``,filter:e.filter||``,workflow:e.workflow||``,owner:e.owner||``,repo:e.repo||``,repoParam:e.repo_param||``,inputs:Object.fromEntries(Object.entries(e.inputs??{}).map(([e,t])=>[e,{param:t.param??``,value:t.param?``:typeof t.value==`string`?t.value:JSON.stringify(t.value)}]))}}function dM(e,t,n){let r=t.find(t=>t.id===e.eventTypeId),i=n?.inputs??{},a={};for(let[t,n]of Object.entries(i)){let r=e.inputs[t];r?.param?a[t]={param:r.param}:r&&r.value!==``&&(a[t]={value:iM(r.value,n.type)})}let o=nM(n);return{name:e.name,matcher:{source:r?.source||``},mapping_id:e.mappingId,filter:e.filter.trim(),workflow:e.workflow,owner:o&&!e.repoParam?e.owner:``,repo:o&&!e.repoParam?e.repo:``,repo_param:o?e.repoParam:``,inputs:a}}function fM(e){return e.repo_param?`from ${e.repo_param}`:e.owner&&e.repo?`${e.owner}/${e.repo}`:`—`}function pM(e,t){return t.find(t=>t.id===e.mapping_id)?.event_type_id}var mM={class:`font-mono`},hM={class:`text-fg-muted`},gM={class:`grid grid-cols-2 items-start gap-3`},_M={class:`grid grid-cols-2 items-start gap-3`},vM=`__constant__`,yM=`__none__`,bM=j({__name:`BindingEditor`,props:Va({binding:{},mappings:{},eventTypes:{},workflows:{},saving:{type:Boolean},error:{}},{open:{type:Boolean,required:!0},openModifiers:{}}),emits:Va([`save`],[`update:open`]),setup(e,{emit:t}){let n=e,r=lo(e,`open`),i=t,a=D(lM());A(r,e=>{e&&(a.value=n.binding?uM(n.binding,n.mappings):lM())},{immediate:!0});let o=U(()=>tM(n.mappings,a.value.eventTypeId));A(()=>a.value.eventTypeId,()=>{o.value.some(e=>e.id===a.value.mappingId)||(a.value.mappingId=``)});let s=U(()=>n.workflows.find(e=>e.id===a.value.workflow)),c=U(()=>Object.entries(s.value?.inputs??{}).sort(([e],[t])=>e.localeCompare(t))),l=U(()=>n.mappings.find(e=>e.id===a.value.mappingId)?.fields??[]),u=U(()=>rM(l.value,`string`));function d(e){return a.value.inputs[e]??={param:``,value:``},a.value.inputs[e]}function f(e){return d(e).param||vM}function p(e,t){d(e).param=t===vM?``:String(t)}let m=U({get:()=>a.value.repoParam||yM,set:e=>{a.value.repoParam=e===yM?``:e}}),h=U(()=>n.binding?`Edit binding`:`New binding`);return(e,t)=>(F(),L(O(Uj),{open:r.value,"onUpdate:open":t[10]||=e=>r.value=e},{default:k(()=>[z(O(Gj),{class:`max-h-[85vh] overflow-y-auto sm:max-w-lg`},{default:k(()=>[z(O(Jj),null,{default:k(()=>[z(O(Yj),null,{default:k(()=>[B(E(h.value),1)]),_:1}),z(O(Kj),null,{default:k(()=>[...t[11]||=[B(` A binding is not armed until it is approved, and editing one drops it back to pending approval. `,-1)]]),_:1})]),_:1}),R(`form`,{onSubmit:t[9]||=uu(e=>i(`save`,a.value),[`prevent`])},[z(O(BC),null,{default:k(()=>[z(O(RC),null,{default:k(()=>[z(O(HC),{for:`binding-name`},{default:k(()=>[...t[12]||=[B(`Name`,-1)]]),_:1}),z(O(VO),{id:`binding-name`,modelValue:a.value.name,"onUpdate:modelValue":t[0]||=e=>a.value.name=e},null,8,[`modelValue`])]),_:1}),z(O(RC),null,{default:k(()=>[z(O(HC),{for:`binding-event-type`},{default:k(()=>[...t[13]||=[B(`Event type`,-1)]]),_:1}),z(O(qS),{modelValue:a.value.eventTypeId,"onUpdate:modelValue":t[1]||=e=>a.value.eventTypeId=e},{default:k(()=>[z(O(DC),{id:`binding-event-type`,class:`w-full`},{default:k(()=>[z(O(OC),{placeholder:`Pick an event type`})]),_:1}),z(O(xC),null,{default:k(()=>[z(O(SC),null,{default:k(()=>[(F(!0),I(P,null,M(n Line truncated
`).map(e=>e.trim()).find(Boolean)||``,r=n.length>uA?`${n.slice(0,uA).trimEnd()}…`:n;return{text:r,full:t,truncated:r!==t}}var fA=[`title`],pA=j({__name:`ActivityRow`,props:{event:{}},emits:[`open`],setup(e,{emit:t}){let n=e,r=t,i=U(()=>Rk(n.event)),a=U(()=>dA(n.event));function o(){i.value>0&&r(`open`,i.value)}let s=U(()=>n.event.at?kO(n.event.at):`—`);return(e,t)=>(F(),L(O(cA),{class:T(i.value>0?`cursor-pointer`:``),role:i.value>0?`link`:void 0,tabindex:i.value>0?0:void 0,title:i.value>0?`Open task details`:void 0,onClick:o,onKeydown:[fu(uu(o,[`prevent`]),[`enter`]),fu(uu(o,[`prevent`]),[`space`])]},{default:k(()=>[z(O(Q),{class:`font-medium`},{default:k(()=>[B(E(n.event.kind||n.event.type||`event`),1)]),_:1}),z(O(Q),{class:`font-mono`},{default:k(()=>[B(E(i.value>0?`#${i.value}`:`—`),1)]),_:1}),z(O(Q),{class:`w-[55%] max-w-0`},{default:k(()=>[R(`span`,{class:`block truncate`,title:a.value.truncated?a.value.full:void 0},E(a.value.text),9,fA)]),_:1}),z(O(Q),null,{default:k(()=>[B(E(s.value),1)]),_:1})]),_:1},8,[`class`,`role`,`tabindex`,`title`,`onKeydown`]))}});function mA(e,t){return`${e}:${t??0}`}function hA(e){let t=[];for(let n of e){let e=n.kind||n.type||`event`,r=Number(n.task_id)||0,i=mA(dA(n).text,r),a=t[t.length-1];if(a&&a.key===i){a.count+=1,a.events.push(n);continue}t.push({key:i,label:e,taskID:r,count:1,representative:n,events:[n]})}return t}var gA={role:`region`,"aria-label":`Live activity`,"aria-live":`polite`},_A={class:`max-h-[28rem] overflow-y-auto`},vA=[`aria-expanded`,`aria-label`,`onClick`],yA=[`title`],bA=j({__name:`LiveActivityCard`,setup(e){let t=uE(),{activity:n,streamKind:r,streamState:i}=od(dk()),a=rn(new Set),o=U(()=>hA(n.value));function s(e){a.has(e)?a.delete(e):a.add(e)}function c(e){return a.has(e.key)}function l(e){return dA(e.representative)}function u(e){return e.representative.at?kO(e.representative.at):`—`}function d(e){t.push(`/tasks?task=${encodeURIComponent(e)}`)}return(e,t)=>(F(),L(O(xO),null,{default:k(()=>[z(O(EO),null,{default:k(()=>[z(O(DO),null,{default:k(()=>[...t[0]||=[B(`Live activity`,-1)]]),_:1}),z(O(SO),null,{default:k(()=>[z(O(sO),{variant:O(r)},{default:k(()=>[B(E(O(i)),1)]),_:1},8,[`variant`])]),_:1})]),_:1}),z(O(CO),null,{default:k(()=>[R(`div`,gA,[R(`div`,_A,[z(O(oA),null,{default:k(()=>[z(O(lA),{class:`sticky top-0 z-10 bg-card`},{default:k(()=>[z(O(cA),null,{default:k(()=>[z(O($),null,{default:k(()=>[...t[1]||=[B(`Event`,-1)]]),_:1}),z(O($),null,{default:k(()=>[...t[2]||=[B(`Task`,-1)]]),_:1}),z(O($),null,{default:k(()=>[...t[3]||=[B(`Detail`,-1)]]),_:1}),z(O($),null,{default:k(()=>[...t[4]||=[B(`When`,-1)]]),_:1})]),_:1})]),_:1}),z(O(sA),null,{default:k(()=>[O(n).length?V(``,!0):(F(),L(O(cA),{key:0},{default:k(()=>[z(O(Q),{colspan:`4`},{default:k(()=>[z(O($D),null,{default:k(()=>[z(O(nO),null,{default:k(()=>[z(O(aO),null,{default:k(()=>[...t[5]||=[B(`Waiting for activity`,-1)]]),_:1})]),_:1})]),_:1})]),_:1})]),_:1})),O(n).length?(F(!0),I(P,{key:1},M(o.value,e=>(F(),I(P,{key:e.key},[e.count===1?(F(),L(pA,{key:0,event:e.representative,onOpen:d},null,8,[`event`])):(F(),I(P,{key:1},[z(O(cA),{class:T(e.taskID>0?`cursor-pointer`:``),role:e.taskID>0?`link`:void 0,tabindex:e.taskID>0?0:void 0,title:e.taskID>0?`Open task details`:void 0,onClick:t=>e.taskID>0&&d(e.taskID),onKeydown:[fu(uu(t=>e.taskID>0&&d(e.taskID),[`prevent`]),[`enter`]),fu(uu(t=>e.taskID>0&&d(e.taskID),[`prevent`]),[`space`])]},{default:k(()=>[z(O(Q),{class:`font-medium`},{default:k(()=>[R(`button`,{type:`button`,class:`inline-flex items-center gap-1 rounded hover:opacity-80`,"aria-expanded":c(e),"aria-label":`${c(e)?`Hide`:`Show`} ${e.count} ${e.label} events`,onClick:uu(t=>s(e.key),[`stop`])},[c(e)?(F(),L(O(Sd),{key:0,class:`size-3.5 shrink-0 text-fg-subtle`})):(F(),L(O(wd),{key:1,class:`size-3.5 shrink-0 text-fg-subtle`})),B(` `+E(e.label)+` `,1),z(O(sO),{variant:`idle`},{default:k(()=>[B(`×`+E(e.count),1)]),_:2},1024)],8,vA)]),_:2},1024),z(O(Q),{class:`font-mono`},{default:k(()=>[B(E(e.taskID>0?`#${e.taskID}`:`—`),1)]),_:2},1024),z(O(Q),{class:`w-[55%] max-w-0`},{default:k(()=>[R(`span`,{class:`block truncate`,title:l(e).truncated?l(e).full:void 0},E(l(e).text),9,yA)]),_:2},1024),z(O(Q),null,{default:k(()=>[B(E(u(e)),1)]),_:2},1024)]),_:2},1032,[`class`,`role`,`tabindex`,`title`,`onClick`,`onKeydown`]),c(e)?(F(!0),I(P,{key:0},M(e.events,(t,n)=>(F(),L(pA,{key:`${e.key}:${n}`,event:t,onOpen:d},null,8,[`event`]))),128)):V(``,!0)],64))],64))),128)):V(``,!0)]),_:1})]),_:1})])])]),_:1})]),_:1}))}}),xA=j({__name:`Progress`,props:{modelValue:{default:0},max:{},getValueLabel:{},getValueText:{},asChild:{type:Boolean},as:{},class:{type:[Boolean,null,String,Object,Array]}},setup(e){let t=e,n=oC(t,`class`);return(e,r)=>(F(),L(O(Mx),H({"data-slot":`progress`},O(n),{class:O(K)(`bg-muted h-1 rounded-full relative flex w-full items-center overflow-x-hidden`,t.class)}),{default:k(()=>[z(O(Nx),{"data-slot":`progress-indicator`,class:`bg-primary size-full flex-1 transition-all`,style:ye(`transLine truncated
`)){let e=n.indexOf(`:`);if(e<=0)continue;let r=n.slice(0,e).trim();r&&(t[r]=n.slice(e+1).trim())}return t}function Zj(e,t){if(!e.event_type)return{label:`Unidentified`,identified:!1};let n=t.find(t=>t.id===e.event_type);return{label:n?n.name:`Deleted type`,identified:!0}}function Qj(e,t){if(!e)return`No event type`;let n=t.find(t=>t.id===e);return n?`${n.source} / ${n.name}`:`Deleted type`}function $j(e){let t=[...(e.headers||[]).map(e=>`${e.name} = ${e.value}`),...(e.payload||[]).map(e=>e.op===`present`?`${e.path} present`:`${e.path} = ${e.value??``}`)];return t.length?t.join(` · `):`any event`}function eM(e){return{headers:(e.headers||[]).filter(e=>e.name.trim()!==``).map(e=>({name:e.name.trim(),value:e.value})),payload:(e.payload||[]).filter(e=>e.path.trim()!==``).map(e=>e.op===`present`?{path:e.path.trim(),op:e.op}:{path:e.path.trim(),op:e.op,value:e.value??``})}}function tM(e,t){return t?e.filter(e=>e.event_type_id===t):[]}function nM(e){return(e?.repository??`required`)!==`none`}function rM(e,t){return e.filter(e=>t===`any`||e.type===`any`||e.type===t)}function iM(e,t){switch(t){case`string`:return e;case`number`:return e.trim()!==``&&!Number.isNaN(Number(e))?Number(e):e;case`bool`:return e===`true`||e!==`false`&&e;default:try{return JSON.parse(e)}catch{return e}}}var aM={pending_approval:`pending approval`,armed:`armed`},oM={pending_approval:`warn`,armed:`ok`};function sM(e){return e?aM[e]??e:`unknown`}function cM(e){return oM[e??``]??`idle`}function lM(){return{id:null,name:``,eventTypeId:``,mappingId:``,filter:``,workflow:``,owner:``,repo:``,repoParam:``,inputs:{}}}function uM(e,t){let n=t.find(t=>t.id===e.mapping_id);return{id:e.id,name:e.name,eventTypeId:n?.event_type_id||``,mappingId:e.mapping_id||``,filter:e.filter||``,workflow:e.workflow||``,owner:e.owner||``,repo:e.repo||``,repoParam:e.repo_param||``,inputs:Object.fromEntries(Object.entries(e.inputs??{}).map(([e,t])=>[e,{param:t.param??``,value:t.param?``:typeof t.value==`string`?t.value:JSON.stringify(t.value)}]))}}function dM(e,t,n){let r=t.find(t=>t.id===e.eventTypeId),i=n?.inputs??{},a={};for(let[t,n]of Object.entries(i)){let r=e.inputs[t];r?.param?a[t]={param:r.param}:r&&r.value!==``&&(a[t]={value:iM(r.value,n.type)})}let o=nM(n);return{name:e.name,matcher:{source:r?.source||``},mapping_id:e.mappingId,filter:e.filter.trim(),workflow:e.workflow,owner:o&&!e.repoParam?e.owner:``,repo:o&&!e.repoParam?e.repo:``,repo_param:o?e.repoParam:``,inputs:a}}function fM(e){return e.repo_param?`from ${e.repo_param}`:e.owner&&e.repo?`${e.owner}/${e.repo}`:`—`}function pM(e,t){return t.find(t=>t.id===e.mapping_id)?.event_type_id}var mM={class:`font-mono`},hM={class:`text-fg-muted`},gM={class:`grid grid-cols-2 items-start gap-3`},_M={class:`grid grid-cols-2 items-start gap-3`},vM=`__constant__`,yM=`__none__`,bM=j({__name:`BindingEditor`,props:Va({binding:{},mappings:{},eventTypes:{},workflows:{},saving:{type:Boolean},error:{}},{open:{type:Boolean,required:!0},openModifiers:{}}),emits:Va([`save`],[`update:open`]),setup(e,{emit:t}){let n=e,r=lo(e,`open`),i=t,a=D(lM());A(r,e=>{e&&(a.value=n.binding?uM(n.binding,n.mappings):lM())},{immediate:!0});let o=U(()=>tM(n.mappings,a.value.eventTypeId));A(()=>a.value.eventTypeId,()=>{o.value.some(e=>e.id===a.value.mappingId)||(a.value.mappingId=``)});let s=U(()=>n.workflows.find(e=>e.id===a.value.workflow)),c=U(()=>Object.entries(s.value?.inputs??{}).sort(([e],[t])=>e.localeCompare(t))),l=U(()=>n.mappings.find(e=>e.id===a.value.mappingId)?.fields??[]),u=U(()=>rM(l.value,`string`));function d(e){return a.value.inputs[e]??={param:``,value:``},a.value.inputs[e]}function f(e){return d(e).param||vM}function p(e,t){d(e).param=t===vM?``:String(t)}let m=U({get:()=>a.value.repoParam||yM,set:e=>{a.value.repoParam=e===yM?``:e}}),h=U(()=>n.binding?`Edit binding`:`New binding`);return(e,t)=>(F(),L(O(Uj),{open:r.value,"onUpdate:open":t[10]||=e=>r.value=e},{default:k(()=>[z(O(Gj),{class:`max-h-[85vh] overflow-y-auto sm:max-w-lg`},{default:k(()=>[z(O(Jj),null,{default:k(()=>[z(O(Yj),null,{default:k(()=>[B(E(h.value),1)]),_:1}),z(O(Kj),null,{default:k(()=>[...t[11]||=[B(` A binding is not armed until it is approved, and editing one drops it back to pending approval. `,-1)]]),_:1})]),_:1}),R(`form`,{onSubmit:t[9]||=uu(e=>i(`save`,a.value),[`prevent`])},[z(O(BC),null,{default:k(()=>[z(O(RC),null,{default:k(()=>[z(O(HC),{for:`binding-name`},{default:k(()=>[...t[12]||=[B(`Name`,-1)]]),_:1}),z(O(VO),{id:`binding-name`,modelValue:a.value.name,"onUpdate:modelValue":t[0]||=e=>a.value.name=e},null,8,[`modelValue`])]),_:1}),z(O(RC),null,{default:k(()=>[z(O(HC),{for:`binding-event-type`},{default:k(()=>[...t[13]||=[B(`Event type`,-1)]]),_:1}),z(O(qS),{modelValue:a.value.eventTypeId,"onUpdate:modelValue":t[1]||=e=>a.value.eventTypeId=e},{default:k(()=>[z(O(DC),{id:`binding-event-type`,class:`w-full`},{default:k(()=>[z(O(OC),{placeholder:`Pick an event type`})]),_:1}),z(O(xC),null,{default:k(()=>[z(O(SC),null,{default:k(()=>[(F(!0),I(P,null,M(n Line truncated
+1 -1
View File
@@ -67,7 +67,7 @@ export const DEFAULT_ACTIONS: ActionMeta[] = [
id: "abandon",
label: "Abandon",
kind: "quiet",
confirm: `Abandon "{title}"? This closes the forge issue.`,
confirm: `Abandon "{title}"? Archie stops working on it; the forge issue stays open.`,
},
{
id: "archive",
+1 -1
View File
@@ -182,7 +182,7 @@ export function archieWebMcpTools(client: DashboardApi): WebMcpTool[] {
client,
"cancel_task",
"cancel",
"End a task that should not continue; this closes the forge issue. Use only when the work is unwanted -- stop_task parks it recoverably instead.",
"End a parked task archie should not continue; the forge issue stays open. stop_task parks a running task recoverably instead.",
),
];
}