From 7fd393492d73937cb5d1adee410ff5a02a3c3f84 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Tue, 15 Sep 2026 12:48:38 +1000 Subject: [PATCH] fix(curator): populate PassInput.Since with the prior pass time WIRE: docs/prds/session-memory-curator.md specifies that each pass finds "sessions with activity since the last pass", and its effectiveSince rule treats a zero Since as "the runtime declining to name a horizon" (24h fallback for the first pass). The runtime is the only production constructor of PassInput and already carries lastPass, so it must name the horizon at the producer by setting Since to the prior pass time. Previously Since was never set, so the session curator fell back to now-24h on every pass and re-read the same window each chat turn. --- internal/domain/curator/runtime.go | 2 +- internal/domain/curator/runtime_test.go | 35 +++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/internal/domain/curator/runtime.go b/internal/domain/curator/runtime.go index f30f94640..13940afdf 100644 --- a/internal/domain/curator/runtime.go +++ b/internal/domain/curator/runtime.go @@ -214,7 +214,7 @@ func (rt *Runtime) runLoop(ctx context.Context, name string, c CuratorEngine) { return // shutting down while waiting for a pass slot } passCtx, cancel := context.WithTimeout(ctx, rt.cfg.PassTimeout) - result, perr := rt.safePass(passCtx, c, PassInput{Reason: reason, LastPass: lastPass}) + result, perr := rt.safePass(passCtx, c, PassInput{Reason: reason, Since: lastPass, LastPass: lastPass}) cancel() rt.release() diff --git a/internal/domain/curator/runtime_test.go b/internal/domain/curator/runtime_test.go index dbb914884..79b09b88d 100644 --- a/internal/domain/curator/runtime_test.go +++ b/internal/domain/curator/runtime_test.go @@ -453,3 +453,38 @@ func TestRuntimePassInputRecordsReasonAndLastPass(t *testing.T) { t.Error("second pass LastPass is zero; want the previous pass time") } } + +func TestRuntimePassInputSetsSinceToPriorPass(t *testing.T) { + t.Parallel() + + clock := newFakeClock(time.Unix(0, 0)) + c := newFake("c", Manifest{Interval: testInterval, OnInput: true}) + c.checkResult = true + _, rt, _ := newRuntimeTestEnv(t, clock, RuntimeConfig{}, c) + + if err := rt.Start(context.Background()); err != nil { + t.Fatalf("Start() = %v, want nil", err) + } + t.Cleanup(func() { _ = rt.Stop(context.Background()) }) + + waitFor(t, 2*time.Second, "first pass", func() bool { return c.passCalls.Load() == 1 }) + + rt.Nudge("c") + waitFor(t, 2*time.Second, "nudged pass", func() bool { return c.passCalls.Load() == 2 }) + + c.inputMu.Lock() + inputs := slices.Clone(c.inputs) + c.inputMu.Unlock() + if len(inputs) != 2 { + t.Fatalf("pass inputs = %d, want 2", len(inputs)) + } + if !inputs[0].Since.IsZero() { + t.Errorf("first pass Since = %v, want zero so the curator applies its own first-pass lookback", inputs[0].Since) + } + if inputs[1].Since.IsZero() { + t.Error("second pass Since is zero; want the previous pass time so a pass reads only activity since the last pass") + } + if !inputs[1].Since.Equal(inputs[1].LastPass) { + t.Errorf("second pass Since = %v, want %v (the previous pass time also carried in LastPass)", inputs[1].Since, inputs[1].LastPass) + } +}