From 763cd0e58155dc5f0800d51fc6bbc195db850dc5 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Sun, 22 Nov 2026 02:03:24 +1100 Subject: [PATCH] feat(governance): delete a model or alias from /settings/models (#2090) --- api/openapi.yaml | 22 +++++++++++++++ modules/governance/governance.go | 19 +++++++++++++ modules/governance/internal/store/store.go | 14 ++++++++++ ui/src/lib/api.ts | 2 ++ ui/src/settings/AgentModelsPage.vue | 32 +++++++++++++++++++++- 5 files changed, 88 insertions(+), 1 deletion(-) diff --git a/api/openapi.yaml b/api/openapi.yaml index c33ad9e4e..acfbb3e36 100644 --- a/api/openapi.yaml +++ b/api/openapi.yaml @@ -5480,6 +5480,28 @@ paths: tags: - Governance /api/settings/agent-model: + delete: + operationId: delete-agent-model + parameters: + - description: Agent model alias; omit for the default model + explode: false + in: query + name: alias + schema: + description: Agent model alias; omit for the default model + type: string + responses: + "204": + description: No Content + default: + content: + application/problem+json: + schema: + $ref: "#/components/schemas/ErrorModel" + description: Error + summary: Delete an agent model + tags: + - Governance get: operationId: get-agent-model parameters: diff --git a/modules/governance/governance.go b/modules/governance/governance.go index 45d900a59..2d1aab4d8 100644 --- a/modules/governance/governance.go +++ b/modules/governance/governance.go @@ -409,6 +409,10 @@ func (m *Module) Register(api huma.API) { OperationID: "put-agent-model", Method: http.MethodPut, Path: "/api/settings/agent-model", Summary: "Set the agent model", Tags: tags, }, m.putAgentModel) + huma.Register(api, huma.Operation{ + OperationID: "delete-agent-model", Method: http.MethodDelete, Path: "/api/settings/agent-model", + Summary: "Delete an agent model", Tags: tags, DefaultStatus: http.StatusNoContent, + }, m.deleteAgentModel) huma.Register(api, huma.Operation{ OperationID: "test-agent-model", Method: http.MethodPost, Path: "/api/settings/agent-model/test", Summary: "Ask a model one question before saving it", Tags: tags, @@ -606,6 +610,21 @@ func (m *Module) putAgentModel(ctx context.Context, in *agentModelInput) (*httpa return httpapi.OK(model), nil } +func (m *Module) deleteAgentModel(ctx context.Context, in *agentModelAlias) (*struct{}, error) { + if err := ValidateAgentModelAlias(in.Alias); err != nil { + return nil, huma.NewError(http.StatusBadRequest, err.Error()) + } + found, err := m.store.DeleteModelRole(ctx, m.orgID, agentModelRole(in.Alias)) + if err != nil { + m.log.ErrorContext(ctx, "delete agent model", "error", err) + return nil, huma.NewError(http.StatusInternalServerError, "couldn't delete the agent model") + } + if !found { + return nil, huma.NewError(http.StatusNotFound, "no such agent model") + } + return nil, nil +} + // modelAnswer is a test call's answer. type modelAnswer struct { Model string `json:"model"` diff --git a/modules/governance/internal/store/store.go b/modules/governance/internal/store/store.go index baa3e40af..3d04e3123 100644 --- a/modules/governance/internal/store/store.go +++ b/modules/governance/internal/store/store.go @@ -71,6 +71,20 @@ func (s *Store) PutModelRole(ctx context.Context, m ModelRole) error { return nil } +// DeleteModelRole removes the organisation's model for role and reports +// whether one existed. +func (s *Store) DeleteModelRole(ctx context.Context, orgID, role string) (bool, error) { + res, err := s.db.ExecContext(ctx, `DELETE FROM governance.model_roles WHERE org_id = $1 AND role = $2`, orgID, role) + if err != nil { + return false, fmt.Errorf("delete model role %q: %w", role, err) + } + n, err := res.RowsAffected() + if err != nil { + return false, fmt.Errorf("delete model role %q: %w", role, err) + } + return n > 0, nil +} + // Settings is an organisation's settings as stored. A duration is kept in // milliseconds: Postgres has no duration type that scans into one. type Settings struct { diff --git a/ui/src/lib/api.ts b/ui/src/lib/api.ts index 76b514f17..0dbf9ecd3 100644 --- a/ui/src/lib/api.ts +++ b/ui/src/lib/api.ts @@ -228,6 +228,8 @@ export const api = { agentModels: () => request>("/api/settings/agent-models"), putAgentModel: (alias: string, model: AgentModel) => request("/api/settings/agent-model" + qs({ alias }), { method: "PUT", body: model }), + deleteAgentModel: (alias: string) => + request("/api/settings/agent-model" + qs({ alias }), { method: "DELETE", parse: false }), testAgentModel: (model: AgentModel) => request<{ answer: string; model: string }>("/api/settings/agent-model/test", { method: "POST", body: model, timeoutMs: 60_000 }), policyText: (kind: PolicyKind, version?: number) => diff --git a/ui/src/settings/AgentModelsPage.vue b/ui/src/settings/AgentModelsPage.vue index b36787844..74bc1c7d9 100644 --- a/ui/src/settings/AgentModelsPage.vue +++ b/ui/src/settings/AgentModelsPage.vue @@ -5,6 +5,7 @@ import { computed, onMounted, ref } from "vue"; import PageHeader from "@/base/PageHeader.vue"; import { Button } from "@/components/ui/button"; import { DataTable, type DataTableColumn } from "@/components/ui/data-table"; +import { AlertDialog, AlertDialogAction, AlertDialogCancel, AlertDialogContent, AlertDialogDescription, AlertDialogFooter, AlertDialogHeader, AlertDialogTitle } from "@/components/ui/alert-dialog"; import { Dialog, DialogContent, DialogFooter, DialogHeader, DialogTitle } from "@/components/ui/dialog"; import { DropdownMenuItem } from "@/components/ui/dropdown-menu"; import { Empty, EmptyHeader, EmptyTitle } from "@/components/ui/empty"; @@ -91,6 +92,20 @@ async function save(): Promise { busy.value = false; } } +const pending = ref(null); +const removeError = ref(""); +async function remove(row: Row): Promise { + busy.value = true; + removeError.value = ""; + try { + await api.deleteAgentModel(row.alias === "default" ? "" : row.alias); + await reload(); + } catch (cause) { + removeError.value = describeError(cause, errors.common.unknown); + } finally { + busy.value = false; + } +}