ci(deploy): run the gate from the Taskfile, not an inlined copy (#1580)

deploy.yml inlined its own sequence, which drifted weaker than `task check`:
no db:check, news:check or ui:check, so a release could ship stale sqlc
output, a stale ui/dist, or release notes that disagree with CHANGELOG.md,
and the dashboard suite ran outside the gate without its type check.

The release now runs `task check TEST_FLAGS=-count=1`: same definition, the
full uncached suite including the Docker-backed tests -short skips. quality.yml
already invoked the Taskfile, so both pipelines now share one gate.
This commit is contained in:
sam committed 2026-10-31 00:37:26 +11:00
1 parent ad9ec16844
commit 6031a7a14b
3 files changed
+18 -26

No files matched your search

+10 -20
View File
@@ -96,35 +96,25 @@ jobs:
- name: Pull test container images
run: docker pull alpine:3
# One definition of the gate, in the Taskfile. This step used to inline
# its own list, which drifted weaker than `task check`: it ran no
# db:check, news:check or ui:check, so a release could ship stale
# generated SQL, a stale ui/dist, or release notes that disagree with
# CHANGELOG.md. It also ran the dashboard suite here rather than in the
# gate, where test:ui runs it with the type check. TEST_FLAGS is the one
# difference -- the release runs the whole suite, uncached and including
# the Docker-backed tests -short skips. The diff after it asserts
# `task fmt` changed nothing.
- name: Quality gate
run: |
# The formatter sequence has one owner: task fmt, which drives go fix
# to a fixpoint and then the configured lint formatters. This step
# used to inline its own single `go fix ./...`, which leaves the
# redundant loop-variable copy that copyloopvar rejects -- the hazard
# of archie-core-wwho, surfacing here as a spurious git-diff failure
# (archie-core-6kda).
task fmt
task check TEST_FLAGS=-count=1
git diff --exit-code
bash tools/proto.sh lint
bash tools/proto.sh check
go vet ./...
golangci-lint run ./...
go build ./...
go test ./... -count=1
- name: Vulnerability scan
run: |
go install golang.org/x/vuln/cmd/govulncheck@latest
govulncheck ./...
# The dashboard suite runs in CI too, or it only ever runs when
# someone remembers to; the Go steps above never touch it.
- name: Dashboard tests
run: |
pnpm --dir ui install --frozen-lockfile
pnpm --dir ui test
- name: Release tags must match changelogs
run: |
set -e