fix(build): clear pre-existing task check gate blockers (#719)
Baseline `task check` failed on a clean main checkout, blocking unrelated in-flight work. Fixes only those pre-existing failures: - bootstrap.go: extract wireWebStoreSurfaces from setupObservability (cyclop 16 > 15) and startEmbeddedNATS from connectNATS (nestif). - telegram_setup_test.go: os.Setenv -> t.Setenv (usetesting). - install_script_test.go: exec.Command -> exec.CommandContext with t.Context() (noctx). - Taskfile: add a ui:deps install step shared by `ui` and `test:ui`. ui/node_modules is gitignored and nothing in the gate installed it, so `task test:ui` died on a missing jsdom rather than a real test failure. - shutdown_watchdog_test.go: `go fix` output adopted verbatim. Refs bead archie-core-14cs.
This commit is contained in:
1 parent
6af0d51459
commit
4ae6de7dfd
5 files changed
+57
-42
No files matched your search
+13
-2
@@ -44,16 +44,27 @@ tasks:
|
||||
cmds:
|
||||
- govulncheck ./...
|
||||
|
||||
ui:
|
||||
desc: Build the dashboard into ui/dist (committed; the Go build embeds it)
|
||||
ui:deps:
|
||||
desc: Install the dashboard's node dependencies (ui/node_modules is gitignored)
|
||||
internal: true
|
||||
dir: ui
|
||||
cmds:
|
||||
- npm install --no-audit --no-fund
|
||||
|
||||
ui:
|
||||
desc: Build the dashboard into ui/dist (committed; the Go build embeds it)
|
||||
dir: ui
|
||||
deps: [ui:deps]
|
||||
cmds:
|
||||
- npm run build
|
||||
|
||||
test:ui:
|
||||
desc: Run the dashboard's node tests (DOM-building primitives)
|
||||
dir: ui
|
||||
# Without this, a fresh clone fails the gate on a missing jsdom rather
|
||||
# than a real test failure: ui/node_modules is gitignored and nothing
|
||||
# else in `task check` installs it.
|
||||
deps: [ui:deps]
|
||||
cmds:
|
||||
- npm test
|
||||
|
||||
|
||||
Reference in new issue
Block a user