From 40441c7655e87d0d0b15466fb6c97fdc2d8d6023 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Sat, 15 Aug 2026 23:55:21 +1000 Subject: [PATCH] fix(tools): document intentional fallback skips --- internal/tools/builtin/find.go | 2 +- internal/tools/builtin/grep.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/tools/builtin/find.go b/internal/tools/builtin/find.go index 3885415ce..0850d8c37 100644 --- a/internal/tools/builtin/find.go +++ b/internal/tools/builtin/find.go @@ -166,7 +166,7 @@ func runFindGoFallback(ctx context.Context, cwd, searchPath string, p FindParams err = filepath.WalkDir(searchPath, func(walkPath string, d os.DirEntry, err error) error { if err != nil { - return nil // skip inaccessible entries + return nil //nolint:nilerr // intentionally skip inaccessible entries } select { diff --git a/internal/tools/builtin/grep.go b/internal/tools/builtin/grep.go index cb75d06db..e6140817f 100644 --- a/internal/tools/builtin/grep.go +++ b/internal/tools/builtin/grep.go @@ -379,7 +379,7 @@ func grepFallback(ctx context.Context, p GrepParams, searchPath, cwd string, tar } else { err = filepath.WalkDir(searchPath, func(walkPath string, d os.DirEntry, err error) error { if err != nil { - return nil // skip inaccessible + return nil //nolint:nilerr // intentionally skip inaccessible entries } select { @@ -410,7 +410,7 @@ func grepFallback(ctx context.Context, p GrepParams, searchPath, cwd string, tar res, err := grepFile(ctx, walkPath, matcher, p.ContextBefore, p.ContextAfter) if err != nil { - return nil // skip files we can't read + return nil //nolint:nilerr // intentionally skip files we can't read } for i := range res { res[i].relPath, _ = filepath.Rel(cwd, walkPath)