From 3e442c569d052066693662ded395f0bee569ca4e Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Sat, 5 Sep 2026 03:13:52 +1000 Subject: [PATCH] fix(servicediscovery): check lister/watcher Stop() errors golangci-lint (errcheck) flagged both deferred Stop() calls in the NATS KV registry as unchecked. Explicit discard, no behavior change. --- internal/infrastructure/servicediscovery/nats/registry.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/infrastructure/servicediscovery/nats/registry.go b/internal/infrastructure/servicediscovery/nats/registry.go index f5d6e8873..99582d7a6 100644 --- a/internal/infrastructure/servicediscovery/nats/registry.go +++ b/internal/infrastructure/servicediscovery/nats/registry.go @@ -154,7 +154,7 @@ func (c *Client) Resolve(ctx context.Context, service string) ([]servicediscover if err != nil { return nil, fmt.Errorf("resolve %s: %w", service, err) } - defer lister.Stop() + defer func() { _ = lister.Stop() }() // A lister may report duplicate keys; dedupe by ID and sort for a stable // order so callers get a deterministic roster. @@ -226,7 +226,7 @@ func (c *Client) Watch(ctx context.Context, service string) (<-chan servicedisco // liveness pings. func (c *Client) fanWatch(ctx context.Context, service string, watcher jetstream.KeyWatcher, out chan<- servicediscovery.Event) { defer close(out) - defer watcher.Stop() + defer func() { _ = watcher.Stop() }() known := map[string]struct{}{} for {