From 378c0e82d6c00fbca3d44e07541a4e2d7343a605 Mon Sep 17 00:00:00 2001 From: Sam Date: Thu, 3 Sep 2026 15:13:35 +1000 Subject: [PATCH] Potential fix for code scanning alert no. 6: Slice memory allocation with excessive size value --- internal/webui/api_logs.go | 17 ++++++++++++++++- internal/webui/api_tasks_logs.go | 17 ++++++++++++++++- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/internal/webui/api_logs.go b/internal/webui/api_logs.go index 31ead1302..0c28c946b 100644 --- a/internal/webui/api_logs.go +++ b/internal/webui/api_logs.go @@ -32,7 +32,22 @@ func (s *Server) handleLogs(w http.ResponseWriter, r *http.Request) { } q := r.URL.Query() - limit, _ := strconv.Atoi(q.Get("limit")) + limit := logging.DefaultTailLines + if raw := strings.TrimSpace(q.Get("limit")); raw != "" { + parsed, err := strconv.Atoi(raw) + if err != nil { + http.Error(w, "bad limit", http.StatusBadRequest) + return + } + switch { + case parsed <= 0: + limit = logging.DefaultTailLines + case parsed > logging.MaxTailLines: + limit = logging.MaxTailLines + default: + limit = parsed + } + } result, err := logging.Tail(path, logging.Query{ Levels: splitCSV(q.Get("level")), Component: strings.TrimSpace(q.Get("component")), diff --git a/internal/webui/api_tasks_logs.go b/internal/webui/api_tasks_logs.go index a8cfd007c..1966a5b17 100644 --- a/internal/webui/api_tasks_logs.go +++ b/internal/webui/api_tasks_logs.go @@ -56,7 +56,22 @@ func (s *Server) handleTaskLogs(w http.ResponseWriter, r *http.Request) { return } - limit, _ := strconv.Atoi(q.Get("limit")) + limit := logging.DefaultTailLines + if raw := strings.TrimSpace(q.Get("limit")); raw != "" { + parsed, err := strconv.Atoi(raw) + if err != nil { + http.Error(w, "bad limit", http.StatusBadRequest) + return + } + switch { + case parsed <= 0: + limit = logging.DefaultTailLines + case parsed > logging.MaxTailLines: + limit = logging.MaxTailLines + default: + limit = parsed + } + } result, err := logging.Tail(path, logging.Query{ Levels: splitCSV(q.Get("level")), Component: strings.TrimSpace(q.Get("component")),