fix(e2e): checks follow the sidebar navigation; trim stray button and caption whitespace (#1789)
Quality / check (push) Successful in 3m52s
deploy / gate (push) Successful in 4m36s
deploy / archied-image (push) Successful in 3m16s
deploy / agent-image (push) Successful in 11s
deploy / dist-zip (push) Skipped

This commit is contained in:
sam committed 2026-11-03 09:35:19 +11:00
1 parent 2fb8c09a00
commit 0b7ce448ab
4 files changed
+10 -13

No files matched your search

+2 -2
View File
@@ -35,8 +35,8 @@ module.exports = async ({ page, go, shot, settled }) => {
assert.ok(await skip.evaluate(el => el === document.activeElement), 'Skip link is not the first keyboard stop');
await page.keyboard.press('Enter');
assert.equal(await page.evaluate(() => document.activeElement?.id), 'main-content');
await page.getByRole('button', { name: 'Sections', exact: true }).click();
await page.getByRole('navigation', { name: 'Sections', exact: true }).getByRole('link', { name: 'Tasks', exact: true }).click();
await page.getByRole('button', { name: 'Toggle Sidebar', exact: true }).click();
await page.getByRole('list', { name: 'Sections', exact: true }).getByRole('link', { name: 'Tasks', exact: true }).click();
await page.waitForFunction(() => document.activeElement?.id === 'main-content', null, { timeout: 5000 }).catch(() => {});
assert.equal(await page.evaluate(() => document.activeElement?.id), 'main-content', 'route navigation did not focus main');
await page.getByRole('button', { name: 'Jump to', exact: true }).click();
+6 -5
View File
@@ -1,4 +1,4 @@
// The topbar org selector: choosing a member org reloads the dashboard into it,
// The sidebar org switcher: choosing a member org reloads the dashboard into it,
// Tasks and Workflows then show only that org's work, and the API refuses an
// org the caller is not a member of.
const assert = require('node:assert/strict');
@@ -8,11 +8,12 @@ module.exports = async ({ page, go, shot, settled, tolerate }) => {
tolerate(ABSENT);
await go('/tasks');
await page.getByText('Fix flaky login test').first().waitFor();
const picker = page.getByRole('combobox', { name: 'Organisation' });
const picker = page.getByRole('button', { name: /^Organisation: / });
await picker.waitFor();
const offered = await (async () => {
await picker.click();
const names = await page.getByRole('option').allInnerTexts();
await page.getByRole('menuitem').first().waitFor();
const names = (await page.getByRole('menuitem').allInnerTexts()).map(t => t.trim().split('\n').pop().trim());
await page.keyboard.press('Escape');
return names;
})();
@@ -22,9 +23,9 @@ module.exports = async ({ page, go, shot, settled, tolerate }) => {
await shot('home-org-workflows');
await picker.click();
await Promise.all([page.waitForEvent('load'), page.getByRole('option', { name: 'Beta', exact: true }).click()]);
await Promise.all([page.waitForEvent('load'), page.getByRole('menuitem', { name: 'Beta' }).click()]);
await settled('/workflows');
await page.getByRole('combobox', { name: 'Organisation' }).waitFor();
await page.getByRole('button', { name: /^Organisation: / }).waitFor();
assert.equal(await page.getByText('Parked', { exact: true }).count(), 0, 'workflow run counts leaked across orgs');
await shot('beta-workflows');
await go('/tasks');
+1 -3
View File
@@ -178,9 +178,7 @@ onUnmounted(() => {
{{ elapsedText }} of 24h elapsed (default window)
</p>
</div>
<p v-else class="mt-3 text-caption text-fg-muted">
Install time not recorded, so the window cannot be measured.
</p>
<p v-else class="mt-3 text-caption text-fg-muted">Install time not recorded, so the window cannot be measured.</p>
</template>
</template>
</Section>
+1 -3
View File
@@ -129,9 +129,7 @@ const unavailable = computed(() => !!connection.value.type && !extensions.forges
/>
<span class="font-mono text-xs">{{ operation }}</span>
</Label>
<Button variant="ghost" size="sm" @click="connection = removePermit(connection, identity)">
Remove
</Button>
<Button variant="ghost" size="sm" @click="connection = removePermit(connection, identity)">Remove</Button>
</div>
<Button variant="outline" size="sm" @click="connection = addPermit(connection)">
<Plus data-icon="inline-start" />Add identity