From 092fae3aa4fc4be101b549a26c16378a5f8d5628 Mon Sep 17 00:00:00 2001 From: Sam Catlow Date: Sat, 24 Oct 2026 18:27:17 +1100 Subject: [PATCH] chore(workflow): say in a review post failure whether it carried inline comments --- internal/domain/workflow/prreview_stages.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/internal/domain/workflow/prreview_stages.go b/internal/domain/workflow/prreview_stages.go index a7acd8266..448ea6427 100644 --- a/internal/domain/workflow/prreview_stages.go +++ b/internal/domain/workflow/prreview_stages.go @@ -737,8 +737,11 @@ func postReview(ctx context.Context, tc *TaskContext, owner, repo string, number } tc.Log.Info("posting review", "inline", places, "body_bytes", len(review.Body), "diff_files", len(tc.prReview.files)) err := tc.Forge.CreateReviewComments(ctx, owner, repo, number, headSHA, review) - if err == nil || len(review.Comments) == 0 { - return err + if err == nil { + return nil + } + if len(review.Comments) == 0 { + return fmt.Errorf("%w (no inline comments; %d diff files)", err, len(tc.prReview.files)) } tc.Log.Warn("forge refused inline review comments; posting them in the body", "err", err, "inline", places) if retry := tc.Forge.CreateReviewComments(ctx, owner, repo, number, headSHA, forgeReview(findings, nil)); retry != nil {