diff --git a/.beads/interactions.jsonl b/.beads/interactions.jsonl index f0c0660d5..e31e12cb9 100644 --- a/.beads/interactions.jsonl +++ b/.beads/interactions.jsonl @@ -197,3 +197,6 @@ {"id":"int-0ae0e3fbcad5c9cc45344d5f64b6abc5","kind":"field_change","created_at":"2026-09-02T18:01:29.431793769Z","actor":"Sam Catlow","issue_id":"archie-core-t2db.14","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Implemented and gate-verified as 33cdece (pushed to main). internal/domain/eda/expr: NewEnv (event+actions roots, DefaultCostLimit 100k), Compile (reject-at-load: syntax/unknown-root/type errors returned), Eval (panic-free, errors returned, ref.Val unwrapped to native). cel.dev/cel-go v0.32.0 direct dep, vetted per resolved doc (no re-vet). 9 tests pass, all verified against real CEL semantics (cost limits accrue on macros; == on missing key is false; unknown root rejected at compile). task check clean (113/113 UI)."}} {"id":"int-f10f375727370c967a2884fbc8e60b70","kind":"field_change","created_at":"2026-09-02T18:06:07.68242224Z","actor":"Sam Catlow","issue_id":"archie-core-t2db.15","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Implemented and gate-verified as 2c2b9b7 (pushed to main). internal/domain/eda/playbook: Load (reject-at-load: 2+ actions, non-workflow position, malformed, bad when compile all fail whole load) + Store.Dispatch (trigger match via workintake kind/labels, CEL when eval, named-workflow registry lookup -- same as Route()'s, no duplicated dispatch). EDAPlaybookDir config field (distinct from PlaybookDirs, documented), bootstrap load-and-abort. workflow.Route()/binding loaders untouched; their suites verified zero-regression. 11 tests + shipped example proving end-to-end; task check clean (113/113 UI). FOLLOW-UP TICKET NEEDED (not in this slice, per design): wire Store.Dispatch into production task intake (daemon.go/pollNATS/publishTask) so real forge-triggered tasks flow through the coordinator instead of only workflow.Route(); plus a separate linter/LSP integration ticket for the expr compile path."}} {"id":"int-7908617f987c5056730fd95c595c8d7d","kind":"field_change","created_at":"2026-09-02T18:17:08.363568118Z","actor":"Sam Catlow","issue_id":"archie-core-uhtz","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Investigated per design notes: intentional behavior, not a bug -- confirmed against existing test coverage (skillcurator_test.go's parse-failure-doesn't-abort-batch test). Documented with a scoped nolint explaining why, not a behavior change. Commit pushed to main."}} +{"id":"int-ad28db17a92a281b51deb682190489b8","kind":"field_change","created_at":"2026-09-02T20:18:20.468900706Z","actor":"Sam Catlow","issue_id":"archie-core-zv2t","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Fixed, tested (Playwright against a real isolated server), and pushed as commit 85761c4."}} +{"id":"int-5dd30e1f77dff564088caa908bd53330","kind":"field_change","created_at":"2026-09-02T20:18:20.908890222Z","actor":"Sam Catlow","issue_id":"archie-core-t2db.8","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"Backend Owner/Repo fix (ac42f64) + full dashboard UI (85761c4, mirroring ui/src/mappings/) both landed. Full state machine (draft->edit->pending_approval->approve->armed->delete) verified end-to-end in a real browser. Also fixed a related bug found in the process (empty-secret-on-edit rejected, commit 51ca509)."}} +{"id":"int-5f9484b3ee198a74559bebb85c7227da","kind":"field_change","created_at":"2026-09-02T20:20:15.450996359Z","actor":"Sam Catlow","issue_id":"archie-core-t2db.6","extra":{"field":"status","new_value":"closed","old_value":"open","reason":"All four items done: binding model + threat model (bindings.md, 41dffe3), ARCHITECTURE.md task-lifecycle addendum (edb90e1), operator walkthrough (this commit). Unblocked once t2db.8's UI landed."}} diff --git a/.beads/issues.jsonl b/.beads/issues.jsonl index 8d4e21262..627b99311 100644 --- a/.beads/issues.jsonl +++ b/.beads/issues.jsonl @@ -174,7 +174,7 @@ {"_type":"issue","id":"archie-core-1ysw.6","title":"Do not report push failure after successful publication","description":"Push publishes the remote ref before writing unused local upstream metadata, then returns local config errors as if publication failed.\n\nConfirmed still present on main: `Manager.Push` (internal/worktree/worktree.go:414-449) completes `r.PushContext` successfully, then calls `r.Config()` / `r.SetConfig(cfg)` to record branch upstream. Either of those returns `read repo config: %w` or `record branch upstream: %w` from `Push`, so a caller sees a push failure for a branch that is already published on the forge.\n\n## Steps to Reproduce\n\n1. Prepare a task worktree and commit a change so there is a branch to publish.\n2. Make the local repository config unwritable or unreadable after the remote is reachable (e.g. `chmod 000 \u003cworktree\u003e/.git/config`, or a `.git/config` the go-git config parser rejects).\n3. Call `Manager.Push(ctx, dir, branch)`.\n4. Observe the remote branch exists on the forge, but `Push` returns `record branch upstream: ...` (or `read repo config: ...`).\n5. The daemon treats that error as a failed publication and parks the task, even though the PR branch is live.\n\n## Acceptance Criteria\n\nA post-publication metadata failure cannot park the task as an unsuccessful push; tests verify the remote ref and returned result remain consistent.\n","acceptance_criteria":"A post-publication metadata failure cannot park the task as an unsuccessful push; tests verify the remote ref and returned result remain consistent.","status":"closed","priority":2,"issue_type":"bug","assignee":"Sam Catlow","owner":"sam@catlow.tech","created_at":"2026-08-22T11:01:46Z","created_by":"Sam Catlow","updated_at":"2026-08-24T08:15:47Z","started_at":"2026-08-24T07:42:09Z","closed_at":"2026-08-24T08:15:47Z","close_reason":"Fixed: recordUpstream extracted from Push (worktree.go:465); a post-publication config failure is now a logged warning and Push returns success once the remote ref is published. Manager gained an optional Log field with a slog.Default() fallback. Verified by inspection rather than a red run -- the test uses the new Log field so it cannot compile against the pre-fix code. task check green; fresh adversarial review (independent, did not write the code) zero findings.","external_ref":"https://github.com/samcharles93/archie-core/issues/600","dependencies":[{"issue_id":"archie-core-1ysw.6","depends_on_id":"archie-core-1ysw","type":"parent-child","created_at":"2026-08-22T21:01:46Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0} {"_type":"issue","id":"archie-core-1ysw.4","title":"Fail refresh when the configured base cannot resolve","description":"Prepared worktrees currently swallow every resolveBase error and report successful refresh against stale history.","acceptance_criteria":"Prepared-worktree refresh returns a contextual error for a missing, renamed, or invalid base; fresh and reused Prepare paths have consistent tests.","status":"closed","priority":2,"issue_type":"bug","owner":"sam@catlow.tech","created_at":"2026-08-22T11:01:45Z","created_by":"Sam Catlow","updated_at":"2026-08-24T07:00:23Z","started_at":"2026-08-22T11:52:19Z","closed_at":"2026-08-24T07:00:23Z","close_reason":"Fixed on main: prepared-worktree refresh now returns the resolveBase error instead of swallowing it (worktree.go:253-258, 'a missing base is configuration or repository drift and must fail closed'); resolveBase tries the qualified remote ref then origin/\u003cbase\u003e and errors otherwise.","external_ref":"https://github.com/samcharles93/archie-core/issues/601","metadata":null,"dependencies":[{"issue_id":"archie-core-1ysw.4","depends_on_id":"archie-core-1ysw","type":"parent-child","created_at":"2026-08-22T21:01:44Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":0,"dependent_count":0,"comment_count":0} {"_type":"issue","id":"archie-core-j8b4","title":"Implement persistent session memory and plugin storage","description":"Replace the PRD section 3 placeholder in internal/storage/storage.go with the specified persistent storage behavior for session.jsonl, memory.jsonl, and plugins.","status":"closed","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-08-22T10:32:31Z","created_by":"Sam Catlow","updated_at":"2026-08-24T07:12:08Z","started_at":"2026-08-22T10:32:37Z","closed_at":"2026-08-24T07:12:08Z","close_reason":"Implemented persistent session transcript, cross-session memory, and staged plugin storage [Closure restored 2026-08-24: originally closed 2026-08-22, lost when the beads DB was rebuilt (.beads.backup-pre-recovery).]","external_ref":"https://github.com/samcharles93/archie-core/issues/602","metadata":null,"dependency_count":0,"dependent_count":0,"comment_count":0} -{"_type":"issue","id":"archie-core-t2db.6","title":"Docs: document playbooks, bindings and the intake threat model","description":"Separate so it is not lost when the feature lands.\n\n- The playbook/binding model in docs/architecture/: what a binding is, where it is persisted, how matchers resolve, how versioning works.\n- The threat model, written down plainly: this is a public intake surface that can start agents. Record what protects it and what does not.\n- ARCHITECTURE.md task lifecycle: a task started by a playbook binding has a different provenance from a forge-issue task, and the lifecycle section should say so.\n- Operator docs: how to point an external app at archie and build a first playbook, end to end.\n\nCLAUDE.md's rule: a doc that contradicts its code is worse than none.\n\nPROGRESS 2026-09-03: three of four items done.\n- Binding model + threat model: docs/architecture/bindings.md (commit 41dffe3), every claim verified against actual code, not assumed.\n- ARCHITECTURE.md task lifecycle: provenance addendum landed (commit edb90e1), cross-referencing bindings.md. Also fixed a second, related staleness in the same section (the Routing table no longer reflects hardcoded-only behavior post t2db.9/.10).\n- Remaining (BLOCKED, not just unstarted): the end-to-end operator walkthrough. The epic's own pitch is a no-code, DASHBOARD-based flow ('point a webhook at archie, open the dashboard, map fields, bind, save'). Verified 2026-09-03: ui/src/ has zero binding-related files -- t2db.8's UI editor does not exist yet. Writing a walkthrough describing dashboard clicks that don't exist would itself be exactly the 'doc that contradicts its code' problem this ticket exists to prevent, just prospectively. Added a formal dependency on t2db.8 rather than write a curl-based workaround doc that misrepresents the intended no-code experience -- do the walkthrough after t2db.8's UI lands, describing what actually exists.","acceptance_criteria":"Operator walkthrough exists, end to end, describing the real dashboard UI (blocked on t2db.8). The other three acceptance items (binding model + threat model documented, ARCHITECTURE.md covers playbook-originated tasks) are done.","status":"open","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-08-21T13:45:46Z","created_by":"Sam Catlow","updated_at":"2026-09-02T18:41:44Z","external_ref":"https://github.com/samcharles93/archie-core/issues/553","dependencies":[{"issue_id":"archie-core-t2db.6","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-08-21T23:45:45Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-t2db.6","depends_on_id":"archie-core-t2db.4","type":"blocks","created_at":"2026-08-21T23:45:53Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-t2db.6","depends_on_id":"archie-core-t2db.8","type":"blocks","created_at":"2026-09-02T18:41:43Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":2,"dependent_count":0,"comment_count":0} +{"_type":"issue","id":"archie-core-t2db.6","title":"Docs: document playbooks, bindings and the intake threat model","description":"Separate so it is not lost when the feature lands.\n\n- The playbook/binding model in docs/architecture/: what a binding is, where it is persisted, how matchers resolve, how versioning works.\n- The threat model, written down plainly: this is a public intake surface that can start agents. Record what protects it and what does not.\n- ARCHITECTURE.md task lifecycle: a task started by a playbook binding has a different provenance from a forge-issue task, and the lifecycle section should say so.\n- Operator docs: how to point an external app at archie and build a first playbook, end to end.\n\nCLAUDE.md's rule: a doc that contradicts its code is worse than none.\n\nPROGRESS 2026-09-03: three of four items done.\n- Binding model + threat model: docs/architecture/bindings.md (commit 41dffe3), every claim verified against actual code, not assumed.\n- ARCHITECTURE.md task lifecycle: provenance addendum landed (commit edb90e1), cross-referencing bindings.md. Also fixed a second, related staleness in the same section (the Routing table no longer reflects hardcoded-only behavior post t2db.9/.10).\n- Remaining (BLOCKED, not just unstarted): the end-to-end operator walkthrough. The epic's own pitch is a no-code, DASHBOARD-based flow ('point a webhook at archie, open the dashboard, map fields, bind, save'). Verified 2026-09-03: ui/src/ has zero binding-related files -- t2db.8's UI editor does not exist yet. Writing a walkthrough describing dashboard clicks that don't exist would itself be exactly the 'doc that contradicts its code' problem this ticket exists to prevent, just prospectively. Added a formal dependency on t2db.8 rather than write a curl-based workaround doc that misrepresents the intended no-code experience -- do the walkthrough after t2db.8's UI lands, describing what actually exists.","acceptance_criteria":"Operator walkthrough exists, end to end, describing the real dashboard UI (blocked on t2db.8). The other three acceptance items (binding model + threat model documented, ARCHITECTURE.md covers playbook-originated tasks) are done.","status":"closed","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-08-21T13:45:46Z","created_by":"Sam Catlow","updated_at":"2026-09-02T20:20:15Z","closed_at":"2026-09-02T20:20:15Z","close_reason":"All four items done: binding model + threat model (bindings.md, 41dffe3), ARCHITECTURE.md task-lifecycle addendum (edb90e1), operator walkthrough (this commit). Unblocked once t2db.8's UI landed.","external_ref":"https://github.com/samcharles93/archie-core/issues/553","dependencies":[{"issue_id":"archie-core-t2db.6","depends_on_id":"archie-core-t2db","type":"parent-child","created_at":"2026-08-21T23:45:45Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-t2db.6","depends_on_id":"archie-core-t2db.4","type":"blocks","created_at":"2026-08-21T23:45:53Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-t2db.6","depends_on_id":"archie-core-t2db.8","type":"blocks","created_at":"2026-09-02T18:41:43Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":2,"dependent_count":0,"comment_count":0} {"_type":"issue","id":"archie-core-7d5u.6","title":"Docs: reconcile plugins-and-extensions.md and ARCHITECTURE.md with the shipped event model","description":"Separate bead so it is not lost once the feature lands.\n\n1. docs/architecture/plugins-and-extensions.md is an APPROVED foundation dated 2026-07-28 and currently describes only the plugin framework. If the design bead concluded that extensions may react to events, this doc has to say how -- and if it concluded that generic untyped dispatch is allowed after all, this doc must be amended deliberately rather than contradicted by code.\n\n2. ARCHITECTURE.md describes work intake as polling. Once webhook intake ships, that is no longer the whole picture, and the task lifecycle section needs the new entry path.\n\n3. CLAUDE.md's per-package traps section should gain whatever trap this work creates -- HMAC verification, replay windows, the poll/webhook double-dispatch hazard. That section exists precisely for things an agent will otherwise break.\n\n4. config.example.toml needs the intake flag documented with its default, alongside poll_interval.\n\nCLAUDE.md's own rule: a doc that contradicts its code is worse than none, because the next reader trusts it.","acceptance_criteria":"plugins-and-extensions.md reflects the decided extension model; ARCHITECTURE.md documents webhook intake alongside polling; config.example.toml documents the intake flag and default; any new trap is recorded in CLAUDE.md.","status":"open","priority":2,"issue_type":"task","owner":"sam@catlow.tech","created_at":"2026-08-21T13:26:52Z","created_by":"Sam Catlow","updated_at":"2026-08-22T09:25:30Z","external_ref":"https://github.com/samcharles93/archie-core/issues/554","dependencies":[{"issue_id":"archie-core-7d5u.6","depends_on_id":"archie-core-7d5u","type":"parent-child","created_at":"2026-08-21T23:26:51Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-7d5u.6","depends_on_id":"archie-core-7d5u.4","type":"blocks","created_at":"2026-08-21T23:26:58Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":1,"dependent_count":0,"comment_count":0} {"_type":"issue","id":"archie-core-h019.5","title":"Calibration: confirm findings adversarially before surfacing them","description":"The risk that kills this feature is a reviewer that cries wolf. A findings list padded with speculation trains the operator to skim past it, and then the feature is worse than nothing because it consumes attention while lowering trust.\n\nBefore a finding is surfaced, it must be independently checked and marked CONFIRMED or PLAUSIBLE, with only CONFIRMED able to block. The reviewer must also be able to return zero findings, and to state which properties it checked and cleared -- a review that reports nothing is a valid and welcome result, and saying so explicitly is what distinguishes 'I checked and it is fine' from 'I did not look'.\n\nPrior art from the 2026-08-20/21 sessions on PR #530: three passes each separated confirmed from plausible, one explicitly listed properties it had verified clean, and the confirmed findings were reproduced by mutation before being trusted. That calibration is the feature, not the finding count.","acceptance_criteria":"Only CONFIRMED findings block PR creation; a zero-finding review is representable and reported as such; the reviewer records which properties it checked and cleared; padding with style nits is explicitly out of contract.","status":"open","priority":2,"issue_type":"feature","owner":"sam@catlow.tech","created_at":"2026-08-21T13:03:15Z","created_by":"Sam Catlow","updated_at":"2026-08-22T09:25:30Z","external_ref":"https://github.com/samcharles93/archie-core/issues/555","dependencies":[{"issue_id":"archie-core-h019.5","depends_on_id":"archie-core-h019","type":"parent-child","created_at":"2026-08-21T13:03:15Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-h019.5","depends_on_id":"archie-core-h019.1","type":"blocks","created_at":"2026-08-21T13:03:25Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-h019.5","depends_on_id":"archie-core-h019.2","type":"blocks","created_at":"2026-08-21T13:03:25Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":2,"dependent_count":0,"comment_count":0} {"_type":"issue","id":"archie-core-h019.6","title":"Surface findings on the PR body and the dashboard","description":"The output has to land where the operator already looks, or the review is invisible work.\n\nOn the PR archie opens: a findings section stating what was checked, what was found, what was fixed, and what survived. A PR with zero findings should say the review ran and found nothing -- silence is indistinguishable from the review not running, which is the same unverified-claim problem the update-verification work (PR #530) was about.\n\nOn the dashboard and /api/tasks: a parked-for-findings task must show why, the same way a park reason is already surfaced today. An operator seeing waiting_human needs the findings without digging through logs.","acceptance_criteria":"PR body carries a findings section including the zero-finding case; a task parked on a surviving finding shows the findings as its park reason in the dashboard and /api/tasks; nothing requires reading task logs to learn why a PR was withheld.","status":"open","priority":2,"issue_type":"feature","owner":"sam@catlow.tech","created_at":"2026-08-21T13:03:15Z","created_by":"Sam Catlow","updated_at":"2026-08-22T09:25:31Z","external_ref":"https://github.com/samcharles93/archie-core/issues/556","dependencies":[{"issue_id":"archie-core-h019.6","depends_on_id":"archie-core-h019","type":"parent-child","created_at":"2026-08-21T13:03:15Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-h019.6","depends_on_id":"archie-core-h019.1","type":"blocks","created_at":"2026-08-21T13:03:25Z","created_by":"Sam Catlow","metadata":"{}"},{"issue_id":"archie-core-h019.6","depends_on_id":"archie-core-h019.2","type":"blocks","created_at":"2026-08-21T13:03:26Z","created_by":"Sam Catlow","metadata":"{}"}],"dependency_count":2,"dependent_count":1,"comment_count":0}